1 Return-Path: <pieter@praet.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 466EA429E21
\r
6 for <notmuch@notmuchmail.org>; Wed, 16 Nov 2011 03:01:20 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id v9OFLCwkQaMU for <notmuch@notmuchmail.org>;
\r
16 Wed, 16 Nov 2011 03:01:19 -0800 (PST)
\r
17 Received: from mail-wy0-f181.google.com (mail-wy0-f181.google.com
\r
18 [74.125.82.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 54784431FB6
\r
21 for <notmuch@notmuchmail.org>; Wed, 16 Nov 2011 03:01:19 -0800 (PST)
\r
22 Received: by wyg19 with SMTP id 19so338927wyg.26
\r
23 for <notmuch@notmuchmail.org>; Wed, 16 Nov 2011 03:01:18 -0800 (PST)
\r
24 Received: by 10.180.14.134 with SMTP id p6mr12510196wic.25.1321441273524;
\r
25 Wed, 16 Nov 2011 03:01:13 -0800 (PST)
\r
26 Received: from localhost ([109.131.148.49])
\r
27 by mx.google.com with ESMTPS id l2sm2920855wbn.0.2011.11.16.03.01.12
\r
28 (version=TLSv1/SSLv3 cipher=OTHER);
\r
29 Wed, 16 Nov 2011 03:01:12 -0800 (PST)
\r
30 From: Pieter Praet <pieter@praet.org>
\r
31 To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>, notmuch@notmuchmail.org
\r
32 Subject: Re: [PATCH] emacs: add insisible space after the search widget field
\r
34 In-Reply-To: <1309762025-1172-1-git-send-email-dmitry.kurochkin@gmail.com>
\r
35 References: <1309762025-1172-1-git-send-email-dmitry.kurochkin@gmail.com>
\r
36 User-Agent: Notmuch/0.9+76~g2fd88e6 (http://notmuchmail.org) Emacs/23.3.1
\r
37 (x86_64-unknown-linux-gnu)
\r
38 Date: Wed, 16 Nov 2011 12:00:19 +0100
\r
39 Message-ID: <87k470fi2k.fsf@praet.org>
\r
41 Content-Type: text/plain; charset=us-ascii
\r
42 X-BeenThere: notmuch@notmuchmail.org
\r
43 X-Mailman-Version: 2.1.13
\r
45 List-Id: "Use and development of the notmuch mail system."
\r
46 <notmuch.notmuchmail.org>
\r
47 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
48 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
49 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
50 List-Post: <mailto:notmuch@notmuchmail.org>
\r
51 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
52 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
53 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
54 X-List-Received-Date: Wed, 16 Nov 2011 11:01:20 -0000
\r
56 On Mon, 4 Jul 2011 10:47:05 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
\r
57 > It is very convenient when C-e (bound to `widget-end-of-line') ignores
\r
58 > trailing spaces inside the search widget. But it only does so if a
\r
59 > widget is not followed by a newline (that is why it works in the saved
\r
60 > search widgets). The patch just adds an insisible space after the
\r
61 > search widget to get the desirable behavior of `widget-end-of-line'.
\r
62 > The extra space is also added to expected results of emacs tests.
\r
64 > emacs/notmuch-hello.el | 4 ++++
\r
65 > test/emacs.expected-output/notmuch-hello | 2 +-
\r
66 > .../notmuch-hello-no-saved-searches | 2 +-
\r
67 > .../emacs.expected-output/notmuch-hello-with-empty | 2 +-
\r
68 > 4 files changed, 7 insertions(+), 3 deletions(-)
\r
70 > diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
\r
71 > index 65fde75..1a76c30 100644
\r
72 > --- a/emacs/notmuch-hello.el
\r
73 > +++ b/emacs/notmuch-hello.el
\r
74 > @@ -462,6 +462,10 @@ Complete list of currently available key bindings:
\r
75 > (length "Search: ")))
\r
76 > :action (lambda (widget &rest ignore)
\r
77 > (notmuch-hello-search (widget-value widget))))
\r
78 > + ;; add an invisible space to make `widget-end-of-line' ignore
\r
79 > + ;; trailine spaces in the search widget field
\r
80 > + (widget-insert " ")
\r
81 > + (put-text-property (1- (point)) (point) 'invisible t)
\r
82 > (widget-insert "\n")
\r
84 > (when notmuch-hello-recent-searches
\r
85 > diff --git a/test/emacs.expected-output/notmuch-hello b/test/emacs.expected-output/notmuch-hello
\r
86 > index 64b7e42..48143bd 100644
\r
87 > --- a/test/emacs.expected-output/notmuch-hello
\r
88 > +++ b/test/emacs.expected-output/notmuch-hello
\r
89 > @@ -4,7 +4,7 @@ Saved searches: [edit]
\r
91 > 50 inbox 50 unread
\r
98 > diff --git a/test/emacs.expected-output/notmuch-hello-no-saved-searches b/test/emacs.expected-output/notmuch-hello-no-saved-searches
\r
99 > index 7f8206a..7c09e40 100644
\r
100 > --- a/test/emacs.expected-output/notmuch-hello-no-saved-searches
\r
101 > +++ b/test/emacs.expected-output/notmuch-hello-no-saved-searches
\r
103 > Welcome to notmuch. You have 50 messages.
\r
110 > diff --git a/test/emacs.expected-output/notmuch-hello-with-empty b/test/emacs.expected-output/notmuch-hello-with-empty
\r
111 > index a9ed630..2a267c9 100644
\r
112 > --- a/test/emacs.expected-output/notmuch-hello-with-empty
\r
113 > +++ b/test/emacs.expected-output/notmuch-hello-with-empty
\r
114 > @@ -4,7 +4,7 @@ Saved searches: [edit]
\r
116 > 50 inbox 50 unread 0 empty
\r
126 > _______________________________________________
\r
127 > notmuch mailing list
\r
128 > notmuch@notmuchmail.org
\r
129 > http://notmuchmail.org/mailman/listinfo/notmuch
\r
131 Appears to have been merged in by the powers that be: commit e972d752
\r