1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by arlo.cworth.org (Postfix) with ESMTP id 990B06DE0159
\r
6 for <notmuch@notmuchmail.org>; Mon, 13 Jun 2016 01:11:27 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at cworth.org
\r
11 X-Spam-Status: No, score=0.569 tagged_above=-999 required=5 tests=[AWL=-0.083,
\r
12 SPF_NEUTRAL=0.652] autolearn=disabled
\r
13 Received: from arlo.cworth.org ([127.0.0.1])
\r
14 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id LCxPDj2AiK3h for <notmuch@notmuchmail.org>;
\r
16 Mon, 13 Jun 2016 01:11:19 -0700 (PDT)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by arlo.cworth.org (Postfix) with ESMTP id BB2CE6DE0127
\r
19 for <notmuch@notmuchmail.org>; Mon, 13 Jun 2016 01:11:17 -0700 (PDT)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id 07925100063;
\r
22 Mon, 13 Jun 2016 11:10:51 +0300 (EEST)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
\r
25 Subject: Re: [PATCH 2/8] lib: private string map (associative array) API
\r
26 In-Reply-To: <1465779955-5539-3-git-send-email-david@tethera.net>
\r
27 References: <1465779955-5539-1-git-send-email-david@tethera.net>
\r
28 <1465779955-5539-3-git-send-email-david@tethera.net>
\r
29 User-Agent: Notmuch/0.22+54~gf8fd4ff (https://notmuchmail.org) Emacs/24.5.1
\r
30 (x86_64-unknown-linux-gnu)
\r
31 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
32 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
33 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
34 Date: Mon, 13 Jun 2016 11:10:50 +0300
\r
35 Message-ID: <m2oa755x11.fsf@guru.guru-group.fi>
\r
37 Content-Type: text/plain
\r
38 X-BeenThere: notmuch@notmuchmail.org
\r
39 X-Mailman-Version: 2.1.20
\r
41 List-Id: "Use and development of the notmuch mail system."
\r
42 <notmuch.notmuchmail.org>
\r
43 List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
\r
44 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
45 List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
\r
46 List-Post: <mailto:notmuch@notmuchmail.org>
\r
47 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
48 List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
\r
49 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
50 X-List-Received-Date: Mon, 13 Jun 2016 08:11:27 -0000
\r
52 On Mon, Jun 13 2016, David Bremner <david@tethera.net> wrote:
\r
54 > The choice of array implementation is deliberate, for future iterator support
\r
56 > lib/Makefile.local | 1 +
\r
57 > lib/notmuch-private.h | 11 ++++
\r
58 > lib/string-map.c | 153 ++++++++++++++++++++++++++++++++++++++++++++++++++
\r
59 > 3 files changed, 165 insertions(+)
\r
60 > create mode 100644 lib/string-map.c
\r
62 > diff --git a/lib/Makefile.local b/lib/Makefile.local
\r
63 > index beb9635..9280880 100644
\r
64 > --- a/lib/Makefile.local
\r
65 > +++ b/lib/Makefile.local
\r
66 > @@ -40,6 +40,7 @@ libnotmuch_c_srcs = \
\r
67 > $(dir)/messages.c \
\r
69 > $(dir)/built-with.c \
\r
70 > + $(dir)/string-map.c \
\r
73 I suggest everyone to install editor which supports showing tabs & spaces
\r
74 e.g. in different color and also visualizes trailing whitespace & trailing
\r
77 ... personally I've been pretty happy with ethan-wspace in emacs to do
\r
78 that (I did M-x ethan-wspace-highlight-tabs-mode (in notmuch-show mode
\r
79 buffer) to recognize the above).
\r
81 If there is no need to further changes then the above can IMO go in --
\r
82 the same "dirtiness" can be observed in $(dir)/query-fp.cc 10 lines below...
\r