1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by arlo.cworth.org (Postfix) with ESMTP id 1AE416DE0298
\r
6 for <notmuch@notmuchmail.org>; Tue, 23 Jun 2015 14:14:28 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at cworth.org
\r
11 X-Spam-Status: No, score=0.968 tagged_above=-999 required=5 tests=[AWL=0.316,
\r
12 SPF_NEUTRAL=0.652] autolearn=disabled
\r
13 Received: from arlo.cworth.org ([127.0.0.1])
\r
14 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id iNlF9P8r2IYX for <notmuch@notmuchmail.org>;
\r
16 Tue, 23 Jun 2015 14:14:25 -0700 (PDT)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by arlo.cworth.org (Postfix) with ESMTP id 878B06DE028A
\r
19 for <notmuch@notmuchmail.org>; Tue, 23 Jun 2015 14:14:25 -0700 (PDT)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id B38D9100046;
\r
22 Wed, 24 Jun 2015 00:14:02 +0300 (EEST)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: David Bremner <david@tethera.net>,
\r
25 Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
\r
26 Subject: Re: [PATCH] emacs: tree: mark read change
\r
27 In-Reply-To: <87si9iyxn9.fsf@maritornes.cs.unb.ca>
\r
28 References: <1433843467-32398-1-git-send-email-markwalters1009@gmail.com>
\r
29 <87si9iyxn9.fsf@maritornes.cs.unb.ca>
\r
30 User-Agent: Notmuch/0.20.1+30~g467da49 (http://notmuchmail.org) Emacs/24.3.1
\r
31 (x86_64-unknown-linux-gnu)
\r
32 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
33 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
34 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
35 Date: Wed, 24 Jun 2015 00:14:02 +0300
\r
36 Message-ID: <m2616eb011.fsf@guru.guru-group.fi>
\r
38 Content-Type: text/plain
\r
39 X-BeenThere: notmuch@notmuchmail.org
\r
40 X-Mailman-Version: 2.1.18
\r
42 List-Id: "Use and development of the notmuch mail system."
\r
43 <notmuch.notmuchmail.org>
\r
44 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
45 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
46 List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
\r
47 List-Post: <mailto:notmuch@notmuchmail.org>
\r
48 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
49 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
50 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
51 X-List-Received-Date: Tue, 23 Jun 2015 21:14:28 -0000
\r
53 On Tue, Jun 23 2015, David Bremner <david@tethera.net> wrote:
\r
55 > Mark Walters <markwalters1009@gmail.com> writes:
\r
57 >> The mark read code for tree mode did not get updated in the recent
\r
58 >> changes. This updates it to match. Since the user can customize the
\r
59 >> mark read logic we just call the show logic in the message pane.
\r
62 >> An alternative would be to mark any message explicitly viewed in
\r
63 >> tree-mode as read. That would be simpler but I think this is better as
\r
64 >> it deals with user customized mark read functions -- for example if
\r
65 >> the user has a customized function that only marks a message read if
\r
66 >> the whole message is viewed then this version will do the same in tree
\r
69 > At first I was leery of the chaining of hooks, but now that I
\r
70 > noticed/experienced the bug, it makes more sense to me. I'm considering
\r
71 > rolling a bug fix release with this (I imagine the bug is pretty
\r
72 > annoying for people using only notmuch-tree), so I'd like a bit more
\r
73 > feedback before merging it.
\r
75 >From code point of view it looks good to me.
\r