1 Return-Path: <raorn@raorn.name>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 7B739431FBC
\r
6 for <notmuch@notmuchmail.org>; Tue, 30 Apr 2013 02:52:15 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0.363 tagged_above=-999 required=5
\r
12 tests=[RDNS_DYNAMIC=0.363] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id 2T4VW-4anzlh for <notmuch@notmuchmail.org>;
\r
16 Tue, 30 Apr 2013 02:52:11 -0700 (PDT)
\r
17 Received: from mail.raorn.name (c2-81-23-10-117.elastic.cloud.croc.ru
\r
19 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id E538E431FAF
\r
22 for <notmuch@notmuchmail.org>; Tue, 30 Apr 2013 02:52:10 -0700 (PDT)
\r
23 Received: by mail.raorn.name (Postfix, from userid 500)
\r
24 id 340C219A; Tue, 30 Apr 2013 13:52:14 +0400 (MSK)
\r
25 Date: Tue, 30 Apr 2013 13:52:14 +0400
\r
26 From: "Alexey I. Froloff" <raorn@raorn.name>
\r
27 To: David Bremner <david@tethera.net>
\r
28 Subject: Re: [PATCH] lib: Add a new prefix "list" to the search-terms syntax
\r
29 Message-ID: <20130430095213.GA2861@raorn.name>
\r
30 References: <20130409083010.GA27675@raorn.name>
\r
31 <1365549369-12776-1-git-send-email-raorn@raorn.name>
\r
32 <87vc74vn2n.fsf@zancas.localnet>
\r
34 Content-Type: multipart/signed; micalg=pgp-sha1;
\r
35 protocol="application/pgp-signature"; boundary="ReaqsoxgOBHFXBhH"
\r
36 Content-Disposition: inline
\r
37 In-Reply-To: <87vc74vn2n.fsf@zancas.localnet>
\r
38 User-Agent: Mutt/1.5.21 (2010-12-30)
\r
39 Cc: notmuch@notmuchmail.org
\r
40 X-BeenThere: notmuch@notmuchmail.org
\r
41 X-Mailman-Version: 2.1.13
\r
43 List-Id: "Use and development of the notmuch mail system."
\r
44 <notmuch.notmuchmail.org>
\r
45 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
46 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
47 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
48 List-Post: <mailto:notmuch@notmuchmail.org>
\r
49 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
50 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
51 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
52 X-List-Received-Date: Tue, 30 Apr 2013 09:52:15 -0000
\r
56 Content-Type: text/plain; charset=us-ascii
\r
57 Content-Disposition: inline
\r
58 Content-Transfer-Encoding: quoted-printable
\r
60 On Mon, Apr 29, 2013 at 10:12:16PM -0300, David Bremner wrote:
\r
61 > > + begin_list_id =3D strrchr (list_id_header, '<');
\r
62 > > + if (!begin_list_id) {
\r
63 > > + fprintf (stderr, "Warning: Not indexing mailformed List-Id tag.\n");
\r
66 > - I guess this should say "malformed".=20
\r
67 My bad. English is not my native language ;-)
\r
69 > - I got about 1800 lines of such messages when indexing 280k
\r
70 > messages. That might strike some people as excessive. On the otherhand
\r
71 > I guess we need to re-think error reporting overall.
\r
72 If I understand correctly, this code belongs to library and
\r
73 should not print anything neither on stderr nor stdout. OTOH,
\r
74 surrounding functions do print messages on error, so I just did
\r
77 > What do you think about printing filename or message-id here its
\r
78 > easier to double check that it is not a bug?
\r
79 Giving Message-Id makes sense.
\r
81 > > + void *local =3D talloc_new (message);
\r
82 > we should handle ENOMEM here, I think.
\r
83 There are 16 talloc_new() calls and ENOMEM is not handled
\r
86 > > + /* _notmuch_message_add_term() may return
\r
87 > > + * NOTMUCH_PRIVATE_STATUS_TERM_TOO_LONG here. We can't fix it, but
\r
88 > > + * this is not a reason to exit with error... */
\r
89 > > + if (_notmuch_message_add_term (message, "list", list_id))
\r
90 > > + fprintf (stderr, "Warning: Not indexing List-Id: <%s>\n", list_id);
\r
91 > This should say why the indexing failed.
\r
92 There should be strerror-like function, then can give description
\r
93 for a given status code.
\r
95 > - We need a couple tests for this code; tests/search should give some
\r
96 > hints how to proceed.
\r
99 > - We need a patch for NEWS, explaining what people need to do take
\r
100 > advantage of the new functionality. I think that adding new prefixes
\r
101 > to an existing database is OK, but I'd welcome confirmation.
\r
106 Sir Raorn. --- http://thousandsofhate.blogspot.com/
\r
109 Content-Type: application/pgp-signature; name="signature.asc"
\r
110 Content-Description: Digital signature
\r
112 -----BEGIN PGP SIGNATURE-----
\r
113 Version: GnuPG v1.4.11 (GNU/Linux)
\r
115 iQEcBAEBAgAGBQJRf5RKAAoJEBd6rh2Yq9Fr+3oIAMSFO6LGdtIkmsZ0z9PSRMFP
\r
116 txbmq0ZIfyHrfUpre/UGDHUPhjX3n9lBMeKYcNMEO4OiswbeCr071+2AK81ZCK4a
\r
117 e9cBK3VdjX9Gqi58RNqfzCw4IZJfveumeQskxx9z4PFDEgl9uBQbfuc51bEj/KAA
\r
118 YpazoXtnhisG2UT0bO+WndbxvnGHgRb9jY1bukMjwHYVLV4f5gZ06ZGRMtXkBBjm
\r
119 r76BNRMx/G/h173R0t89whRsECug3HW7raPOnaeZGrKbY3e9gGn+6+4x08YynXwJ
\r
120 PyBjREDykmLHHEXAziDq9AjxoirdF8Er2M5dvMec0VYqSv7VmEYpXaw9ohOE0us=
\r
122 -----END PGP SIGNATURE-----
\r
124 --ReaqsoxgOBHFXBhH--
\r