1 Return-Path: <polatel@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 0B1D2431FC7
\r
6 for <notmuch@notmuchmail.org>; Tue, 21 May 2013 07:46:37 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id HSDXYcFTx-DV for <notmuch@notmuchmail.org>;
\r
17 Tue, 21 May 2013 07:46:32 -0700 (PDT)
\r
18 Received: from mail-ea0-f175.google.com (mail-ea0-f175.google.com
\r
19 [209.85.215.175]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 8D356431FB6
\r
22 for <notmuch@notmuchmail.org>; Tue, 21 May 2013 07:46:32 -0700 (PDT)
\r
23 Received: by mail-ea0-f175.google.com with SMTP id h10so453655eaj.34
\r
24 for <notmuch@notmuchmail.org>; Tue, 21 May 2013 07:46:31 -0700 (PDT)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
\r
26 h=date:from:to:cc:subject:message-id:mail-followup-to:references
\r
27 :mime-version:content-type:content-disposition:in-reply-to
\r
28 :organization:user-agent;
\r
29 bh=C2zmDtZNk03NQZ3kPsSnKubxEICY+i8qBo1CYeOzhOo=;
\r
30 b=TpEMwmONavMAvCuqNROvLDocQc7/1Cv8qBov7xD1iEkXyLsqCvlSEbpkOg2qE79Bl4
\r
31 c0jisNfmQseGphuB9nfFY9kayhQnwVLsR7dhL8yuPpGpeQB2eqRX/kz7iazqtnE7Om7e
\r
32 jKR9NbALMbPqrNUHXhBclCstK2/mUArulmzBqba0D1sCXMqFGVu25w8/y1Hbrp4Prckl
\r
33 Ev8kxknx7H+OWGmCHIhLKJGaAjaX8dNGue8vke7rbROZ8DL0o3qXITRmbZOotvvzlM0X
\r
34 El3LtHFpyO6jnuXJTXGihEzw+vHqbrTTJ5WdqHVk7kONwVJDWgq96PLjteUBPqBIvlor
\r
36 X-Received: by 10.15.22.135 with SMTP id f7mr7233454eeu.29.1369147591340;
\r
37 Tue, 21 May 2013 07:46:31 -0700 (PDT)
\r
38 Received: from localhost ([88.234.58.113])
\r
39 by mx.google.com with ESMTPSA id x41sm3965936eey.17.2013.05.21.07.46.29
\r
40 for <multiple recipients>
\r
41 (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
\r
42 Tue, 21 May 2013 07:46:30 -0700 (PDT)
\r
43 Date: Tue, 21 May 2013 17:46:59 +0300
\r
44 From: Ali Polatel <polatel@gmail.com>
\r
45 To: Tomi Ollila <tomi.ollila@iki.fi>
\r
46 Subject: Re: [PATCH 2/2] ruby: fix missing symbol UINT2FIX()
\r
47 Message-ID: <20130521144659.GA6002@hayalet>
\r
48 Mail-Followup-To: Tomi Ollila <tomi.ollila@iki.fi>,
\r
49 Felipe Contreras <felipe.contreras@gmail.com>,
\r
50 notmuch@notmuchmail.org
\r
51 References: <1369052664-17869-1-git-send-email-felipe.contreras@gmail.com>
\r
52 <1369052664-17869-3-git-send-email-felipe.contreras@gmail.com>
\r
53 <m2vc6c4dtq.fsf@guru.guru-group.fi>
\r
55 Content-Type: multipart/signed; micalg=pgp-sha1;
\r
56 protocol="application/pgp-signature"; boundary="X1bOJ3K7DJ5YkBrT"
\r
57 Content-Disposition: inline
\r
58 In-Reply-To: <m2vc6c4dtq.fsf@guru.guru-group.fi>
\r
59 Organization: Pink Floyd
\r
60 User-Agent: Mutt/1.5.21 (2010-09-15)
\r
61 Cc: notmuch@notmuchmail.org
\r
62 X-BeenThere: notmuch@notmuchmail.org
\r
63 X-Mailman-Version: 2.1.13
\r
65 List-Id: "Use and development of the notmuch mail system."
\r
66 <notmuch.notmuchmail.org>
\r
67 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
68 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
69 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
70 List-Post: <mailto:notmuch@notmuchmail.org>
\r
71 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
72 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
73 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
74 X-List-Received-Date: Tue, 21 May 2013 14:46:37 -0000
\r
78 Content-Type: text/plain; charset=us-ascii; format=flowed
\r
79 Content-Disposition: inline
\r
81 2013/05/21 Tomi Ollila <tomi.ollila@iki.fi>:
\r
82 >On Mon, May 20 2013, Felipe Contreras <felipe.contreras@gmail.com> wrote:
\r
84 >> It has never existed in Ruby (maybe JRuby). Fortunately the symbols are
\r
85 >> loaded lazily, so nobody would notice unless they try
\r
86 >> 'query::count_messages'.
\r
88 >> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
\r
90 >This patch could be pushed on it's own, but someone (like Ali) could
\r
91 >comment on the change as searches on both UINT2FIX() & UINT2NUM()
\r
92 >provides (IMH) insatisfactory results...
\r
96 My bad, there's no such thing as UINT2FIX().
\r
97 Yet, what's wrong with UINT2NUM()?
\r
99 The description looks like:
\r
100 "...take an unsigned int and convert it to a FIXNUM object if it will fit;
\r
101 otherwise, convert to a Bignum object..."
\r
103 Besides ruby-1.8 has it and that's the oldest version I was willing to
\r
104 support. (If you have some free time, please confirm this because I may
\r
105 not be remembering correctly.)
\r
113 >> bindings/ruby/query.c | 2 +-
\r
114 >> 1 file changed, 1 insertion(+), 1 deletion(-)
\r
116 >> diff --git a/bindings/ruby/query.c b/bindings/ruby/query.c
\r
117 >> index e5ba1b7..1658ede 100644
\r
118 >> --- a/bindings/ruby/query.c
\r
119 >> +++ b/bindings/ruby/query.c
\r
120 >> @@ -180,5 +180,5 @@ notmuch_rb_query_count_messages (VALUE self)
\r
121 >> * (function may return 0 after printing a message)
\r
122 >> * Thus there is nothing we can do here...
\r
124 >> - return UINT2FIX(notmuch_query_count_messages(query));
\r
125 >> + return UINT2NUM(notmuch_query_count_messages(query));
\r
128 >> 1.8.3.rc3.286.g3d43083
\r
130 >> _______________________________________________
\r
131 >> notmuch mailing list
\r
132 >> notmuch@notmuchmail.org
\r
133 >> http://notmuchmail.org/mailman/listinfo/notmuch
\r
136 Content-Type: application/pgp-signature
\r
138 -----BEGIN PGP SIGNATURE-----
\r
139 Version: GnuPG v2.0.19 (GNU/Linux)
\r
141 iEYEARECAAYFAlGbiOAACgkQQU4yORhF8iBBGACdEaM899S+FCDWzTKnT4rEUsho
\r
142 yHsAn1kzSlkWOacI25lREHn+q6boc6el
\r
144 -----END PGP SIGNATURE-----
\r
146 --X1bOJ3K7DJ5YkBrT--
\r