1 Return-Path: <teythoon@jade-hamburg.de>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 97704429E25
\r
6 for <notmuch@notmuchmail.org>; Tue, 4 Oct 2011 18:42:44 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0.001 tagged_above=-999 required=5
\r
12 tests=[UNPARSEABLE_RELAY=0.001] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id sofbC0R9wyMz for <notmuch@notmuchmail.org>;
\r
16 Tue, 4 Oct 2011 18:42:44 -0700 (PDT)
\r
17 Received: from mail.cryptobitch.de (cryptobitch.de [88.198.7.68])
\r
18 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id D9B1C431FB6
\r
21 for <notmuch@notmuchmail.org>; Tue, 4 Oct 2011 18:42:43 -0700 (PDT)
\r
22 Received: from mail.jade-hamburg.de (unknown [85.183.11.228])
\r
23 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
\r
24 (No client certificate requested)
\r
25 by mail.cryptobitch.de (Postfix) with ESMTPSA id A70F64C5F34
\r
26 for <notmuch@notmuchmail.org>; Wed, 5 Oct 2011 03:42:41 +0200 (CEST)
\r
27 Received: by mail.jade-hamburg.de (Postfix, from userid 401)
\r
28 id 9AAAEDF2A0; Wed, 5 Oct 2011 03:42:40 +0200 (CEST)
\r
29 Received: from thinkbox.jade-hamburg.de (unknown
\r
30 [IPv6:fe80::216:d3ff:fe3e:5058%br0])
\r
31 (using TLSv1 with cipher AES256-SHA (256/256 bits))
\r
32 (No client certificate requested) (Authenticated sender: teythoon)
\r
33 by mail.jade-hamburg.de (Postfix) with ESMTPSA id 277A4DF28B
\r
34 for <notmuch@notmuchmail.org>; Wed, 5 Oct 2011 03:42:39 +0200 (CEST)
\r
35 Received: from teythoon by thinkbox.jade-hamburg.de with local (Exim 4.76)
\r
36 (envelope-from <teythoon@thinkbox.jade-hamburg.de>)
\r
38 for notmuch@notmuchmail.org; Wed, 05 Oct 2011 03:42:39 +0200
\r
39 Content-Type: multipart/mixed; boundary="===============5663458428689395251=="
\r
41 Subject: python: unpythonic result of Message.get_replies()
\r
42 To: notmuch@notmuchmail.org
\r
43 From: Justus Winter <4winter@informatik.uni-hamburg.de>
\r
44 Date: Wed, 05 Oct 2011 03:42:38 +0200
\r
45 Message-Id: <E1RBGVK-0000Xu-Pc@thinkbox.jade-hamburg.de>
\r
46 X-BeenThere: notmuch@notmuchmail.org
\r
47 X-Mailman-Version: 2.1.13
\r
49 List-Id: "Use and development of the notmuch mail system."
\r
50 <notmuch.notmuchmail.org>
\r
51 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
52 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
53 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
54 List-Post: <mailto:notmuch@notmuchmail.org>
\r
55 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
56 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
57 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
58 X-List-Received-Date: Wed, 05 Oct 2011 01:42:44 -0000
\r
60 --===============5663458428689395251==
\r
62 Content-Type: text/plain; charset="utf-8"
\r
63 Content-Transfer-Encoding: quoted-printable
\r
68 I noticed that Message.get_replies() returns a Messages object *or*
\r
69 None. Quoting the documentation:
\r
71 > Returns: Messages or None if there are no replies to this message
\r
73 Messages is a class implementing the iterator protocol, so a python
\r
74 programmer would expect to get an iterator that raises a StopIteration
\r
75 on the first invocation of next() if there aren't any replies.
\r
77 With the current implementation one needs to do something like
\r
79 replies =3D message.get_replies()
\r
80 if replies !=3D None:
\r
81 for reply in replies:
\r
84 which looks awkward. Imho one should be able to just do
\r
86 for reply in message.get_replies():
\r
89 What do you think? Would it be possible to get this into the 0.9
\r
90 release? I could propose a patch if you like, but not today...
\r
94 --===============5663458428689395251==
\r
95 Content-Type: application/octet-stream
\r
97 Content-Transfer-Encoding: base64
\r
98 Content-Disposition: attachment; filename=".signature"
\r
100 bG92ZSB1IGFsb3QgQCxACgo=
\r
102 --===============5663458428689395251==--
\r