1 Return-Path: <jrollins@finestructure.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id D5BBB429E37
\r
6 for <notmuch@notmuchmail.org>; Wed, 4 Sep 2013 08:51:07 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id Q2hagh2zXCSo for <notmuch@notmuchmail.org>;
\r
16 Wed, 4 Sep 2013 08:51:01 -0700 (PDT)
\r
17 Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu
\r
19 by olra.theworths.org (Postfix) with ESMTP id 46D6F429E34
\r
20 for <notmuch@notmuchmail.org>; Wed, 4 Sep 2013 08:51:01 -0700 (PDT)
\r
21 Received: from fire-doxen.imss.caltech.edu (localhost [127.0.0.1])
\r
22 by fire-doxen-postvirus (Postfix) with ESMTP id 702863280B5;
\r
23 Wed, 4 Sep 2013 08:50:58 -0700 (PDT)
\r
24 X-Spam-Scanned: at Caltech-IMSS on fire-doxen by amavisd-new
\r
25 Received: from finestructure.net (unknown [198.129.209.144])
\r
26 (Authenticated sender: jrollins)
\r
27 by fire-doxen-submit (Postfix) with ESMTP id 1E1503280A2;
\r
28 Wed, 4 Sep 2013 08:50:57 -0700 (PDT)
\r
29 Received: by finestructure.net (Postfix, from userid 1000)
\r
30 id 8C8306008B; Wed, 4 Sep 2013 08:50:56 -0700 (PDT)
\r
31 From: Jameson Graef Rollins <jrollins@finestructure.net>
\r
32 To: Austin Clements <amdragon@MIT.EDU>,
\r
33 Mark Walters <markwalters1009@gmail.com>
\r
34 Subject: Re: [PATCH v2] emacs: show: lazy part bugfix
\r
35 In-Reply-To: <20130904145639.GB1426@mit.edu>
\r
36 References: <1377246875-7784-1-git-send-email-markwalters1009@gmail.com>
\r
37 <1378279835-28288-1-git-send-email-markwalters1009@gmail.com>
\r
38 <20130904145639.GB1426@mit.edu>
\r
39 User-Agent: Notmuch/0.16+40~g62789b1 (http://notmuchmail.org) Emacs/24.3.1
\r
40 (x86_64-pc-linux-gnu)
\r
41 Date: Wed, 04 Sep 2013 08:50:39 -0700
\r
42 Message-ID: <87hae07fhs.fsf@servo.finestructure.net>
\r
44 Content-Type: multipart/signed; boundary="=-=-=";
\r
45 micalg=pgp-sha256; protocol="application/pgp-signature"
\r
46 Cc: notmuch@notmuchmail.org
\r
47 X-BeenThere: notmuch@notmuchmail.org
\r
48 X-Mailman-Version: 2.1.13
\r
50 List-Id: "Use and development of the notmuch mail system."
\r
51 <notmuch.notmuchmail.org>
\r
52 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
53 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
54 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
55 List-Post: <mailto:notmuch@notmuchmail.org>
\r
56 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
57 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
58 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
59 X-List-Received-Date: Wed, 04 Sep 2013 15:51:08 -0000
\r
62 Content-Type: text/plain; charset=utf-8
\r
63 Content-Transfer-Encoding: quoted-printable
\r
65 On Wed, Sep 04 2013, Austin Clements <amdragon@MIT.EDU> wrote:
\r
66 >> Now, some mime parts have subparts and to avoid overwriting the
\r
67 >> sub-part data notmuch checks and if part data is already recorded it
\r
68 >> does not overwrite it.
\r
70 >> Now with lazy part handling this could fail: there is already part
\r
71 >> data stored. In the common case it works as the part type information
\r
72 >> was stored when the lazy-part button was inserted. However, this fails
\r
73 >> if the lazy part has sub-parts: notmuch had no idea these existed
\r
74 >> until the lazy part insertion.
\r
76 > This says that things fail when a lazy part has sub-parts, but not
\r
77 > what the failure is. What is the failure? Can you give a specific
\r
78 > sequence of events and conditions that leads to and demonstrates the
\r
81 > (I ask not just for commit posterity, but because I actually don't
\r
82 > know, though I may have figured it out after writing the comment
\r
85 Hey, Austin. Here's an example of a mail that is effected the issue:
\r
87 =E2=94=94=E2=94=AC=E2=95=B4multipart/alternative 896783 bytes
\r
88 =E2=94=9C=E2=94=80=E2=95=B4text/plain 379 bytes
\r
89 =E2=94=94=E2=94=AC=E2=95=B4multipart/related 892556 bytes
\r
90 =E2=94=9C=E2=94=80=E2=95=B4text/html 1236 bytes
\r
91 =E2=94=94=E2=94=80=E2=95=B4image/jpeg inline [photo.JPG] 890841 bytes
\r
93 The multipart/related part is initially hidden. Without Istvan's patch,
\r
94 there would be no button at all for the image/jpeg part, even when the
\r
95 multipart/related is exposed. With Istvan's patch the image/jpeg button
\r
96 is there, but without Mark's patch the button would actually reference
\r
97 the entire multipart/alternative part, instead of just the image/jpeg.
\r
98 If I tried to save the image/jpeg I would get the entire
\r
99 multipart/alternative mime structure in plain text.
\r
104 Content-Type: application/pgp-signature
\r
106 -----BEGIN PGP SIGNATURE-----
\r
107 Version: GnuPG v1.4.14 (GNU/Linux)
\r
109 iQIcBAEBCAAGBQJSJ1bQAAoJEO00zqvie6q8DRQQALfbe4fmzvB+HZYcet9h0kNX
\r
110 oqdnEH2ePCDl61BdRc22IvbeQK3IyGmzn6ICI57p5crgEQUOJtmY4Bw3zE2UWIIn
\r
111 cxlY5OXfnY2nojlNE1x58WbufXsxcJ8xlxzhnjJvX6F13jYv+0puXlH1pOwglqWi
\r
112 c+FMonWdTJSGvL6PxZJum+uVQI/8Z6GMZ+jeIDRDyw/R5JRfqFyYsEnx3YQub340
\r
113 w7KKzG7kHhYz3BFWcVj1aJ3zGKNYAzLHn7rPIU+3snmGTHdWkp433RakBZdF5Qfy
\r
114 z0Zwk6EkSPQSFsPpqBus7vKZ1MKgA6qHg+Kals6a3X5nsMmFVxPfdukkGMMU7Oj3
\r
115 KNIZyi1HoHKWkTtkx3xlCbj0slcX+/ViS0SK9N5wNEsgTR3iXJjc8zOcTksqn2db
\r
116 aSc6cBAYLhybNGrSKHJmWBu2EJmh02alwEbvgbIyPTV7lD5gK1j3TjBNy674Mp9U
\r
117 EIQ9U6LtzOyErtvIVpLxO8p6Ai6ieVDv9IUCGEbKAbPUH2Ml8666MrIn7tmRWeuE
\r
118 IwG0CMySDTQq9Wrou5fhyGdPpWyYk70wVhmOcl3W0oopoKVm5Remnb3G340eBSDe
\r
119 PMkzet743gzcw78R8/18s1gkvM4DE2exvQOaCVYqIOJRNIH0UyJ3zomJKlcE6UeP
\r
120 JA2Y46V+tlY4jiHMKjil
\r
122 -----END PGP SIGNATURE-----
\r