1 Return-Path: <david@tethera.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 18C1B431FC3
\r
6 for <notmuch@notmuchmail.org>; Tue, 15 Jul 2014 16:29:32 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id kMYN-QCyN6+2 for <notmuch@notmuchmail.org>;
\r
16 Tue, 15 Jul 2014 16:29:25 -0700 (PDT)
\r
17 Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])
\r
18 (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 626F1431FC0
\r
21 for <notmuch@notmuchmail.org>; Tue, 15 Jul 2014 16:29:25 -0700 (PDT)
\r
22 Received: from remotemail by yantan.tethera.net with local (Exim 4.80)
\r
23 (envelope-from <david@tethera.net>)
\r
24 id 1X7CA0-0003HR-Ol; Tue, 15 Jul 2014 20:29:24 -0300
\r
25 Received: (nullmailer pid 20872 invoked by uid 1000); Tue, 15 Jul 2014
\r
27 From: David Bremner <david@tethera.net>
\r
28 To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
\r
29 Subject: Re: [PATCH] emacs: tree/show remove duplicate function
\r
30 In-Reply-To: <87zjgbw0t5.fsf@qmul.ac.uk>
\r
31 References: <1402134668-18587-1-git-send-email-markwalters1009@gmail.com>
\r
32 <87a98bbfab.fsf@maritornes.cs.unb.ca> <87zjgbw0t5.fsf@qmul.ac.uk>
\r
33 User-Agent: Notmuch/0.18.1+39~g64ba418 (http://notmuchmail.org) Emacs/24.3.1
\r
34 (x86_64-pc-linux-gnu)
\r
35 Date: Tue, 15 Jul 2014 20:29:21 -0300
\r
36 Message-ID: <87d2d69p66.fsf@maritornes.cs.unb.ca>
\r
38 Content-Type: text/plain
\r
39 X-BeenThere: notmuch@notmuchmail.org
\r
40 X-Mailman-Version: 2.1.13
\r
42 List-Id: "Use and development of the notmuch mail system."
\r
43 <notmuch.notmuchmail.org>
\r
44 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
45 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
46 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
47 List-Post: <mailto:notmuch@notmuchmail.org>
\r
48 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
49 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
50 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
51 X-List-Received-Date: Tue, 15 Jul 2014 23:29:32 -0000
\r
53 Mark Walters <markwalters1009@gmail.com> writes:
\r
55 > On Tue, 15 Jul 2014, David Bremner <david@tethera.net> wrote:
\r
56 >> Mark Walters <markwalters1009@gmail.com> writes:
\r
57 >>> + (cond ((eq major-mode 'notmuch-show-mode)
\r
58 >>> + (notmuch-show-get-message-properties))
\r
59 >>> + ((eq major-mode 'notmuch-tree-mode)
\r
60 >>> + (notmuch-tree-get-message-properties))))
\r
62 >> I see this already existed, but it looks weird to me to have a two test
\r
63 >> cond with no else. Is it intentional to have the code drop through and
\r
64 >> do nothing if neither case matches? It seems like it might be better to
\r
67 > I can definitely do that. But as a comparison
\r
68 > notmuch-search-get-result and notmuch-search-find-thread-id "work" in
\r
69 > any buffer in the sense of returning nil but not complaining so perhaps
\r
70 > the current version is more consistent.
\r
73 It occurs to me that we can fix all 3 places in a followup patch,
\r
74 so I'll push this for now.
\r