1 Return-Path: <bremner@unb.ca>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 9FE42431FAF
\r
6 for <notmuch@notmuchmail.org>; Mon, 26 Mar 2012 11:43:39 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0.485 tagged_above=-999 required=5
\r
12 tests=[DATE_IN_PAST_24_48=0.485] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id NJSvXod0gAbc for <notmuch@notmuchmail.org>;
\r
16 Mon, 26 Mar 2012 11:43:39 -0700 (PDT)
\r
17 Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])
\r
18 (using TLSv1 with cipher AES256-SHA (256/256 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 06A1A431FAE
\r
21 for <notmuch@notmuchmail.org>; Mon, 26 Mar 2012 11:43:38 -0700 (PDT)
\r
22 Received: from tesseract.cs.unb.ca ([131.202.240.238]
\r
23 helo=rocinante.cs.unb.ca) by tesseract.cs.unb.ca with esmtpsa
\r
24 (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.72) (envelope-from <bremner@unb.ca>)
\r
25 id 1SCEtE-0008R8-8o; Mon, 26 Mar 2012 15:43:37 -0300
\r
26 Received: from bremner by rocinante.cs.unb.ca with local (Exim 4.77)
\r
27 (envelope-from <bremner@unb.ca>)
\r
28 id 1SBWAl-00058I-Hu; Sat, 24 Mar 2012 14:58:43 -0400
\r
29 From: David Bremner <david@tethera.net>
\r
30 To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
\r
31 Subject: Re: [PATCH 1/3] cli: refactor "notmuch tag" data structures for
\r
34 <992ada5cb2fa5f89d4f38b10d62f1c178b3174e2.1332604895.git.jani@nikula.org>
\r
35 References: <cover.1332604895.git.jani@nikula.org>
\r
36 <992ada5cb2fa5f89d4f38b10d62f1c178b3174e2.1332604895.git.jani@nikula.org>
\r
37 User-Agent: Notmuch/0.11.1+166~gd2ef4ed (http://notmuchmail.org) Emacs/23.3.1
\r
38 (x86_64-pc-linux-gnu)
\r
39 Date: Sat, 24 Mar 2012 14:58:43 -0400
\r
40 Message-ID: <87pqc1ygf0.fsf@rocinante.cs.unb.ca>
\r
42 Content-Type: text/plain; charset=us-ascii
\r
44 X-BeenThere: notmuch@notmuchmail.org
\r
45 X-Mailman-Version: 2.1.13
\r
47 List-Id: "Use and development of the notmuch mail system."
\r
48 <notmuch.notmuchmail.org>
\r
49 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
50 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
51 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
52 List-Post: <mailto:notmuch@notmuchmail.org>
\r
53 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
54 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
55 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
56 X-List-Received-Date: Mon, 26 Mar 2012 18:43:39 -0000
\r
58 On Sat, 24 Mar 2012 18:14:35 +0200, Jani Nikula <jani@nikula.org> wrote:
\r
59 > + if (argv[i][0] == '+' || argv[i][0] == '-') {
\r
60 > + tag_ops[tag_ops_count++] = (tag_operation_t) {
\r
61 > + .tag = argv[i] + 1,
\r
62 > + .remove = argv[i][0] == '-',
\r
65 I'm not sure if this is a worthwhile use of a C99. Wouldn't it be
\r
66 simpler to just use two assignments? and maybe increment the index
\r
67 after? Still 3 lines of code.
\r
69 Other than that, this patch looked ok to me. I think it probably
\r
70 deserves a NEWS patch that the ordering behaviour changed. I do think
\r
71 the new order is more sensible, and the old one was never documented.
\r