1 Return-Path: <dmitry.kurochkin@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 55533429E26
\r
6 for <notmuch@notmuchmail.org>; Tue, 13 Dec 2011 12:59:14 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id 9IbJxVj5mvJm for <notmuch@notmuchmail.org>;
\r
17 Tue, 13 Dec 2011 12:59:13 -0800 (PST)
\r
18 Received: from mail-ww0-f45.google.com (mail-ww0-f45.google.com
\r
19 [74.125.82.45]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client
\r
20 certificate requested) by olra.theworths.org (Postfix) with ESMTPS id
\r
21 90D66429E25 for <notmuch@notmuchmail.org>; Tue, 13 Dec 2011 12:59:13 -0800
\r
23 Received: by wgbds13 with SMTP id ds13so141126wgb.2
\r
24 for <notmuch@notmuchmail.org>; Tue, 13 Dec 2011 12:59:12 -0800 (PST)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
\r
26 h=from:to:cc:subject:in-reply-to:references:user-agent:date
\r
27 :message-id:mime-version:content-type;
\r
28 bh=iczhBpMWQqAqvrOFQtzsLcAxJEluyLirFekA9KOp8KI=;
\r
29 b=LjDXSSsloBdPo41gya4SzbtpwS3OnIYA+wjf1KBda2zImggI5ZpdgWT1q4BXo4Lfk/
\r
30 sMQ4/fgzZk6wair7B0m8bq/cacvbtu1sk9+XsqucrBtdASNbVGUKtGq75gBFo7Tt7YB8
\r
31 A6s/FxbAT5SW1fSwEOkHn82KBoEXQwHwAE00o=
\r
32 Received: by 10.227.206.78 with SMTP id ft14mr47285wbb.24.1323809952436;
\r
33 Tue, 13 Dec 2011 12:59:12 -0800 (PST)
\r
34 Received: from localhost ([91.144.186.21])
\r
35 by mx.google.com with ESMTPS id en20sm402999wid.10.2011.12.13.12.59.11
\r
36 (version=TLSv1/SSLv3 cipher=OTHER);
\r
37 Tue, 13 Dec 2011 12:59:11 -0800 (PST)
\r
38 From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
\r
39 To: Tomi Ollila <tomi.ollila@iki.fi>, David Bremner <david@tethera.net>,
\r
40 notmuch@notmuchmail.org
\r
41 Subject: Re: [PATCH] test: optionally print subtest number
\r
42 In-Reply-To: <yf61us8tcnd.fsf@taco2.nixu.fi>
\r
43 References: <1323806207-31888-1-git-send-email-david@tethera.net>
\r
44 <87ty54ut1s.fsf@gmail.com> <yf61us8tcnd.fsf@taco2.nixu.fi>
\r
45 User-Agent: Notmuch/0.10.2+96~g74e5ae5 (http://notmuchmail.org) Emacs/23.3.1
\r
46 (x86_64-pc-linux-gnu)
\r
47 Date: Wed, 14 Dec 2011 00:58:35 +0400
\r
48 Message-ID: <87pqfsur2c.fsf@gmail.com>
\r
50 Content-Type: text/plain; charset=us-ascii
\r
51 Cc: David Bremner <bremner@debian.org>
\r
52 X-BeenThere: notmuch@notmuchmail.org
\r
53 X-Mailman-Version: 2.1.13
\r
55 List-Id: "Use and development of the notmuch mail system."
\r
56 <notmuch.notmuchmail.org>
\r
57 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
58 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
59 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
60 List-Post: <mailto:notmuch@notmuchmail.org>
\r
61 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
62 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
63 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
64 X-List-Received-Date: Tue, 13 Dec 2011 20:59:14 -0000
\r
66 On Tue, 13 Dec 2011 22:55:18 +0200, Tomi Ollila <tomi.ollila@iki.fi> wrote:
\r
67 > On Wed, 14 Dec 2011 00:15:43 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
\r
68 > > On Tue, 13 Dec 2011 15:56:47 -0400, David Bremner <david@tethera.net> wrote:
\r
69 > > > From: David Bremner <bremner@debian.org>
\r
71 > > > The idea is that $test_count could be used in tests to label
\r
72 > > > intermediate files. The output enabled by this patch (and --debug)
\r
73 > > > helps figure out which OUTPUT.nn file belongs to which test in case
\r
74 > > > several subtests write to OUTPUT.$test_count
\r
77 > > > Is there something that depends on the test format? I find it pretty
\r
78 > > > handy to have the subtest numbers, but I don't want to break some
\r
79 > > > other tools. I followed the existing style of conditionally defining
\r
80 > > > functions, but maybe someone with more bash-fu can improve that.
\r
83 > > Looks good to me. Except for tabs taking too much space. Perhaps the
\r
84 > > following would be better?
\r
86 > > printf "%-4s" "[$(($test_count - 1))]"
\r
88 > I attempted the same size reduction. Therefore I know that
\r
89 > this should to be either
\r
91 > printf " %-4s" "[$(($test_count - 1))]"
\r
93 > printf "\t%-4s" "[$(($test_count - 1))]"
\r
95 > (or something similar) so that there is space betweem BROKEN and [num]
\r
98 Oh, apparently, not enough testing on my side.
\r
100 I vote for the first version with a space.
\r
105 > This takes 4 bytes out from width (and drops tab as field separator)
\r
106 > (and only few lines goes over 80 char width (some goes even with this
\r
107 > reduction). So ...
\r