1 Return-Path: <m.walters@qmul.ac.uk>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id D123B431FB6
\r
6 for <notmuch@notmuchmail.org>; Fri, 27 Jan 2012 05:30:30 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5
\r
12 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,
\r
13 NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id Il6cO8D45GSp for <notmuch@notmuchmail.org>;
\r
17 Fri, 27 Jan 2012 05:30:30 -0800 (PST)
\r
18 Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])
\r
19 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 0164C431FAE
\r
22 for <notmuch@notmuchmail.org>; Fri, 27 Jan 2012 05:30:29 -0800 (PST)
\r
23 Received: from smtp.qmul.ac.uk ([138.37.6.40])
\r
24 by mail2.qmul.ac.uk with esmtp (Exim 4.71)
\r
25 (envelope-from <m.walters@qmul.ac.uk>)
\r
26 id 1Rqlso-0006hl-0A; Fri, 27 Jan 2012 13:30:26 +0000
\r
27 Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223]
\r
29 by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69)
\r
30 (envelope-from <m.walters@qmul.ac.uk>)
\r
31 id 1Rqlsn-0003Gu-J2; Fri, 27 Jan 2012 13:30:25 +0000
\r
32 From: Mark Walters <markwalters1009@gmail.com>
\r
33 To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org
\r
34 Subject: Re: [PATCH 3/3] emacs: Prefer '[No Subject]' to blank subjects.
\r
35 In-Reply-To: <cunk44djv6f.fsf@hotblack-desiato.hh.sledj.net>
\r
36 References: <1327496913-4946-1-git-send-email-dme@dme.org>
\r
37 <1327499314-7887-1-git-send-email-dme@dme.org>
\r
38 <1327499314-7887-4-git-send-email-dme@dme.org>
\r
39 <874nvh5tro.fsf@qmul.ac.uk>
\r
40 <cunk44djv6f.fsf@hotblack-desiato.hh.sledj.net>
\r
41 User-Agent: Notmuch/0.11+107~g185f859 (http://notmuchmail.org) Emacs/23.2.1
\r
43 Date: Fri, 27 Jan 2012 13:31:27 +0000
\r
44 Message-ID: <87r4yl46hc.fsf@qmul.ac.uk>
\r
46 Content-Type: text/plain; charset=us-ascii
\r
47 X-Sender-Host-Address: 94.192.233.223
\r
48 X-QM-SPAM-Info: Sender has good ham record. :)
\r
49 X-QM-Body-MD5: aa7a845179408df79352cdac88db189d (of first 20000 bytes)
\r
50 X-SpamAssassin-Score: -1.8
\r
51 X-SpamAssassin-SpamBar: -
\r
52 X-SpamAssassin-Report: The QM spam filters have analysed this message to
\r
54 spam. We require at least 5.0 points to mark a message as spam.
\r
55 This message scored -1.8 points.
\r
56 Summary of the scoring:
\r
57 * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,
\r
59 * [138.37.6.40 listed in list.dnswl.org]
\r
60 * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
\r
61 provider * (markwalters1009[at]gmail.com)
\r
62 * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay
\r
64 * 0.5 AWL AWL: From: address is in the auto white-list
\r
65 X-QM-Scan-Virus: ClamAV says the message is clean
\r
66 X-BeenThere: notmuch@notmuchmail.org
\r
67 X-Mailman-Version: 2.1.13
\r
69 List-Id: "Use and development of the notmuch mail system."
\r
70 <notmuch.notmuchmail.org>
\r
71 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
72 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
73 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
74 List-Post: <mailto:notmuch@notmuchmail.org>
\r
75 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
76 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
77 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
78 X-List-Received-Date: Fri, 27 Jan 2012 13:30:31 -0000
\r
81 Oh one other question: I think a search result line in the emacs
\r
82 interface just has a blank if a thread has no subject. Would it be
\r
83 appropriate to change that to [No Subject] too? (I have no preference)
\r
89 On Fri, 27 Jan 2012 10:28:56 +0000, David Edmondson <dme@dme.org> wrote:
\r
90 > On Fri, 27 Jan 2012 10:23:07 +0000, Mark Walters <m.walters@qmul.ac.uk> wrote:
\r
91 > > I am very much not a lisp expert
\r
93 > Me neither, so please do continue to review stuff.
\r
95 > > The patch 1/3 seems to set the show buffer line to *[No Subject]* where
\r
96 > > it used to be just [No Subject]. (I have no preference: I just wasn't
\r
97 > > sure if that was intentional.
\r
99 > There was inconsistency before, now the buffer name always has the
\r
103 > > > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
\r
104 > > > index e6a5b31..c602b3e 100644
\r
105 > > > --- a/emacs/notmuch-show.el
\r
106 > > > +++ b/emacs/notmuch-show.el
\r
107 > > > @@ -985,7 +985,7 @@ buffer."
\r
108 > > > (notmuch-show-next-open-message))
\r
110 > > > ;; Set the header line to the subject of the first open message.
\r
111 > > > - (setq header-line-format (notmuch-show-strip-re (notmuch-show-get-subject)))
\r
112 > > > + (setq header-line-format (notmuch-show-strip-re (notmuch-show-get-pretty-subject)))
\r
114 > > > (notmuch-show-mark-read)))
\r
116 > > > @@ -1216,6 +1216,9 @@ Some useful entries are:
\r
117 > > > (defun notmuch-show-get-depth ()
\r
118 > > > (notmuch-show-get-prop :depth))
\r
120 > > > +(defun notmuch-show-get-pretty-subject ()
\r
121 > > > + (notmuch-prettify-subject (notmuch-show-get-subject)))
\r
123 > > > (defun notmuch-show-set-tags (tags)
\r
124 > > > "Set the tags of the current message."
\r
125 > > > (notmuch-show-set-prop :tags tags)
\r
127 > > As far as I can see notmuch-show-get-pretty-subject is only called once
\r
128 > > so I wondered why you bothered with a new function. But as I say I have
\r
129 > > almost zero lisp experience so no feel for lisp style.
\r
131 > Just mirroring the existing structure really.
\r
132 > `notmuch-show-get-<something>' to access details of the message. I've no
\r
133 > strong preference.
\r
projects / notmuch-archives.git / blob