a4/5feea4280ee91d8d7fd6a5389b1a06f7cb06e8

   1 Return-Path: <bgamari.foss@gmail.com>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id 00B07431FDC\r
   6         for <notmuch@notmuchmail.org>; Mon, 28 Oct 2013 15:23:38 -0700 (PDT)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.799\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5\r
  12         tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
  13         FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
  14 Received: from olra.theworths.org ([127.0.0.1])\r
  15         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  16         with ESMTP id G0D7cLuE60vJ for <notmuch@notmuchmail.org>;\r
  17         Mon, 28 Oct 2013 15:23:33 -0700 (PDT)\r
  18 Received: from mail-qe0-f51.google.com (mail-qe0-f51.google.com\r
  19         [209.85.128.51]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
  20         (No client certificate requested)\r
  21         by olra.theworths.org (Postfix) with ESMTPS id C6A4D431FDE\r
  22         for <notmuch@notmuchmail.org>; Mon, 28 Oct 2013 15:23:29 -0700 (PDT)\r
  23 Received: by mail-qe0-f51.google.com with SMTP id q19so4463318qeb.38\r
  24         for <notmuch@notmuchmail.org>; Mon, 28 Oct 2013 15:23:28 -0700 (PDT)\r
  25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;\r
  26         h=from:to:cc:subject:date:message-id:in-reply-to:references;\r
  27         bh=7X+fb0nSeZE2BNT42DDJTouunzR/OzzOAC/Lbh58NS4=;\r
  28         b=gKmpDv5qXjupPa4m5890P/kznfmPeDM3EB64rB0zAg/yefMfO8WJDHtHx4ua+WjEFt\r
  29         Wa07cOkFrtznthcyBglci0NXn+axBDHd8TsgErnz1giBkBPQLyi6DPzBfy6QbNEmgcRh\r
  30         x2vpXgKo2PLbCAyxF5ZBSi9950Li9bkf1OfTQBgczJJjwYhOQ90Wj9jmJ30lLIi5MnKE\r
  31         KoLLRX4s7i3aLWnuK+B43bUbolCakoJENNqvRKE9E/6HWdwOAeUCG5z4vSOKAboxFThT\r
  32         N8tlT3lHQsAJFguVW2s8rwTLB8yzp09W1+Y3h5fFE7pRAlPdTGbLS5MTEszGFWFiVq7r\r
  33         DEnw==\r
  34 X-Received: by 10.224.73.200 with SMTP id r8mr32972060qaj.72.1382999008229;\r
  35         Mon, 28 Oct 2013 15:23:28 -0700 (PDT)\r
  36 Received: from ben-laptop.hasb.physics.cns (physicsnat56.physics.umass.edu.\r
  37         [128.119.50.38])\r
  38         by mx.google.com with ESMTPSA id x1sm57796293qai.6.2013.10.28.15.23.27\r
  39         for <multiple recipients>\r
  40         (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);\r
  41         Mon, 28 Oct 2013 15:23:27 -0700 (PDT)\r
  42 From: Ben Gamari <bgamari.foss@gmail.com>\r
  43 To: notmuch@notmuchmail.org\r
  44 Subject: [PATCH 2/4] compact: Give user more feedback on failure renaming\r
  45 Date: Mon, 28 Oct 2013 18:23:15 -0400\r
  46 Message-Id: <1382998997-9938-2-git-send-email-bgamari.foss@gmail.com>\r
  47 X-Mailer: git-send-email 1.8.3.2\r
  48 In-Reply-To: <1382998997-9938-1-git-send-email-bgamari.foss@gmail.com>\r
  49 References: <1382998997-9938-1-git-send-email-bgamari.foss@gmail.com>\r
  50 X-BeenThere: notmuch@notmuchmail.org\r
  51 X-Mailman-Version: 2.1.13\r
  52 Precedence: list\r
  53 List-Id: "Use and development of the notmuch mail system."\r
  54         <notmuch.notmuchmail.org>\r
  55 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  56         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  57 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  58 List-Post: <mailto:notmuch@notmuchmail.org>\r
  59 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  60 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  61         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  62 X-List-Received-Date: Mon, 28 Oct 2013 22:23:38 -0000\r
  63 \r
  64 Provide the user with instructions after we fail to move the old\r
  65 un-compacted database out of the way.\r
  66 \r
  67 Signed-off-by: Ben Gamari <bgamari.foss@gmail.com>\r
  68 ---\r
  69  lib/database.cc | 9 ++++++++-\r
  70  1 file changed, 8 insertions(+), 1 deletion(-)\r
  71 \r
  72 diff --git a/lib/database.cc b/lib/database.cc\r
  73 index 06f1c0a..57c2292 100644\r
  74 --- a/lib/database.cc\r
  75 +++ b/lib/database.cc\r
  76 @@ -922,7 +922,14 @@ notmuch_database_compact (const char* path,\r
  77  \r
  78      if (old_xapian_path != NULL) {\r
  79         if (rename(xapian_path, old_xapian_path)) {\r
  80 -           fprintf (stderr, "Error moving old database out of the way\n");\r
  81 +           fprintf (stderr, "Error moving old database out of the way: %s\n",\r
  82 +                    strerror(errno));\r
  83 +           fprintf (stderr, "\n");\r
  84 +           fprintf (stderr, "Old database: %s\n", xapian_path);\r
  85 +           fprintf (stderr, "Compacted database: %s\n", compact_xapian_path);\r
  86 +           fprintf (stderr, "\n");\r
  87 +           fprintf (stderr, "At this point it's probably best to remove the compacted database,\n");\r
  88 +           fprintf (stderr, "find the cause of this error, and try compacting again.\n");\r
  89             ret = NOTMUCH_STATUS_FILE_ERROR;\r
  90             goto DONE;\r
  91         }\r
  92 -- \r
  93 1.8.3.2\r
  94 \r