1 Return-Path: <jrollins@finestructure.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 1FB58431FBC
\r
6 for <notmuch@notmuchmail.org>; Sat, 10 Mar 2012 17:19:45 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id 9k6Oc3oimzQY for <notmuch@notmuchmail.org>;
\r
16 Sat, 10 Mar 2012 17:19:43 -0800 (PST)
\r
17 Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu
\r
19 by olra.theworths.org (Postfix) with ESMTP id 006A1431FAE
\r
20 for <notmuch@notmuchmail.org>; Sat, 10 Mar 2012 17:19:42 -0800 (PST)
\r
21 Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1])
\r
22 by earth-doxen-postvirus (Postfix) with ESMTP id 1747C66E011C;
\r
23 Sat, 10 Mar 2012 17:19:40 -0800 (PST)
\r
24 X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new
\r
25 Received: from finestructure.net (cpe-76-174-137-84.socal.res.rr.com
\r
26 [76.174.137.84]) (Authenticated sender: jrollins)
\r
27 by earth-doxen-submit (Postfix) with ESMTP id 4EB6966E00F8;
\r
28 Sat, 10 Mar 2012 17:19:36 -0800 (PST)
\r
29 Received: by finestructure.net (Postfix, from userid 1000)
\r
30 id C4646506; Sat, 10 Mar 2012 17:19:35 -0800 (PST)
\r
31 From: Jameson Graef Rollins <jrollins@finestructure.net>
\r
32 To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
\r
33 Subject: Re: [PATCH 0/5] Move to --with-excluded approach to excludes
\r
34 In-Reply-To: <1330779918-28024-1-git-send-email-markwalters1009@gmail.com>
\r
35 References: <1330779918-28024-1-git-send-email-markwalters1009@gmail.com>
\r
36 User-Agent: Notmuch/0.11.1+266~gadb05cc (http://notmuchmail.org) Emacs/23.3.1
\r
37 (x86_64-pc-linux-gnu)
\r
38 Date: Sat, 10 Mar 2012 17:19:33 -0800
\r
39 Message-ID: <87399g7x3u.fsf@servo.finestructure.net>
\r
41 Content-Type: multipart/signed; boundary="=-=-=";
\r
42 micalg=pgp-sha256; protocol="application/pgp-signature"
\r
43 X-BeenThere: notmuch@notmuchmail.org
\r
44 X-Mailman-Version: 2.1.13
\r
46 List-Id: "Use and development of the notmuch mail system."
\r
47 <notmuch.notmuchmail.org>
\r
48 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
49 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
50 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
51 List-Post: <mailto:notmuch@notmuchmail.org>
\r
52 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
53 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
54 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
55 X-List-Received-Date: Sun, 11 Mar 2012 01:19:45 -0000
\r
58 Content-Transfer-Encoding: quoted-printable
\r
60 On Sat, 3 Mar 2012 13:05:13 +0000, Mark Walters <markwalters1009@gmail.com=
\r
62 > This series implements the proposal in id:"87y5riuz7v.fsf@qmul.ac.uk"
\r
63 > to move to a consistent --with-excluded approach rather than the
\r
64 > previous --no-exclude approach. See the message there and its
\r
65 > descendants for discussion.
\r
67 > The main user side change is that notmuch-search no longer defaults to
\r
68 > showing all the excluded threads with [0/n] but will do so if the user
\r
69 > says they want all the messages (i.e., by specifying --with-excluded).
\r
71 > However, it makes everything consistent throughout the commandline and
\r
72 > lib interfaces. In all cases a "message" type search only returns the
\r
73 > non-excluded matches (unless --with-excluded is specified) and a
\r
74 > "thread" type search returns all messages (including excluded ones) in
\r
75 > threads that match in a non-excluded message.
\r
77 Hi, Mark. Thanks so much for working on this. This new solution seems
\r
78 like a good one. It keeps the default as expected (excluded are
\r
79 actually excluded from all output), and the with-excluded option behaves
\r
80 intuitively. Looks good to me.
\r
82 Unfortunately, as I discussed with you on irc today, there seems to be a
\r
83 problem with the patch series that is preventing it from working as
\r
84 expected. The outputs of the following commands should agree, which
\r
87 servo:~/src/notmuch/git [master] 0$ ./notmuch count --with-excluded tag:inb=
\r
90 servo:~/src/notmuch/git [master] 0$ ./notmuch search --output=3Dmessages --=
\r
91 with-excluded tag:inbox | wc -l
\r
93 servo:~/src/notmuch/git [master] 0$=20
\r
95 However, they should also agree in this case, which they don't:
\r
97 servo:~/src/notmuch/git [master] 0$ ./notmuch count tag:inbox
\r
99 servo:~/src/notmuch/git [master] 0$ ./notmuch search --output=3Dmessages ta=
\r
102 servo:~/src/notmuch/git [master] 0$=20
\r
104 In this last case, notmuch search is outputting (some but not all(!))
\r
105 excluded messages when it shouldn't be. However, if I use a more
\r
106 complicated search term, everything seems to be working fine:
\r
108 servo:~/src/notmuch/git [master] 0$ ./notmuch count tag:inbox and tag:unread
\r
110 servo:~/src/notmuch/git [master] 0$ ./notmuch search --output=3Dmessages ta=
\r
111 g:inbox and tag:unread | wc -l
\r
113 servo:~/src/notmuch/git [master] 0$ ./notmuch count --with-excluded tag:inb=
\r
116 servo:~/src/notmuch/git [master] 0$ ./notmuch search --output=3Dmessages --=
\r
117 with-excluded tag:inbox and tag:unread | wc -l
\r
119 servo:~/src/notmuch/git [master] 0$=20
\r
121 It also works if I give a single "from:" search term instead of a single
\r
122 "tag:" search term. So it appears to be something about how the
\r
123 excluded query is constructed.
\r
125 I can't figure out where the problem is, although I'm still looking. If
\r
126 anyone else can figure it out, please let us know.
\r
128 I would really like to get this series applied so that I can get back to
\r
131 Thanks again for all the work.
\r
136 Content-Type: application/pgp-signature
\r
138 -----BEGIN PGP SIGNATURE-----
\r
139 Version: GnuPG v1.4.11 (GNU/Linux)
\r
141 iQIcBAEBCAAGBQJPW/2lAAoJEO00zqvie6q8miAP/AyFCGUrvf1l2mlDLizt9x8I
\r
142 h9q+1c6JFDuGU6x18pSgHxEuKqjuIKvz/OC0ikwTocSKRhEXuzLKYa4NXkxVPM3M
\r
143 e8jxFLc9dJ/X6QSla22ATGnd403xVLGplvWCAOgsQABbuZ4JB5b5NxlG9+vbLP3A
\r
144 NRDCS4TrYzLi0qbL+C9H268+Bb+GqANnkHDtvVnti0M3Uhdor8w+ZWebChR3/gkA
\r
145 4rUEcgPEgpBllkpQph/SXIrtEK1uKL20R2rA1CKN8EPShTrCDR1YEW0vJpXAvT6I
\r
146 +ZaNfL4Crn+D899dUhMI2visOJwn+JqmuQBca7z1guv04MsUqQOmrt+VQ3s9odUy
\r
147 rRqhh0bPEwb1euWwh5oN602AdgmFG90/21Xm2iWWq2c9jmko21OTHBodYGTSCZb5
\r
148 SDJIkmadIWUpiRm176aC0+VA2izDk4e1Th04gQ1GqjhywCus8NPTZoO9thDYyTUv
\r
149 fY3eok9ILIz+0M3S/7zUy/NSGKVMYAGizM5txfaONPQO4qn9eu6A0TWsBtO+26f/
\r
150 UKAcjMlv2+WVK8W8RhxQk188PpTAfYW3r0z1u3lSxfUegOJpcqYYfY7ul+riK1WF
\r
151 tQ0zly4VgTzBZgpNcc81ap62iUKf+Ph0CUG/rJDao31hrIGoIgonHT+Wd+0dmFcj
\r
152 Thc65LIQZZETnW8sE0MK
\r
154 -----END PGP SIGNATURE-----
\r