1 Return-Path: <Sebastian@SSpaeth.de>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id C8286418C36
\r
6 for <notmuch@notmuchmail.org>; Thu, 15 Apr 2010 23:38:57 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-1.9 tagged_above=-999 required=5
\r
12 tests=[BAYES_00=-1.9] autolearn=ham
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id JScGQ97oeoq2 for <notmuch@notmuchmail.org>;
\r
16 Thu, 15 Apr 2010 23:38:56 -0700 (PDT)
\r
17 Received: from homiemail-a20.g.dreamhost.com (caiajhbdcaib.dreamhost.com
\r
19 by olra.theworths.org (Postfix) with ESMTP id 52CA2431FC1
\r
20 for <notmuch@notmuchmail.org>; Thu, 15 Apr 2010 23:38:56 -0700 (PDT)
\r
21 Received: from localhost.localdomain (unknown [195.190.188.219])
\r
22 by homiemail-a20.g.dreamhost.com (Postfix) with ESMTPA id 0CB017EC060;
\r
23 Thu, 15 Apr 2010 23:38:54 -0700 (PDT)
\r
24 From: Sebastian Spaeth <Sebastian@SSpaeth.de>
\r
25 To: Notmuch developer list <notmuch@notmuchmail.org>
\r
26 Subject: [PATCH 3/3] notmuch-tag: don't sort messages before applying tag
\r
28 Date: Fri, 16 Apr 2010 08:38:48 +0200
\r
29 Message-Id: <1271399928-6166-3-git-send-email-Sebastian@SSpaeth.de>
\r
30 X-Mailer: git-send-email 1.7.0.4
\r
31 In-Reply-To: <87eiifj433.fsf@SSpaeth.de>
\r
32 References: <87eiifj433.fsf@SSpaeth.de>
\r
33 X-BeenThere: notmuch@notmuchmail.org
\r
34 X-Mailman-Version: 2.1.13
\r
36 List-Id: "Use and development of the notmuch mail system."
\r
37 <notmuch.notmuchmail.org>
\r
38 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
39 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
40 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
41 List-Post: <mailto:notmuch@notmuchmail.org>
\r
42 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
43 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
44 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
45 X-List-Received-Date: Fri, 16 Apr 2010 06:38:58 -0000
\r
47 It's not neccessary to sort the results before we apply tags. Xapian
\r
48 contributor Olly Betts says that savings might be bigger with a cold
\r
49 file cache and (as unsorted implies really sorted by document id) a better
\r
50 cache locality when applying tags to messages.
\r
52 Signed-off-by: Sebastian Spaeth <Sebastian@SSpaeth.de>
\r
54 notmuch-tag.c | 3 +++
\r
55 1 files changed, 3 insertions(+), 0 deletions(-)
\r
57 diff --git a/notmuch-tag.c b/notmuch-tag.c
\r
58 index 8b6f7dc..fd54bc7 100644
\r
61 @@ -107,6 +107,9 @@ notmuch_tag_command (void *ctx, unused (int argc), unused (char *argv[]))
\r
65 + /* tagging is not interested in any special sort order */
\r
66 + notmuch_query_set_sort (query, NOTMUCH_SORT_UNSORTED);
\r
68 for (messages = notmuch_query_search_messages (query);
\r
69 notmuch_messages_valid (messages) && !interrupted;
\r
70 notmuch_messages_move_to_next (messages))
\r