1 Return-Path: <dmitry.kurochkin@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id C1000431FAE
\r
6 for <notmuch@notmuchmail.org>; Fri, 3 Feb 2012 06:05:25 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id dBW5B87m7kxO for <notmuch@notmuchmail.org>;
\r
17 Fri, 3 Feb 2012 06:05:23 -0800 (PST)
\r
18 Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com
\r
19 [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 9A589431FAF
\r
22 for <notmuch@notmuchmail.org>; Fri, 3 Feb 2012 06:05:23 -0800 (PST)
\r
23 Received: by bke11 with SMTP id 11so3500552bke.26
\r
24 for <notmuch@notmuchmail.org>; Fri, 03 Feb 2012 06:05:20 -0800 (PST)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
\r
26 h=from:to:subject:in-reply-to:references:user-agent:date:message-id
\r
27 :mime-version:content-type;
\r
28 bh=15mfm5zWa44TnheeMmLKqOdZePwlX7QAHMuo7QWOa+I=;
\r
29 b=vNEjWJQQXBcuIRLnIHhELwX/Hv7njQ0WYkIZmlu8Ph+pG1Jn4O/oOdvU/qzIF45WG3
\r
30 PvxSX4A7QOPgfQftN9oV1r7jtxJbdFgvu87SF1C54Wmt1DezheG5gCJkgtH7GdMW81sD
\r
31 sBzGoU2wOIhmewZE7UadFnHsNWvyENgH2r1vw=
\r
32 Received: by 10.204.154.28 with SMTP id m28mr3517503bkw.54.1328277920819;
\r
33 Fri, 03 Feb 2012 06:05:20 -0800 (PST)
\r
34 Received: from localhost ([91.144.186.21])
\r
35 by mx.google.com with ESMTPS id e17sm13905643bkz.13.2012.02.03.06.05.19
\r
36 (version=TLSv1/SSLv3 cipher=OTHER);
\r
37 Fri, 03 Feb 2012 06:05:19 -0800 (PST)
\r
38 From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
\r
39 To: Jameson Graef Rollins <jrollins@finestructure.net>,
\r
40 notmuch@notmuchmail.org
\r
41 Subject: Re: [PATCH 1/2] test: add check for <expected> filename argument for
\r
42 test_expect_equal_file
\r
43 In-Reply-To: <87zkd1p12c.fsf@servo.finestructure.net>
\r
44 References: <1328141050-30356-1-git-send-email-dmitry.kurochkin@gmail.com>
\r
45 <1328141050-30356-2-git-send-email-dmitry.kurochkin@gmail.com>
\r
46 <87zkd1p12c.fsf@servo.finestructure.net>
\r
47 User-Agent: Notmuch/0.11+139~gd9b7cab (http://notmuchmail.org) Emacs/23.3.1
\r
48 (x86_64-pc-linux-gnu)
\r
49 Date: Fri, 03 Feb 2012 18:04:05 +0400
\r
50 Message-ID: <87sjishv3e.fsf@gmail.com>
\r
52 Content-Type: text/plain; charset=us-ascii
\r
53 X-BeenThere: notmuch@notmuchmail.org
\r
54 X-Mailman-Version: 2.1.13
\r
56 List-Id: "Use and development of the notmuch mail system."
\r
57 <notmuch.notmuchmail.org>
\r
58 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
59 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
60 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
61 List-Post: <mailto:notmuch@notmuchmail.org>
\r
62 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
63 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
64 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
65 X-List-Received-Date: Fri, 03 Feb 2012 14:05:26 -0000
\r
67 On Thu, 02 Feb 2012 10:00:59 -0800, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
\r
68 > Hey, Dmitry. I'm so sorry I sent my last email on your original patch
\r
69 > before I saw this new series. I do now like your original proposal
\r
70 > better, since it shows the diff based the names the caller provides,
\r
71 > which I now agree is probably the clearest and most robust solution.
\r
72 > The second patch in this series could still go through, though, no
\r
73 > matter what version of the change to test_expect_equal_file we go with.
\r
76 Actually, we can do both: check file name for consistent diff order
\r
77 (from expected to actual) and use file names that the caller provides.
\r