1 Return-Path: <jani@nikula.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id F1901431FBD
\r
6 for <notmuch@notmuchmail.org>; Wed, 17 Oct 2012 11:59:21 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id tF3dlUF1wrY2 for <notmuch@notmuchmail.org>;
\r
16 Wed, 17 Oct 2012 11:59:21 -0700 (PDT)
\r
17 Received: from mail-lb0-f181.google.com (mail-lb0-f181.google.com
\r
18 [209.85.217.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 5277C431FB6
\r
21 for <notmuch@notmuchmail.org>; Wed, 17 Oct 2012 11:59:21 -0700 (PDT)
\r
22 Received: by mail-lb0-f181.google.com with SMTP id gg6so5834698lbb.26
\r
23 for <notmuch@notmuchmail.org>; Wed, 17 Oct 2012 11:59:19 -0700 (PDT)
\r
24 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
\r
25 d=google.com; s=20120113;
\r
26 h=from:to:subject:in-reply-to:references:user-agent:date:message-id
\r
27 :mime-version:content-type:x-gm-message-state;
\r
28 bh=XztTrX+hvQxfXSIpdwOGFwWGruwRzFsl6JRBTe0KJ6Y=;
\r
29 b=MLz5+TN99l8htqavTr5pZqL/Al56pR5+c2qcTw6PCgttMu7e6xPZIK7hKYJLmg/2ep
\r
30 PCfD8GGhyukQcxeU2pzero7s92is4iFK1rpRVavmynuX0UqF+o90KKYPjtaWb8gQVjx0
\r
31 OaENz3Q1jAGi870loAAAidUmrXboJw8ZNyrtjTxP+BpCgzv++8WZVzW8Fh8fHafmnkKD
\r
32 GfJz8g1ZmrzHa8rdGJy7EwuY/4cvZ2iXUJjCX9lnfzuWX+74Sq8QHZj5uo76tn8CDJPN
\r
33 +tcoYCgwHDKPNXkiQs1hMHfVVvVyM+W9xCus8TT97P6i9+Nle4rRI62IhQ4vgXp7CzMz
\r
35 Received: by 10.152.124.180 with SMTP id mj20mr16578515lab.43.1350500359583;
\r
36 Wed, 17 Oct 2012 11:59:19 -0700 (PDT)
\r
37 Received: from localhost (dsl-hkibrasgw4-fe51df00-27.dhcp.inet.fi.
\r
39 by mx.google.com with ESMTPS id fe5sm4414122lbb.6.2012.10.17.11.59.17
\r
40 (version=SSLv3 cipher=OTHER); Wed, 17 Oct 2012 11:59:18 -0700 (PDT)
\r
41 From: Jani Nikula <jani@nikula.org>
\r
42 To: Ben Gamari <bgamari.foss@gmail.com>, notmuch@notmuchmail.org
\r
43 Subject: Re: [PATCH 2/3] Produce status messages during compacting
\r
44 In-Reply-To: <1350487737-32058-3-git-send-email-bgamari.foss@gmail.com>
\r
45 References: <1350487737-32058-1-git-send-email-bgamari.foss@gmail.com>
\r
46 <1350487737-32058-3-git-send-email-bgamari.foss@gmail.com>
\r
47 User-Agent: Notmuch/0.14+46~g272a1f1 (http://notmuchmail.org) Emacs/23.3.1
\r
49 Date: Wed, 17 Oct 2012 21:59:16 +0300
\r
50 Message-ID: <871ugw3oxn.fsf@nikula.org>
\r
52 Content-Type: text/plain; charset=us-ascii
\r
54 ALoCoQlS1ZlpqmLdoxxNIZw7z+p35fziKjQDgZd8d56qutNPEayb5tJ5XL58+rW22YM94l5uNSmZ
\r
55 X-BeenThere: notmuch@notmuchmail.org
\r
56 X-Mailman-Version: 2.1.13
\r
58 List-Id: "Use and development of the notmuch mail system."
\r
59 <notmuch.notmuchmail.org>
\r
60 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
61 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
62 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
63 List-Post: <mailto:notmuch@notmuchmail.org>
\r
64 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
65 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
66 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
67 X-List-Received-Date: Wed, 17 Oct 2012 18:59:22 -0000
\r
70 Again, a commit message saying *why* having a flood of status messages
\r
71 is a good idea would be appreciated. I'm not sure it is a good idea.
\r
73 On Wed, 17 Oct 2012, Ben Gamari <bgamari.foss@gmail.com> wrote:
\r
75 > lib/database.cc | 15 ++++++++++++++-
\r
76 > 1 file changed, 14 insertions(+), 1 deletion(-)
\r
78 > diff --git a/lib/database.cc b/lib/database.cc
\r
79 > index 6e83a61..49aa36d 100644
\r
80 > --- a/lib/database.cc
\r
81 > +++ b/lib/database.cc
\r
82 > @@ -780,11 +780,24 @@ notmuch_database_close (notmuch_database_t *notmuch)
\r
83 > notmuch->value_range_processor = NULL;
\r
86 > +class NotmuchCompactor : public Xapian::Compactor
\r
90 > + set_status (const std::string &table, const std::string &status)
\r
92 > + if (status.length() == 0)
\r
93 > + fprintf (stderr, "compacting table %s:\n", table.c_str());
\r
95 It's not an error, so stderr seems wrong.
\r
101 > + fprintf (stderr, " %s\n", status.c_str());
\r
106 > notmuch_database_close_compact (notmuch_database_t *notmuch)
\r
108 > void *local = talloc_new (NULL);
\r
109 > - Xapian::Compactor compactor;
\r
110 > + NotmuchCompactor compactor;
\r
111 > char *notmuch_path, *xapian_path, *compact_xapian_path, *old_xapian_path;
\r
113 > #if HAVE_XAPIAN_COMPACT
\r
117 > _______________________________________________
\r
118 > notmuch mailing list
\r
119 > notmuch@notmuchmail.org
\r
120 > http://notmuchmail.org/mailman/listinfo/notmuch
\r