1 Return-Path: <dmitry.kurochkin@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 10426431FD0
\r
6 for <notmuch@notmuchmail.org>; Wed, 20 Jul 2011 11:25:42 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id GxQLjZ6C4a1c for <notmuch@notmuchmail.org>;
\r
17 Wed, 20 Jul 2011 11:25:40 -0700 (PDT)
\r
18 Received: from mail-ew0-f53.google.com (mail-ew0-f53.google.com
\r
19 [209.85.215.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 2F7E3431FB6
\r
22 for <notmuch@notmuchmail.org>; Wed, 20 Jul 2011 11:25:40 -0700 (PDT)
\r
23 Received: by ewy8 with SMTP id 8so828320ewy.26
\r
24 for <notmuch@notmuchmail.org>; Wed, 20 Jul 2011 11:25:38 -0700 (PDT)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
\r
26 h=from:to:subject:in-reply-to:references:user-agent:date:message-id
\r
27 :mime-version:content-type;
\r
28 bh=epBxgWP1rdT/8D7IQuMxmEAL5DOwwWuyKpip6n508mE=;
\r
29 b=WKBbqeOPOukRo7pNrngBtFw3DTUbECwltNzsphagkBOwH0HFUr1Ib/A6qZT6svUKrv
\r
30 o0p41+Wfq6KACtkuL++YOFrDlt4+2LaqDhLbSCd2FalagHbUXiVMDidSKqQpgxYhwr8+
\r
31 i004ZDYrWvFZXlja+0xVNCQLSiuEGe2Y+5gWE=
\r
32 Received: by 10.14.27.200 with SMTP id e48mr3411613eea.125.1311186338624;
\r
33 Wed, 20 Jul 2011 11:25:38 -0700 (PDT)
\r
34 Received: from localhost ([91.144.186.21])
\r
35 by mx.google.com with ESMTPS id e48sm691402eeb.37.2011.07.20.11.25.36
\r
36 (version=TLSv1/SSLv3 cipher=OTHER);
\r
37 Wed, 20 Jul 2011 11:25:37 -0700 (PDT)
\r
38 From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
\r
39 To: Thomas Jost <schnouki@schnouki.net>,
\r
40 Jameson Graef Rollins <jrollins@finestructure.net>, notmuch@notmuchmail.org
\r
41 Subject: Re: [PATCH] test: run emacs inside tmux if screen is not available
\r
42 In-Reply-To: <8762mw7rdk.fsf@schnouki.net>
\r
43 References: <1309496122-4965-2-git-send-email-dmitry.kurochkin@gmail.com>
\r
44 <1311165396-12268-1-git-send-email-schnouki@schnouki.net>
\r
45 <87d3h5ul7k.fsf@gmail.com>
\r
46 <87k4bc275l.fsf@servo.factory.finestructure.net>
\r
47 <8762mw7rdk.fsf@schnouki.net>
\r
48 User-Agent: Notmuch/0.5-321-g41686e2 (http://notmuchmail.org) Emacs/23.3.1
\r
49 (x86_64-pc-linux-gnu)
\r
50 Date: Wed, 20 Jul 2011 22:25:33 +0400
\r
51 Message-ID: <874o2germq.fsf@gmail.com>
\r
53 Content-Type: text/plain; charset=us-ascii
\r
54 X-BeenThere: notmuch@notmuchmail.org
\r
55 X-Mailman-Version: 2.1.13
\r
57 List-Id: "Use and development of the notmuch mail system."
\r
58 <notmuch.notmuchmail.org>
\r
59 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
60 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
61 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
62 List-Post: <mailto:notmuch@notmuchmail.org>
\r
63 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
64 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
65 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
66 X-List-Received-Date: Wed, 20 Jul 2011 18:25:42 -0000
\r
68 On Wed, 20 Jul 2011 20:12:55 +0200, Thomas Jost <schnouki@schnouki.net> wrote:
\r
69 > On Wed, 20 Jul 2011 10:28:38 -0700, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
\r
70 > Non-text part: multipart/signed
\r
71 > > On Wed, 20 Jul 2011 17:37:35 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
\r
72 > > > On Wed, 20 Jul 2011 14:36:36 +0200, Thomas Jost <schnouki@schnouki.net> wrote:
\r
73 > > > > Before this change, the test suite reported many failed tests on machines where
\r
74 > > > > screen is not installed (which is the case of many *BSD systems). This patch
\r
75 > > > > makes the test suite try to use tmux, another terminal multiplexer, if screen is
\r
76 > > > > not available.
\r
78 > > > This is a nice improvement. But I think we should make it even better :)
\r
79 > > > There are more terminal emulators besides screen and tmux (dtach comes
\r
80 > > > to mind). We need a more general mechanism for trying them. There
\r
81 > > > should be a list of commands for running terminal emulators in the order
\r
82 > > > of preference (I think that is dtach, tmux, screen), and we should try
\r
83 > > > each one in a loop (this would also avoid repeating the long emacs
\r
86 > > Hi, guys. I suppose you can go down this route if you want, but I worry
\r
87 > > that it just adds a lot of extra code to the test suite that will
\r
88 > > ultimately make it less robust. What's wrong with just depending on
\r
89 > > screen for the tests? I'm sure screen is available on every operating
\r
90 > > system that we currently support.
\r
92 > > It makes me wary that we would be starting a precedent for making a
\r
93 > > bunch of conditionals for all of the possible alternative tools we use
\r
94 > > in the test suite. Maybe that's an overblown concern, though.
\r
98 > You're right, just depending on screen would be enough (the package is
\r
99 > just 864 kB on Arch Linux...), and supporting alternative tools
\r
100 > would make the test suite more complicated and less robust. But the
\r
101 > dependency on screen should be more *explicit*: if it's not available,
\r
102 > the test suite should skip all the emacs tests and display a message
\r
105 > Apparently test-lib.sh includes some things about prerequisites. I'll
\r
106 > try to use these to implement the explicit dependency on screen.
\r
109 Full ack. The only reason I did not implement it in the original patch
\r
110 is because there is an existing patch series [1] that adds proper
\r
111 prerequisites for gdb, emacs and gpg. So instead of reimplementing the
\r
112 same thing, I decided to wait until that series is merged and add screen
\r
113 prerequisite later.
\r
118 [1] id:"1307016220-17509-1-git-send-email-pieter@praet.org"
\r
124 Non-text part: application/pgp-signature
\r