1 Return-Path: <david@tethera.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 2CE8A431FB6
\r
6 for <notmuch@notmuchmail.org>; Sun, 18 Jan 2015 06:20:28 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=2.438 tagged_above=-999 required=5
\r
12 tests=[DNS_FROM_AHBL_RHSBL=2.438] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id fieNFDkJeVjm for <notmuch@notmuchmail.org>;
\r
16 Sun, 18 Jan 2015 06:20:25 -0800 (PST)
\r
17 Received: from mx.xen14.node3324.gplhost.com (gitolite.debian.net
\r
19 (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 4E848431FAF
\r
22 for <notmuch@notmuchmail.org>; Sun, 18 Jan 2015 06:20:25 -0800 (PST)
\r
23 Received: from remotemail by mx.xen14.node3324.gplhost.com with local (Exim
\r
24 4.80) (envelope-from <david@tethera.net>)
\r
25 id 1YCqhU-0006xZ-V1; Sun, 18 Jan 2015 14:19:36 +0000
\r
26 Received: (nullmailer pid 24147 invoked by uid 1000); Sun, 18 Jan 2015
\r
28 From: David Bremner <david@tethera.net>
\r
29 To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org
\r
30 Subject: Re: [PATCH v2 1/3] search: Separately report matching and
\r
31 non-matching authors.
\r
32 In-Reply-To: <1414172643-28270-2-git-send-email-dme@dme.org>
\r
33 References: <1414172643-28270-1-git-send-email-dme@dme.org>
\r
34 <1414172643-28270-2-git-send-email-dme@dme.org>
\r
35 User-Agent: Notmuch/0.19+27~g29ffde4 (http://notmuchmail.org) Emacs/24.4.1
\r
36 (x86_64-pc-linux-gnu)
\r
37 Date: Sun, 18 Jan 2015 15:19:23 +0100
\r
38 Message-ID: <871tms9no4.fsf@maritornes.cs.unb.ca>
\r
40 Content-Type: text/plain
\r
41 X-BeenThere: notmuch@notmuchmail.org
\r
42 X-Mailman-Version: 2.1.13
\r
44 List-Id: "Use and development of the notmuch mail system."
\r
45 <notmuch.notmuchmail.org>
\r
46 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
47 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
48 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
49 List-Post: <mailto:notmuch@notmuchmail.org>
\r
50 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
51 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
52 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
53 X-List-Received-Date: Sun, 18 Jan 2015 14:20:28 -0000
\r
55 David Edmondson <dme@dme.org> writes:
\r
57 > In addition to the 'authors' attribute of each search result, include
\r
58 > 'authors_matched' and 'authors_non_matched' attributes. Both
\r
59 > attributes are always included and are formatted as a list of
\r
60 > authors. If there are no matching authors, the 'authors_non_matched'
\r
61 > attribute is set to the empty list.
\r
64 It would be nicer if the tests were repaired in the same commit, or
\r
65 minimally marked broken.
\r
68 > do_search_threads (sprinter_t *format,
\r
69 > notmuch_query_t *query,
\r
70 > @@ -152,6 +253,10 @@ do_search_threads (sprinter_t *format,
\r
71 > format->integer (format, total);
\r
72 > format->map_key (format, "authors");
\r
73 > format->string (format, authors);
\r
74 > + if (_enumerate_authors (format, thread) < 0) {
\r
75 > + fprintf (stderr, "Out of memory\n");
\r
79 Maybe I'm just blind, but I don't see how enumerate authors ever returns
\r
80 anything other than 0.
\r