9b/f03802362fbb3c9eb52b14599cc12168ff977c

   1 Return-Path: <amdragon@mit.edu>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id 1114E431FC3\r
   6         for <notmuch@notmuchmail.org>; Fri, 24 Jan 2014 13:20:56 -0800 (PST)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.7\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
  12         tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
  13 Received: from olra.theworths.org ([127.0.0.1])\r
  14         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  15         with ESMTP id RRh+YOCULiU0 for <notmuch@notmuchmail.org>;\r
  16         Fri, 24 Jan 2014 13:20:47 -0800 (PST)\r
  17 Received: from dmz-mailsec-scanner-5.mit.edu (dmz-mailsec-scanner-5.mit.edu\r
  18         [18.7.68.34])\r
  19         by olra.theworths.org (Postfix) with ESMTP id A8007431FB6\r
  20         for <notmuch@notmuchmail.org>; Fri, 24 Jan 2014 13:20:47 -0800 (PST)\r
  21 X-AuditID: 12074422-f79526d000000c47-fc-52e2d92f4397\r
  22 Received: from mailhub-auth-1.mit.edu ( [18.9.21.35])\r
  23         (using TLS with cipher AES256-SHA (256/256 bits))\r
  24         (Client did not present a certificate)\r
  25         by dmz-mailsec-scanner-5.mit.edu (Symantec Messaging Gateway) with SMTP\r
  26         id 04.4F.03143.F29D2E25; Fri, 24 Jan 2014 16:20:47 -0500 (EST)\r
  27 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11])\r
  28         by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id s0OLKjiH004687; \r
  29         Fri, 24 Jan 2014 16:20:46 -0500\r
  30 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
  31         (authenticated bits=0)\r
  32         (User authenticated as amdragon@ATHENA.MIT.EDU)\r
  33         by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id s0OLKhv3021206\r
  34         (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT);\r
  35         Fri, 24 Jan 2014 16:20:45 -0500\r
  36 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80)\r
  37         (envelope-from <amdragon@mit.edu>)\r
  38         id 1W6oB9-0006E7-Er; Fri, 24 Jan 2014 16:20:43 -0500\r
  39 From: Austin Clements <amdragon@MIT.EDU>\r
  40 To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org\r
  41 Subject: Re: [PATCH 2/5] test: fix insert folder: searches\r
  42 In-Reply-To:\r
  43  <7eb4b4ee3345e7b166f9dd142435da32ffeffc86.1389304779.git.jani@nikula.org>\r
  44 References: <cover.1389304779.git.jani@nikula.org>\r
  45         <7eb4b4ee3345e7b166f9dd142435da32ffeffc86.1389304779.git.jani@nikula.org>\r
  46 User-Agent: Notmuch/0.17~rc2+14~g06f47e0 (http://notmuchmail.org) Emacs/23.4.1\r
  47         (i486-pc-linux-gnu)\r
  48 Date: Fri, 24 Jan 2014 16:20:43 -0500\r
  49 Message-ID: <87txctm5zo.fsf@awakening.csail.mit.edu>\r
  50 MIME-Version: 1.0\r
  51 Content-Type: text/plain; charset=us-ascii\r
  52 X-Brightmail-Tracker:\r
  53  H4sIAAAAAAAAA+NgFrrPIsWRmVeSWpSXmKPExsUixCmqrKt/81GQwYdjHBZN050trt+cyezA\r
  54         5HHr/mt2j2erbjEHMEVx2aSk5mSWpRbp2yVwZew6O5utoFmsYkHvYqYGxndCXYycHBICJhIf\r
  55         /n9gh7DFJC7cW88GYgsJzGaSOH44oIuRC8jeyAiUeMkI4Zxmklg04TUzhLOEUaL/8hOwdjYB\r
  56         DYlt+5czgtgiAlYS5x6+Zuli5OAQBrKf/iwHCXMKhEn0PZnGDLGhRuLA7gdMILaoQJLE6am/\r
  57         WUFsFgFVibnv54CN4QW6bsODj8wQtqDEyZlPWEBsZgEtiRv/XjJNYBSYhSQ1C0lqASPTKkbZ\r
  58         lNwq3dzEzJzi1GTd4uTEvLzUIl1TvdzMEr3UlNJNjKBwZHdR2sH486DSIUYBDkYlHt4ZgQ+D\r
  59         hFgTy4orcw8xSnIwKYnyTr38KEiILyk/pTIjsTgjvqg0J7X4EKMEB7OSCO/czUA53pTEyqrU\r
  60         onyYlDQHi5I47y0O+yAhgfTEktTs1NSC1CKYrAwHh5IEr/INoEbBotT01Iq0zJwShDQTByfI\r
  61         cB6g4S7XQYYXFyTmFmemQ+RPMSpKifNKgzQLgCQySvPgemHp4hWjONArwrzqIFU8wFQD1/0K\r
  62         aDAT0OAVZx+ADC5JREhJNTDyPXxtHuu7YonHjq65fIZnpCcdvXdBa33O9k0HlL0NzZVf3daP\r
  63         1NbcVnX84t6QG9s2uk99oedorb/2k/F3+dQARib1A0cWf/AzZHnx7J1Zxp3KrInMRkWupvc1\r
  64         vHV5d1yoqZ5RFLzscXqR4XZFm9P6s3g/mSl4NNUzSE/5nJFk8DBHO0V9NocSS3FGoqEWc1Fx\r
  65         IgCVNXE18gIAAA==\r
  66 X-BeenThere: notmuch@notmuchmail.org\r
  67 X-Mailman-Version: 2.1.13\r
  68 Precedence: list\r
  69 List-Id: "Use and development of the notmuch mail system."\r
  70         <notmuch.notmuchmail.org>\r
  71 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  72         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  73 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  74 List-Post: <mailto:notmuch@notmuchmail.org>\r
  75 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  76 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  77         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  78 X-List-Received-Date: Fri, 24 Jan 2014 21:20:56 -0000\r
  79 \r
  80 This is the other reason I disagree with including cur/new.  If we strip\r
  81 it, people's existing folder: searches will mostly continue to work.  If\r
  82 we include it, such saved searches, scripted searches, and post-new\r
  83 hooks are guaranteed to break.\r
  84 \r
  85 On Thu, 09 Jan 2014, Jani Nikula <jani@nikula.org> wrote:\r
  86 > folder: is now boolean prefix.\r
  87 > ---\r
  88 >  test/insert | 10 +++++-----\r
  89 >  1 file changed, 5 insertions(+), 5 deletions(-)\r
  90 >\r
  91 > diff --git a/test/insert b/test/insert\r
  92 > index e8dc4c0..4bbccd5 100755\r
  93 > --- a/test/insert\r
  94 > +++ b/test/insert\r
  95 > @@ -126,14 +126,14 @@ test_expect_equal "$dirname" "$MAIL_DIR/new"\r
  96 >  test_begin_subtest "Insert message into folder"\r
  97 >  gen_insert_msg\r
  98 >  notmuch insert --folder=Drafts < "$gen_msg_filename"\r
  99 > -output=$(notmuch search --output=files folder:Drafts)\r
 100 > +output=$(notmuch search --output=files folder:Drafts/new)\r
 101 >  dirname=$(dirname "$output")\r
 102 >  test_expect_equal "$dirname" "$MAIL_DIR/Drafts/new"\r
 103 >  \r
 104 >  test_begin_subtest "Insert message into folder, add/remove tags"\r
 105 >  gen_insert_msg\r
 106 >  notmuch insert --folder=Drafts +draft -unread < "$gen_msg_filename"\r
 107 > -output=$(notmuch search --output=messages folder:Drafts tag:draft NOT tag:unread)\r
 108 > +output=$(notmuch search --output=messages folder:Drafts/cur tag:draft NOT tag:unread)\r
 109 >  test_expect_equal "$output" "id:$gen_msg_id"\r
 110 >  \r
 111 >  gen_insert_msg\r
 112 > @@ -143,21 +143,21 @@ test_expect_code 1 "Insert message into non-existent folder" \\r
 113 >  test_begin_subtest "Insert message, create folder"\r
 114 >  gen_insert_msg\r
 115 >  notmuch insert --folder=F --create-folder +folder < "$gen_msg_filename"\r
 116 > -output=$(notmuch search --output=files folder:F tag:folder)\r
 117 > +output=$(notmuch search --output=files folder:F/new tag:folder)\r
 118 >  basename=$(basename "$output")\r
 119 >  test_expect_equal_file "$gen_msg_filename" "$MAIL_DIR/F/new/${basename}"\r
 120 >  \r
 121 >  test_begin_subtest "Insert message, create subfolder"\r
 122 >  gen_insert_msg\r
 123 >  notmuch insert --folder=F/G/H/I/J --create-folder +folder < "$gen_msg_filename"\r
 124 > -output=$(notmuch search --output=files folder:F/G/H/I/J tag:folder)\r
 125 > +output=$(notmuch search --output=files folder:F/G/H/I/J/new tag:folder)\r
 126 >  basename=$(basename "$output")\r
 127 >  test_expect_equal_file "$gen_msg_filename" "${MAIL_DIR}/F/G/H/I/J/new/${basename}"\r
 128 >  \r
 129 >  test_begin_subtest "Insert message, create existing subfolder"\r
 130 >  gen_insert_msg\r
 131 >  notmuch insert --folder=F/G/H/I/J --create-folder +folder < "$gen_msg_filename"\r
 132 > -output=$(notmuch count folder:F/G/H/I/J tag:folder)\r
 133 > +output=$(notmuch count folder:F/G/H/I/J/new tag:folder)\r
 134 >  test_expect_equal "$output" "2"\r
 135 >  \r
 136 >  gen_insert_msg\r
 137 > -- \r
 138 > 1.8.5.2\r
 139 >\r
 140 > _______________________________________________\r
 141 > notmuch mailing list\r
 142 > notmuch@notmuchmail.org\r
 143 > http://notmuchmail.org/mailman/listinfo/notmuch\r