1 Return-Path: <pieter@praet.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id F19ED429E25
\r
6 for <notmuch@notmuchmail.org>; Thu, 3 Nov 2011 09:50:46 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id S6nznZ7A8dan for <notmuch@notmuchmail.org>;
\r
16 Thu, 3 Nov 2011 09:50:46 -0700 (PDT)
\r
17 Received: from mail-ey0-f181.google.com (mail-ey0-f181.google.com
\r
18 [209.85.215.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id A5AF9431FB6
\r
21 for <notmuch@notmuchmail.org>; Thu, 3 Nov 2011 09:50:45 -0700 (PDT)
\r
22 Received: by eyx24 with SMTP id 24so1638856eyx.26
\r
23 for <notmuch@notmuchmail.org>; Thu, 03 Nov 2011 09:50:44 -0700 (PDT)
\r
24 Received: by 10.216.134.80 with SMTP id r58mr3093876wei.63.1320339043896;
\r
25 Thu, 03 Nov 2011 09:50:43 -0700 (PDT)
\r
26 Received: from localhost ([109.131.187.47])
\r
27 by mx.google.com with ESMTPS id a27sm11174070wbp.16.2011.11.03.09.50.42
\r
28 (version=TLSv1/SSLv3 cipher=OTHER);
\r
29 Thu, 03 Nov 2011 09:50:42 -0700 (PDT)
\r
30 From: Pieter Praet <pieter@praet.org>
\r
31 To: David Bremner <david@tethera.net>, Thomas Schwinge <thomas@schwinge.name>
\r
32 Subject: Re: [PATCH] Repeatability when copying a whole directory into a new
\r
34 In-Reply-To: <8739e88s4a.fsf@zancas.localnet>
\r
35 References: <1317338806-7414-1-git-send-email-thomas@schwinge.name>
\r
36 <8739e88s4a.fsf@zancas.localnet>
\r
37 User-Agent: Notmuch/0.9+33~gadde72d (http://notmuchmail.org) Emacs/23.3.1
\r
38 (x86_64-unknown-linux-gnu)
\r
39 Date: Thu, 03 Nov 2011 17:49:59 +0100
\r
40 Message-ID: <878vnxp2vc.fsf@praet.org>
\r
42 Content-Type: multipart/mixed; boundary="=-=-="
\r
43 Cc: notmuch <notmuch@notmuchmail.org>
\r
44 X-BeenThere: notmuch@notmuchmail.org
\r
45 X-Mailman-Version: 2.1.13
\r
47 List-Id: "Use and development of the notmuch mail system."
\r
48 <notmuch.notmuchmail.org>
\r
49 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
50 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
51 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
52 List-Post: <mailto:notmuch@notmuchmail.org>
\r
53 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
54 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
55 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
56 X-List-Received-Date: Thu, 03 Nov 2011 16:50:47 -0000
\r
60 On Mon, 31 Oct 2011 23:59:49 -0300, David Bremner <david@tethera.net> wrote:
\r
61 > On Fri, 30 Sep 2011 01:26:46 +0200, Thomas Schwinge <thomas@schwinge.name> wrote:
\r
62 > > This new test currently fails -- but it shouldn't.
\r
67 > > I found this while manually copying directories and running notmuch new.
\r
69 > > Am I just too sleepy at this time, or is it another DB vs. directory
\r
72 > > BROKEN Repeatability when copying a whole directory into a new one
\r
73 > > --- new.18.expected 2011-09-29 23:23:39.000000000 +0000
\r
74 > > +++ new.18.output 2011-09-29 23:23:39.000000000 +0000
\r
76 > > -Processed 51 total files in almost no time.
\r
79 > I'm a bit confused here too. When the files are removed, the "notmuch new"
\r
80 > sent to /dev/null in your test detects the deletes as renames. Shouldn't
\r
81 > the copies be detected as duplicates or something?
\r
86 Applying any one of the attached patches makes the test pass;
\r
87 I vote "directory mtime issue".
\r
92 Content-Type: text/x-patch
\r
93 Content-Disposition: inline; filename=update-dir-mtime.patch
\r
95 diff --git a/test/new b/test/new
\r
96 index 0afb04c..32b058f 100755
\r
99 @@ -168,6 +168,7 @@ notmuch new > /dev/null
\r
100 # This was quite enjoyable. Let's do it again.
\r
101 mkdir "$MAIL_DIR"/2nd
\r
102 cp -a "$MAIL_DIR"/cur "$MAIL_DIR"/2nd/
\r
103 +touch "$MAIL_DIR"/2nd/cur
\r
104 output2=$(notmuch new)
\r
106 test_subtest_known_broken
\r
109 Content-Type: text/x-patch
\r
110 Content-Disposition: inline; filename=cp-without-archive-opt.patch
\r
112 diff --git a/test/new b/test/new
\r
113 index 0afb04c..0627d69 100755
\r
116 @@ -159,7 +159,7 @@ test_begin_subtest 'Repeatability when copying a whole directory into a new one'
\r
119 mkdir "$MAIL_DIR"/2nd
\r
120 -cp -a "$MAIL_DIR"/cur "$MAIL_DIR"/2nd/
\r
121 +cp "$MAIL_DIR"/cur "$MAIL_DIR"/2nd/
\r
122 output1=$(notmuch new)
\r
124 rm -rf "$MAIL_DIR"/2nd
\r
125 @@ -167,7 +167,7 @@ notmuch new > /dev/null
\r
127 # This was quite enjoyable. Let's do it again.
\r
128 mkdir "$MAIL_DIR"/2nd
\r
129 -cp -a "$MAIL_DIR"/cur "$MAIL_DIR"/2nd/
\r
130 +cp "$MAIL_DIR"/cur "$MAIL_DIR"/2nd/
\r
131 output2=$(notmuch new)
\r
133 test_subtest_known_broken
\r
136 Content-Type: text/x-patch
\r
137 Content-Disposition: inline; filename=cp-to-other-dir.patch
\r
139 diff --git a/test/new b/test/new
\r
140 index 0afb04c..a3c270c 100755
\r
143 @@ -166,8 +166,8 @@ rm -rf "$MAIL_DIR"/2nd
\r
144 notmuch new > /dev/null
\r
146 # This was quite enjoyable. Let's do it again.
\r
147 -mkdir "$MAIL_DIR"/2nd
\r
148 -cp -a "$MAIL_DIR"/cur "$MAIL_DIR"/2nd/
\r
149 +mkdir "$MAIL_DIR"/3rd
\r
150 +cp -a "$MAIL_DIR"/cur "$MAIL_DIR"/3rd/
\r
151 output2=$(notmuch new)
\r
153 test_subtest_known_broken
\r
156 Content-Type: text/x-patch
\r
157 Content-Disposition: inline; filename=cp-dir-content.patch
\r
159 diff --git a/test/new b/test/new
\r
160 index 0afb04c..f600983 100755
\r
163 @@ -159,7 +159,7 @@ test_begin_subtest 'Repeatability when copying a whole directory into a new one'
\r
166 mkdir "$MAIL_DIR"/2nd
\r
167 -cp -a "$MAIL_DIR"/cur "$MAIL_DIR"/2nd/
\r
168 +cp -a "$MAIL_DIR"/cur/* "$MAIL_DIR"/2nd/
\r
169 output1=$(notmuch new)
\r
171 rm -rf "$MAIL_DIR"/2nd
\r
172 @@ -167,7 +167,7 @@ notmuch new > /dev/null
\r
174 # This was quite enjoyable. Let's do it again.
\r
175 mkdir "$MAIL_DIR"/2nd
\r
176 -cp -a "$MAIL_DIR"/cur "$MAIL_DIR"/2nd/
\r
177 +cp -a "$MAIL_DIR"/cur/* "$MAIL_DIR"/2nd/
\r
178 output2=$(notmuch new)
\r
180 test_subtest_known_broken
\r
187 > _______________________________________________
\r
188 > notmuch mailing list
\r
189 > notmuch@notmuchmail.org
\r
190 > http://notmuchmail.org/mailman/listinfo/notmuch
\r