1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by arlo.cworth.org (Postfix) with ESMTP id CDFB76DE141E
\r
6 for <notmuch@notmuchmail.org>; Thu, 26 Nov 2015 10:45:06 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at cworth.org
\r
11 X-Spam-Status: No, score=0.716 tagged_above=-999 required=5 tests=[AWL=0.064,
\r
12 SPF_NEUTRAL=0.652] autolearn=disabled
\r
13 Received: from arlo.cworth.org ([127.0.0.1])
\r
14 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id 77PEfveITNty for <notmuch@notmuchmail.org>;
\r
16 Thu, 26 Nov 2015 10:45:04 -0800 (PST)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by arlo.cworth.org (Postfix) with ESMTP id 1C27C6DE0C3A
\r
19 for <notmuch@notmuchmail.org>; Thu, 26 Nov 2015 10:45:03 -0800 (PST)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id 7E0421000CA;
\r
22 Thu, 26 Nov 2015 20:45:17 +0200 (EET)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: Andrew Burgess <andrew.burgess@embecosm.com>, notmuch@notmuchmail.org
\r
25 Subject: Re: [PATCH] configure: Use $prefix for emacs,
\r
26 even when pkg-config is available.
\r
27 In-Reply-To: <1448472725-11684-1-git-send-email-andrew.burgess@embecosm.com>
\r
28 References: <1448472725-11684-1-git-send-email-andrew.burgess@embecosm.com>
\r
29 User-Agent: Notmuch/0.21+32~g73439f8 (http://notmuchmail.org) Emacs/24.3.1
\r
30 (x86_64-unknown-linux-gnu)
\r
31 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
32 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
33 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
34 Date: Thu, 26 Nov 2015 20:45:17 +0200
\r
35 Message-ID: <m2oaeg4n2a.fsf@guru.guru-group.fi>
\r
37 Content-Type: text/plain
\r
38 X-BeenThere: notmuch@notmuchmail.org
\r
39 X-Mailman-Version: 2.1.20
\r
41 List-Id: "Use and development of the notmuch mail system."
\r
42 <notmuch.notmuchmail.org>
\r
43 List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
\r
44 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
45 List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
\r
46 List-Post: <mailto:notmuch@notmuchmail.org>
\r
47 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
48 List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
\r
49 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
50 X-List-Received-Date: Thu, 26 Nov 2015 18:45:06 -0000
\r
52 On Wed, Nov 25 2015, Andrew Burgess <andrew.burgess@embecosm.com> wrote:
\r
56 > I like to maintain multiple copies of notmuch installed in parallel,
\r
57 > and so make use of the --prefix=$PREFIX argument to configure.
\r
59 > I recently tried to configure and install from master, and ran into an
\r
60 > issue that the location selected for installing the emacs components
\r
61 > did not respect my chosen prefix.
\r
63 > It turns out that if pkg-config is available (it is here) then the
\r
64 > supplied prefix is ignored, in favour of the path returned by pkg-config.
\r
66 > To reproduce this issue, then as a non-root user, using current master:
\r
68 > ./configure --prefix=$HOME/notmuch-prefix
\r
72 > Assumming that you have pkg-config installed, emacs installed, and the
\r
73 > command 'pkg-config emacs --variable sitepkglispdir' returns a
\r
74 > directory that only root can write to, then the make install above
\r
77 > The solution I propose in the patch below is to still apply the
\r
78 > prefix, even when pkg-config is available; pkg-config is used to
\r
79 > select the path within the prefix directory.
\r
81 > Would you consider this for inclusion?
\r
83 perhaps that should be more complex: in case prefix is defined
\r
84 have $(prefix)/share/emacs/site-lisp in makefile regardless of
\r
85 what pkg-config --exists emacs returns...
\r
92 > When using pkg-config to select the path for the various emacs
\r
93 > installation directories (the lisp and etc directories), still apply
\r
94 > the $prefix variable.
\r
96 > configure | 4 ++--
\r
97 > 1 file changed, 2 insertions(+), 2 deletions(-)
\r
99 > diff --git a/configure b/configure
\r
100 > index 440d678..4f1db82 100755
\r
103 > @@ -473,7 +473,7 @@ fi
\r
105 > if [ -z "${EMACSLISPDIR}" ]; then
\r
106 > if pkg-config --exists emacs; then
\r
107 > - EMACSLISPDIR=$(pkg-config emacs --variable sitepkglispdir)
\r
108 > + EMACSLISPDIR='$(prefix)'$(pkg-config emacs --variable sitepkglispdir)
\r
110 > EMACSLISPDIR='$(prefix)/share/emacs/site-lisp'
\r
112 > @@ -481,7 +481,7 @@ fi
\r
114 > if [ -z "${EMACSETCDIR}" ]; then
\r
115 > if pkg-config --exists emacs; then
\r
116 > - EMACSETCDIR=$(pkg-config emacs --variable sitepkglispdir)
\r
117 > + EMACSETCDIR='$(prefix)'$(pkg-config emacs --variable sitepkglispdir)
\r
119 > EMACSETCDIR='$(prefix)/share/emacs/site-lisp'
\r
124 > _______________________________________________
\r
125 > notmuch mailing list
\r
126 > notmuch@notmuchmail.org
\r
127 > https://notmuchmail.org/mailman/listinfo/notmuch
\r