1 Return-Path: <amdragon@mit.edu>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 0C6DE431FB6
\r
6 for <notmuch@notmuchmail.org>; Mon, 20 May 2013 10:04:54 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id DNMNe6-yd7hm for <notmuch@notmuchmail.org>;
\r
16 Mon, 20 May 2013 10:04:46 -0700 (PDT)
\r
17 Received: from dmz-mailsec-scanner-2.mit.edu (DMZ-MAILSEC-SCANNER-2.MIT.EDU
\r
19 by olra.theworths.org (Postfix) with ESMTP id 44CC0431FBC
\r
20 for <notmuch@notmuchmail.org>; Mon, 20 May 2013 10:04:46 -0700 (PDT)
\r
21 X-AuditID: 1209190d-b7f716d000005557-73-519a57ab4694
\r
22 Received: from mailhub-auth-1.mit.edu ( [18.9.21.35])
\r
23 by dmz-mailsec-scanner-2.mit.edu (Symantec Messaging Gateway) with SMTP
\r
24 id A5.51.21847.BA75A915; Mon, 20 May 2013 13:04:43 -0400 (EDT)
\r
25 Received: from outgoing.mit.edu (OUTGOING-AUTH-1.MIT.EDU [18.9.28.11])
\r
26 by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id r4KH4fSM001529;
\r
27 Mon, 20 May 2013 13:04:43 -0400
\r
28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])
\r
29 (authenticated bits=0)
\r
30 (User authenticated as amdragon@ATHENA.MIT.EDU)
\r
31 by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id r4KH4d7L010407
\r
32 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT);
\r
33 Mon, 20 May 2013 13:04:40 -0400
\r
34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80)
\r
35 (envelope-from <amdragon@MIT.EDU>)
\r
36 id 1UeTVn-0007xY-85; Mon, 20 May 2013 13:04:39 -0400
\r
37 Date: Mon, 20 May 2013 13:04:39 -0400
\r
38 From: Austin Clements <amdragon@MIT.EDU>
\r
39 To: David Bremner <david@tethera.net>
\r
40 Subject: Re: [PATCH] emacs: Avoid deprecated function flet
\r
41 Message-ID: <20130520170439.GG5999@mit.edu>
\r
42 References: <87vc6fjjdp.fsf@zancas.localnet>
\r
43 <1368976447-5153-1-git-send-email-amdragon@mit.edu>
\r
44 <8761ydr6xm.fsf@zancas.localnet>
\r
46 Content-Type: text/plain; charset=us-ascii
\r
47 Content-Disposition: inline
\r
48 In-Reply-To: <8761ydr6xm.fsf@zancas.localnet>
\r
49 User-Agent: Mutt/1.5.21 (2010-09-15)
\r
50 X-Brightmail-Tracker:
\r
51 H4sIAAAAAAAAA+NgFmpmleLIzCtJLcpLzFFi42IR4hRV1l0dPivQ4P9TCYsbrd2MFtdvzmR2
\r
52 YPJ4tuoWs8eWQ++ZA5iiuGxSUnMyy1KL9O0SuDKmfNnGUnCTt2LZ3V0sDYyTuLsYOTgkBEwk
\r
53 dv826WLkBDLFJC7cW8/WxcjFISSwj1Fi0boj7BDORkaJJR8nQmVOM0k0rLoK5SxhlNh98wEb
\r
54 SD+LgKrEzst/WEBsNgENiW37lzOC2CJA8avbJoPVMAtIS3z73cwEslpYwEqis40HJMwroC1x
\r
55 fPp1ZoiZrYwS208dZIFICEqcnPmEBaJXS+LGv5dgvSBzlv/jAAlzCuhKbFy1kAnEFhVQkZhy
\r
56 chvbBEahWUi6ZyHpnoXQvYCReRWjbEpulW5uYmZOcWqybnFyYl5eapGukV5uZoleakrpJkZw
\r
57 WEvy7mB8d1DpEKMAB6MSD6+A4axAIdbEsuLK3EOMkhxMSqK8m8OAQnxJ+SmVGYnFGfFFpTmp
\r
58 xYcYJTiYlUR4o3/PDBTiTUmsrEotyodJSXOwKInzXkm56S8kkJ5YkpqdmlqQWgSTleHgUJLg
\r
59 PQIyVLAoNT21Ii0zpwQhzcTBCTKcB2j4OZAa3uKCxNzizHSI/ClGRSlx3lMgCQGQREZpHlwv
\r
60 LO28YhQHekWY9wJIFQ8wZcF1vwIazAQ0eLslyNXFJYkIKakGxuiylTJL+P65JM0NnHrunoaz
\r
61 pK7QpEWx/VpXr8n819tw77Drvfl6Zxu16l738PgIJ1SeM8jc5fI6uIObPblasXFLxHGRmy6/
\r
62 r05Nt9F+1JMx6cl2Z3Xurmd/TXter5jRxxi0o+a5Jd92TuWjTtqVJy98aNJlWsfAV1kac2SX
\r
63 6+bjh7IeJjRYKbEUZyQaajEXFScCAFPaWBMWAwAA
\r
64 Cc: notmuch@notmuchmail.org
\r
65 X-BeenThere: notmuch@notmuchmail.org
\r
66 X-Mailman-Version: 2.1.13
\r
68 List-Id: "Use and development of the notmuch mail system."
\r
69 <notmuch.notmuchmail.org>
\r
70 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
71 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
72 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
73 List-Post: <mailto:notmuch@notmuchmail.org>
\r
74 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
75 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
76 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
77 X-List-Received-Date: Mon, 20 May 2013 17:04:54 -0000
\r
79 Quoth David Bremner on May 20 at 12:45 pm:
\r
80 > Austin Clements <amdragon@MIT.EDU> writes:
\r
82 > > flet was deprecated in Emacs 24.3 and replaced with cl-flet. However,
\r
83 > > cl-flet lexically binds the function symbol, while we depend on flet
\r
84 > > dynamically binding the function symbol. Hence, this patch replaces
\r
85 > > the deprecated flet use with letf, which lets us dynamically bind the
\r
86 > > function symbol, while remaining compatible with both Emacs 23 and 24.
\r
88 > The bad news: letf is also marked as obsolete, although there is no
\r
89 > yelling from the byte-compiler yet.
\r
91 >From what I understand, all non-cl-prefixed functions are now
\r
92 considered obsolete, but the non-prefixed aliases are going to have to
\r
93 stick around for a long time and we won't be able to use the prefixed
\r
94 ones until we drop support for pre-24.3 Emacs.
\r
96 flet is a more complicated story, since it was deprecated not just in
\r
97 name, but in semantics, which I think is why the compiler singles it
\r
100 > In my simple tests, it _seemed_ to work to replace letf with cl-letf,
\r
103 > - that would require some kind of compatability alias
\r
104 > - the docstring for letf mutters something about "deprecated usage of
\r
105 > `symbol-function' in place forms.
\r
107 > On the third hand,
\r
109 > http://www.gnu.org/software/emacs/manual/html_node/elisp/Setting-Generalized-Variables.html#Setting-Generalized-Variables
\r
111 > suggests using symbol-function with setf is legitimate.
\r
113 My concern would be that letf is a cl function, and cl's documentation
\r
114 does *not* list symbol-function as a supported generalized variable:
\r
116 http://www.gnu.org/software/emacs/manual/html_mono/cl.html#Setf-Extensions
\r
118 We should probably just use fset in an unwind-protect.
\r