1 Return-Path: <bremner@tethera.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 85403431FC2
\r
6 for <notmuch@notmuchmail.org>; Sun, 16 Dec 2012 19:24:28 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id zNgScgaT-eUV for <notmuch@notmuchmail.org>;
\r
16 Sun, 16 Dec 2012 19:24:27 -0800 (PST)
\r
17 Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])
\r
18 (using TLSv1 with cipher AES256-SHA (256/256 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 3F926431FD7
\r
21 for <notmuch@notmuchmail.org>; Sun, 16 Dec 2012 19:24:26 -0800 (PST)
\r
22 Received: from fctnnbsc30w-142167090129.dhcp-dynamic.fibreop.nb.bellaliant.net
\r
23 ([142.167.90.129] helo=zancas.localnet)
\r
24 by tesseract.cs.unb.ca with esmtpsa
\r
25 (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72)
\r
26 (envelope-from <bremner@tethera.net>)
\r
27 id 1TkRJZ-0008Jj-22; Sun, 16 Dec 2012 23:24:25 -0400
\r
28 Received: from bremner by zancas.localnet with local (Exim 4.80)
\r
29 (envelope-from <bremner@tethera.net>)
\r
30 id 1TkRJT-00063M-IJ; Sun, 16 Dec 2012 23:24:19 -0400
\r
31 From: david@tethera.net
\r
32 To: notmuch@notmuchmail.org
\r
33 Subject: [PATCH 1/3] CLI: add talloc leak report,
\r
34 controlled by an environment variable.
\r
35 Date: Sun, 16 Dec 2012 23:24:05 -0400
\r
36 Message-Id: <1355714648-23144-2-git-send-email-david@tethera.net>
\r
37 X-Mailer: git-send-email 1.7.10.4
\r
38 In-Reply-To: <1355714648-23144-1-git-send-email-david@tethera.net>
\r
39 References: <1355714648-23144-1-git-send-email-david@tethera.net>
\r
41 Cc: David Bremner <bremner@debian.org>
\r
42 X-BeenThere: notmuch@notmuchmail.org
\r
43 X-Mailman-Version: 2.1.13
\r
45 List-Id: "Use and development of the notmuch mail system."
\r
46 <notmuch.notmuchmail.org>
\r
47 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
48 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
49 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
50 List-Post: <mailto:notmuch@notmuchmail.org>
\r
51 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
52 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
53 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
54 X-List-Received-Date: Mon, 17 Dec 2012 03:24:29 -0000
\r
56 From: David Bremner <bremner@debian.org>
\r
58 The argument handling in notmuch.c seems due for an overhaul, but
\r
59 until then use an environment variable to specify a location to write
\r
60 the talloc leak report to. This is only enabled for the (interesting)
\r
61 case where some notmuch subcommand is invoked.
\r
63 notmuch.c | 16 ++++++++++++++--
\r
64 1 file changed, 14 insertions(+), 2 deletions(-)
\r
66 diff --git a/notmuch.c b/notmuch.c
\r
67 index 9516dfb..fb49c5a 100644
\r
70 @@ -322,8 +322,20 @@ main (int argc, char *argv[])
\r
71 for (i = 0; i < ARRAY_SIZE (commands); i++) {
\r
72 command = &commands[i];
\r
74 - if (strcmp (argv[1], command->name) == 0)
\r
75 - return (command->function) (local, argc - 1, &argv[1]);
\r
76 + if (strcmp (argv[1], command->name) == 0) {
\r
78 + char *talloc_report;
\r
80 + ret = (command->function) (local, argc - 1, &argv[1]);
\r
82 + talloc_report=getenv ("NOTMUCH_TALLOC_REPORT");
\r
83 + if (talloc_report && strcmp(talloc_report, "") != 0) {
\r
84 + FILE *report = fopen (talloc_report, "w");
\r
85 + talloc_report_full (NULL, report);
\r
92 fprintf (stderr, "Error: Unknown command '%s' (see \"notmuch help\")\n",
\r