1 Return-Path: <amdragon@mit.edu>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id DB607431FAF
\r
6 for <notmuch@notmuchmail.org>; Sun, 15 Sep 2013 08:36:54 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id YSUuzpQwMwcF for <notmuch@notmuchmail.org>;
\r
16 Sun, 15 Sep 2013 08:36:48 -0700 (PDT)
\r
17 Received: from dmz-mailsec-scanner-3.mit.edu (dmz-mailsec-scanner-3.mit.edu
\r
19 by olra.theworths.org (Postfix) with ESMTP id 90D99431FAE
\r
20 for <notmuch@notmuchmail.org>; Sun, 15 Sep 2013 08:36:48 -0700 (PDT)
\r
21 X-AuditID: 1209190e-b7f988e0000009a7-b3-5235d40fa775
\r
22 Received: from mailhub-auth-2.mit.edu ( [18.7.62.36])
\r
23 by dmz-mailsec-scanner-3.mit.edu (Symantec Messaging Gateway) with SMTP
\r
24 id 34.88.02471.F04D5325; Sun, 15 Sep 2013 11:36:47 -0400 (EDT)
\r
25 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11])
\r
26 by mailhub-auth-2.mit.edu (8.13.8/8.9.2) with ESMTP id r8FFakQk013726;
\r
27 Sun, 15 Sep 2013 11:36:47 -0400
\r
28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])
\r
29 (authenticated bits=0)
\r
30 (User authenticated as amdragon@ATHENA.MIT.EDU)
\r
31 by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id r8FFah2x019488
\r
32 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT);
\r
33 Sun, 15 Sep 2013 11:36:45 -0400
\r
34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80)
\r
35 (envelope-from <amdragon@mit.edu>)
\r
36 id 1VLENP-000106-E0; Sun, 15 Sep 2013 11:36:43 -0400
\r
37 Date: Sun, 15 Sep 2013 11:36:42 -0400
\r
38 From: Austin Clements <amdragon@MIT.EDU>
\r
39 To: Mark Walters <markwalters1009@gmail.com>
\r
40 Subject: Re: [PATCH] contrib: pick: use global keymap
\r
41 Message-ID: <20130915153642.GY1426@mit.edu>
\r
42 References: <1379233068-9626-1-git-send-email-markwalters1009@gmail.com>
\r
44 Content-Type: text/plain; charset=us-ascii
\r
45 Content-Disposition: inline
\r
46 In-Reply-To: <1379233068-9626-1-git-send-email-markwalters1009@gmail.com>
\r
47 User-Agent: Mutt/1.5.21 (2010-09-15)
\r
48 X-Brightmail-Tracker:
\r
49 H4sIAAAAAAAAA+NgFmpileLIzCtJLcpLzFFi42IRYrdT0eW/YhpksOiPlcXquTwW12/OZHZg
\r
50 8tg56y67x7NVt5gDmKK4bFJSczLLUov07RK4Miavm8VYcFm24umkDsYGxpkSXYycHBICJhIX
\r
51 v5xih7DFJC7cW8/WxcjFISSwj1Hiyo2/UM5GRokdp5azglQJCZxmktjY5QyRWMIosf/2fxaQ
\r
52 BIuAqkTbijXMIDabgIbEtv3LGUFsEQEdiduHFoCtYBaQlvj2u5kJxBYWMJW49+0ZWA2vgLZE
\r
53 3/Nd7BALPCQ+re5jhYgLSpyc+YQFoldL4sa/l0C9HGBzlv/jAAlzCnhKTJk6G2ykqICKxJST
\r
54 29gmMArNQtI9C0n3LITuBYzMqxhlU3KrdHMTM3OKU5N1i5MT8/JSi3SN9XIzS/RSU0o3MYKC
\r
55 mlOSbwfj14NKhxgFOBiVeHhXXDAJEmJNLCuuzD3EKMnBpCTKG3zONEiILyk/pTIjsTgjvqg0
\r
56 J7X4EKMEB7OSCO8mJaAcb0piZVVqUT5MSpqDRUmcd72TfpCQQHpiSWp2ampBahFMVoaDQ0mC
\r
57 V/gyUKNgUWp6akVaZk4JQpqJgxNkOA/Q8D2XQIYXFyTmFmemQ+RPMSpKifMygzQLgCQySvPg
\r
58 emFJ5xWjONArwrwPQdp5gAkLrvsV0GAmoMGbdxuBDC5JREhJNTCKOz68dSHId9nf60IV/8J2
\r
59 3oiazv27SyRP4TGP5POpmQyO58/lfDtv2Bx54Flb97EemYei6QHpOQwHfj9dUBO3WvzCf6sb
\r
60 5VOyOzjXnLA+9+J8/sq45WmeGRUzLWT/my472b/o/Rx/EbXFd53Mv+ZMm3qJtYBZYp2BSFTv
\r
61 l71Z6/ZkJU9zkp2qxFKckWioxVxUnAgAzoD7KhUDAAA=
\r
62 Cc: notmuch@notmuchmail.org
\r
63 X-BeenThere: notmuch@notmuchmail.org
\r
64 X-Mailman-Version: 2.1.13
\r
66 List-Id: "Use and development of the notmuch mail system."
\r
67 <notmuch.notmuchmail.org>
\r
68 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
69 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
70 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
71 List-Post: <mailto:notmuch@notmuchmail.org>
\r
72 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
73 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
74 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
75 X-List-Received-Date: Sun, 15 Sep 2013 15:36:55 -0000
\r
77 Quoth Mark Walters on Sep 15 at 9:17 am:
\r
78 > Austin recently introduced a new global keymap. This makes pick use
\r
81 > In most cases pick needs to override this global map because
\r
82 > it wants to close the message pane before doing the action. However,
\r
83 > this documents the over-rides and makes it less likely that the pick
\r
84 > bindings will get out of sync with the main bindings.
\r
86 > contrib/notmuch-pick/notmuch-pick.el | 16 ++++++++++++----
\r
87 > 1 files changed, 12 insertions(+), 4 deletions(-)
\r
89 > diff --git a/contrib/notmuch-pick/notmuch-pick.el b/contrib/notmuch-pick/notmuch-pick.el
\r
90 > index cba9549..01ca4bd 100644
\r
91 > --- a/contrib/notmuch-pick/notmuch-pick.el
\r
92 > +++ b/contrib/notmuch-pick/notmuch-pick.el
\r
93 > @@ -230,6 +230,17 @@ FUNC."
\r
95 > (defvar notmuch-pick-mode-map
\r
96 > (let ((map (make-sparse-keymap)))
\r
97 > + (set-keymap-parent map notmuch-common-keymap)
\r
98 > + ;; The following override the global keymap.
\r
99 > + ;; Override because we want to close message pane first.
\r
100 > + (define-key map "?" (notmuch-pick-close-message-pane-and #'notmuch-help))
\r
102 Sorry I didn't look at this earlier.
\r
104 (define-key map [remap notmuch-help]
\r
105 (notmuch-pick-close-message-pane-and #'notmuch-help))
\r
106 ? (And the same for the others)
\r
108 That way if the user changes notmuch-common-keymap bindings in simple
\r
109 ways, pick should stay in sync. And if they change them in
\r
110 complicated ways (say, writing their own notmuch-search wrapper or
\r
111 something), pick should more or less gracefully de-sync.
\r
113 > + ;; Override because we first close message pane and then close pick buffer.
\r
114 > + (define-key map "q" 'notmuch-pick-quit)
\r
115 > + ;; Override because we close message pane after the search query is entered.
\r
116 > + (define-key map "s" 'notmuch-pick-to-search)
\r
117 > + ;; Override because we want to close message pane first.
\r
118 > + (define-key map "m" (notmuch-pick-close-message-pane-and #'notmuch-mua-new-mail))
\r
120 > (define-key map [mouse-1] 'notmuch-pick-show-message)
\r
121 > ;; these use notmuch-show functions directly
\r
122 > (define-key map "|" 'notmuch-show-pipe-message)
\r
123 > @@ -244,20 +255,16 @@ FUNC."
\r
124 > (define-key map "e" (notmuch-pick-to-message-pane #'notmuch-pick-button-activate))
\r
126 > ;; bindings from show (or elsewhere) but we close the message pane first.
\r
127 > - (define-key map "m" (notmuch-pick-close-message-pane-and #'notmuch-mua-new-mail))
\r
128 > (define-key map "f" (notmuch-pick-close-message-pane-and #'notmuch-show-forward-message))
\r
129 > (define-key map "r" (notmuch-pick-close-message-pane-and #'notmuch-show-reply-sender))
\r
130 > (define-key map "R" (notmuch-pick-close-message-pane-and #'notmuch-show-reply))
\r
131 > (define-key map "V" (notmuch-pick-close-message-pane-and #'notmuch-show-view-raw-message))
\r
132 > - (define-key map "?" (notmuch-pick-close-message-pane-and #'notmuch-help))
\r
134 > ;; The main pick bindings
\r
135 > - (define-key map "q" 'notmuch-pick-quit)
\r
136 > (define-key map "x" 'notmuch-pick-quit)
\r
137 > (define-key map "A" 'notmuch-pick-archive-thread)
\r
138 > (define-key map "a" 'notmuch-pick-archive-message-then-next)
\r
139 > (define-key map "=" 'notmuch-pick-refresh-view)
\r
140 > - (define-key map "s" 'notmuch-pick-to-search)
\r
141 > (define-key map "z" 'notmuch-pick-to-pick)
\r
142 > (define-key map "n" 'notmuch-pick-next-matching-message)
\r
143 > (define-key map "p" 'notmuch-pick-prev-matching-message)
\r
144 > @@ -849,6 +856,7 @@ Complete list of currently available key bindings:
\r
147 > (kill-all-local-variables)
\r
148 > + (setq notmuch-buffer-refresh-function #'notmuch-pick-refresh-view)
\r
149 > (use-local-map notmuch-pick-mode-map)
\r
150 > (setq major-mode 'notmuch-pick-mode
\r
151 > mode-name "notmuch-pick")
\r