1 Return-Path: <jrollins@finestructure.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 7D195431FBD
\r
6 for <notmuch@notmuchmail.org>; Wed, 8 Aug 2012 09:33:43 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id Hrvp6f5vJ2bQ for <notmuch@notmuchmail.org>;
\r
16 Wed, 8 Aug 2012 09:33:43 -0700 (PDT)
\r
17 Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu
\r
19 by olra.theworths.org (Postfix) with ESMTP id 155FA431FAE
\r
20 for <notmuch@notmuchmail.org>; Wed, 8 Aug 2012 09:33:43 -0700 (PDT)
\r
21 Received: from fire-doxen.imss.caltech.edu (localhost [127.0.0.1])
\r
22 by fire-doxen-postvirus (Postfix) with ESMTP id 78DF332801B;
\r
23 Wed, 8 Aug 2012 09:33:38 -0700 (PDT)
\r
24 X-Spam-Scanned: at Caltech-IMSS on fire-doxen by amavisd-new
\r
25 Received: from finestructure.net (unknown [76.89.192.57])
\r
26 (Authenticated sender: jrollins)
\r
27 by fire-doxen-submit (Postfix) with ESMTP id 934382E50766;
\r
28 Wed, 8 Aug 2012 09:33:33 -0700 (PDT)
\r
29 Received: by finestructure.net (Postfix, from userid 1000)
\r
30 id 127905CF; Wed, 8 Aug 2012 09:33:33 -0700 (PDT)
\r
31 From: Jameson Graef Rollins <jrollins@finestructure.net>
\r
32 To: Mark Walters <markwalters1009@gmail.com>, david@tethera.net,
\r
33 notmuch@notmuchmail.org
\r
34 Subject: Re: [PATCH 3/3] test: add broken roundtrip test
\r
35 In-Reply-To: <87zk6524f0.fsf@qmul.ac.uk>
\r
36 References: <1344190393-22497-1-git-send-email-david@tethera.net>
\r
37 <1344190393-22497-4-git-send-email-david@tethera.net>
\r
38 <87zk6524f0.fsf@qmul.ac.uk>
\r
39 User-Agent: Notmuch/0.13.2+137~ge34ed71 (http://notmuchmail.org) Emacs/23.4.1
\r
40 (x86_64-pc-linux-gnu)
\r
41 Date: Wed, 08 Aug 2012 09:33:30 -0700
\r
42 Message-ID: <87k3x9ibs5.fsf@servo.finestructure.net>
\r
44 Content-Type: multipart/signed; boundary="=-=-=";
\r
45 micalg=pgp-sha256; protocol="application/pgp-signature"
\r
46 Cc: David Bremner <bremner@debian.org>
\r
47 X-BeenThere: notmuch@notmuchmail.org
\r
48 X-Mailman-Version: 2.1.13
\r
50 List-Id: "Use and development of the notmuch mail system."
\r
51 <notmuch.notmuchmail.org>
\r
52 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
53 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
54 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
55 List-Post: <mailto:notmuch@notmuchmail.org>
\r
56 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
57 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
58 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
59 X-List-Received-Date: Wed, 08 Aug 2012 16:33:43 -0000
\r
62 Content-Transfer-Encoding: quoted-printable
\r
64 On Wed, Aug 08 2012, Mark Walters <markwalters1009@gmail.com> wrote:
\r
65 >> test/dump-restore | 9 +++++++++
\r
66 >> 1 file changed, 9 insertions(+)
\r
68 >> diff --git a/test/dump-restore b/test/dump-restore
\r
69 >> index 439e998..7979ebf 100755
\r
70 >> --- a/test/dump-restore
\r
71 >> +++ b/test/dump-restore
\r
72 >> @@ -82,4 +82,13 @@ test_begin_subtest "dump outfile -- from:cworth"
\r
73 >> notmuch dump dump-outfile-dash-inbox.actual -- from:cworth
\r
74 >> test_expect_equal_file dump-cworth.expected dump-outfile-dash-inbox.act=
\r
77 >> +test_expect_success 'roundtripping random message-ids and tags' \
\r
78 >> + 'test_subtest_known_broken &&
\r
79 >> + ${TEST_DIRECTORY}/random-corpus --config-path=3D${NOTMUCH_CONFIG} &&
\r
80 >> + notmuch dump > EXPECTED.$test_count &&
\r
81 >> + notmuch tag -random-corpus tag:random-corpus &&
\r
82 >> + notmuch restore < EXPECTED.$test_count 2>/dev/null &&
\r
83 >> + notmuch dump > OUTPUT.$test_count &&
\r
84 >> + test_cmp EXPECTED.$test_count OUTPUT.$test_count 1>/dev/null'
\r
86 > Are the single quotes at the start and end of the main block meant to be
\r
87 > there? And with them deleted this seems to pass (but there is lots of
\r
88 > diff if the redirection is removed). I am not familiar with
\r
89 > test_expect_success/test_cmp so don't know what to expect.
\r
91 I don't understand what's going on here either. This seems like a
\r
92 strange way to run these tests, as a command string to
\r
93 test_expect_success. Why not just run them directly?
\r
95 I'm also worried about the test output blowing away the users terminal.
\r
96 I think that should be avoided, even if we expect failures to be rare.
\r
101 Content-Type: application/pgp-signature
\r
103 -----BEGIN PGP SIGNATURE-----
\r
104 Version: GnuPG v1.4.12 (GNU/Linux)
\r
106 iQIcBAEBCAAGBQJQIpTaAAoJEO00zqvie6q8D/wP/iqcM+7J9Qky+8R80lRob490
\r
107 larFqaOLdL/veUtXthwOo0ceqefEJ7Sy0FJEsPvDMJiarwE+dsHUL5S5HkRrgzy4
\r
108 T5/Hqb3HJY8OfuIwNqRKdNrhOLrC2tasP3XqaPqTRAun2igfxdxjjMU/EuWkNDeL
\r
109 I9KTfH78+bptPg+jdwAnIZ5hnd9SKjmT0CQ9laTYpzFCdB0gFRBhSZ0vIZq7BvV0
\r
110 c6hytG1IpqCWT+VpRYWGrOybjyZzE/ua3uPBLoSzNmGMV5dQMKF7tYZWe4UX7Fdn
\r
111 fAgRz5J9ejihDWOzoDLjMVCK7DAPvaJ66Ti2YJFzgM55BsB87rO93ngo8c9Ik1dN
\r
112 33zoKN5OPsboQ+RlV3VC9tzicbHDk0+fqT/wblsm+wVyTWNSoKK1Rl8yphMSTkBd
\r
113 VDFcmC7nHrd8oz/uvb+5UP+1FSMBtA5FxJO2VRSVZuyLfZJZAVFr9++Lct3ebxZx
\r
114 Fj0i40+DujvTWkJYYCS/dv1sQuV+/U19XsYx9MeQ52YVnZHcLegHd/XyvvaH48mB
\r
115 LkwqVlqQ4W7FZnveqNnzXbXL517YaW9n8UqkdTztRTXeWNuoS8sUn3A3w7o7BM1f
\r
116 wb90/xb6uP2QOn2DCcM4CiiyuKFE39O8XIDCtVRtQoU0Dfies1Fjc6i+m7MtA/66
\r
117 8PxH9o2vLTFwm0CWXHZ5
\r
119 -----END PGP SIGNATURE-----
\r