1 Return-Path: <m.walters@qmul.ac.uk>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 84386431FB6
\r
6 for <notmuch@notmuchmail.org>; Wed, 4 Jul 2012 00:54:06 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5
\r
12 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,
\r
13 NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id eoqze+88bPNl for <notmuch@notmuchmail.org>;
\r
17 Wed, 4 Jul 2012 00:54:05 -0700 (PDT)
\r
18 Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])
\r
19 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id E54FC431FAE
\r
22 for <notmuch@notmuchmail.org>; Wed, 4 Jul 2012 00:54:04 -0700 (PDT)
\r
23 Received: from smtp.qmul.ac.uk ([138.37.6.40])
\r
24 by mail2.qmul.ac.uk with esmtp (Exim 4.71)
\r
25 (envelope-from <m.walters@qmul.ac.uk>)
\r
26 id 1SmKPN-0003Xf-JM; Wed, 04 Jul 2012 08:54:00 +0100
\r
27 Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223]
\r
29 by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69)
\r
30 (envelope-from <m.walters@qmul.ac.uk>)
\r
31 id 1SmKPN-0006jM-AA; Wed, 04 Jul 2012 08:53:57 +0100
\r
32 From: Mark Walters <markwalters1009@gmail.com>
\r
33 To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
\r
34 Subject: Re: [PATCH 1/8] emacs: Clean up notmuch-search-show-result
\r
35 In-Reply-To: <1341354059-29396-2-git-send-email-amdragon@mit.edu>
\r
36 References: <1341354059-29396-1-git-send-email-amdragon@mit.edu>
\r
37 <1341354059-29396-2-git-send-email-amdragon@mit.edu>
\r
38 User-Agent: Notmuch/0.13.2+70~gb6a56e7 (http://notmuchmail.org) Emacs/23.4.1
\r
39 (x86_64-pc-linux-gnu)
\r
40 Date: Wed, 04 Jul 2012 08:53:54 +0100
\r
41 Message-ID: <87lij0gdwt.fsf@qmul.ac.uk>
\r
43 Content-Type: text/plain; charset=us-ascii
\r
44 X-Sender-Host-Address: 94.192.233.223
\r
45 X-QM-SPAM-Info: Sender has good ham record. :)
\r
46 X-QM-Body-MD5: e7744b8facc79a4efc45a2d8fafea7ba (of first 20000 bytes)
\r
47 X-SpamAssassin-Score: -1.8
\r
48 X-SpamAssassin-SpamBar: -
\r
49 X-SpamAssassin-Report: The QM spam filters have analysed this message to
\r
51 spam. We require at least 5.0 points to mark a message as spam.
\r
52 This message scored -1.8 points.
\r
53 Summary of the scoring:
\r
54 * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,
\r
56 * [138.37.6.40 listed in list.dnswl.org]
\r
57 * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
\r
58 provider * (markwalters1009[at]gmail.com)
\r
59 * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay
\r
61 * 0.5 AWL AWL: From: address is in the auto white-list
\r
62 X-QM-Scan-Virus: ClamAV says the message is clean
\r
63 Cc: tomi.ollila@iki.fi
\r
64 X-BeenThere: notmuch@notmuchmail.org
\r
65 X-Mailman-Version: 2.1.13
\r
67 List-Id: "Use and development of the notmuch mail system."
\r
68 <notmuch.notmuchmail.org>
\r
69 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
70 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
71 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
72 List-Post: <mailto:notmuch@notmuchmail.org>
\r
73 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
74 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
75 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
76 X-List-Received-Date: Wed, 04 Jul 2012 07:54:06 -0000
\r
78 On Tue, 03 Jul 2012, Austin Clements <amdragon@MIT.EDU> wrote:
\r
79 > This simplifies the code and makes it no longer cubic in the number of
\r
82 This looks good to me and all tests pass, and I agree that this patch
\r
83 can be pushed independently of the later patches in the series.
\r
85 My one comment is that I, as a lisp beginner, found the use of "format"
\r
86 as a function and a variable confusing (particularly as I had not come
\r
87 across the dolist macro and that use really makes format look like a
\r
95 > emacs/notmuch.el | 20 ++++++++++----------
\r
96 > 1 file changed, 10 insertions(+), 10 deletions(-)
\r
98 > diff --git a/emacs/notmuch.el b/emacs/notmuch.el
\r
99 > index c6236db..be217a2 100644
\r
100 > --- a/emacs/notmuch.el
\r
101 > +++ b/emacs/notmuch.el
\r
102 > @@ -707,29 +707,29 @@ non-authors is found, assume that all of the authors match."
\r
103 > (overlay-put overlay 'isearch-open-invisible #'delete-overlay)))
\r
104 > (insert padding))))
\r
106 > -(defun notmuch-search-insert-field (field date count authors subject tags)
\r
107 > +(defun notmuch-search-insert-field (field format date count authors subject tags)
\r
109 > ((string-equal field "date")
\r
110 > - (insert (propertize (format (cdr (assoc field notmuch-search-result-format)) date)
\r
111 > + (insert (propertize (format format date)
\r
112 > 'face 'notmuch-search-date)))
\r
113 > ((string-equal field "count")
\r
114 > - (insert (propertize (format (cdr (assoc field notmuch-search-result-format)) count)
\r
115 > + (insert (propertize (format format count)
\r
116 > 'face 'notmuch-search-count)))
\r
117 > ((string-equal field "subject")
\r
118 > - (insert (propertize (format (cdr (assoc field notmuch-search-result-format)) subject)
\r
119 > + (insert (propertize (format format subject)
\r
120 > 'face 'notmuch-search-subject)))
\r
122 > ((string-equal field "authors")
\r
123 > - (notmuch-search-insert-authors (cdr (assoc field notmuch-search-result-format)) authors))
\r
124 > + (notmuch-search-insert-authors format authors))
\r
126 > ((string-equal field "tags")
\r
127 > - (insert (concat "(" (propertize tags 'font-lock-face 'notmuch-tag-face) ")")))))
\r
129 > + (format format (propertize tags 'font-lock-face 'notmuch-tag-face))))))
\r
131 > (defun notmuch-search-show-result (date count authors subject tags)
\r
132 > - (let ((fields) (field))
\r
133 > - (setq fields (mapcar 'car notmuch-search-result-format))
\r
134 > - (loop for field in fields
\r
135 > - do (notmuch-search-insert-field field date count authors subject tags)))
\r
136 > + (dolist (format notmuch-search-result-format)
\r
137 > + (notmuch-search-insert-field (car format) (cdr format)
\r
138 > + date count authors subject tags))
\r
141 > (defun notmuch-search-process-filter (proc string)
\r
145 > _______________________________________________
\r
146 > notmuch mailing list
\r
147 > notmuch@notmuchmail.org
\r
148 > http://notmuchmail.org/mailman/listinfo/notmuch
\r