1 Return-Path: <bremner@tethera.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 034C9429E25
\r
6 for <notmuch@notmuchmail.org>; Mon, 12 Sep 2011 19:42:59 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id 0L0GI9rolqrU for <notmuch@notmuchmail.org>;
\r
16 Mon, 12 Sep 2011 19:42:57 -0700 (PDT)
\r
17 Received: from tempo.its.unb.ca (tempo.its.unb.ca [131.202.1.21])
\r
18 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 04A17431FB6
\r
21 for <notmuch@notmuchmail.org>; Mon, 12 Sep 2011 19:42:56 -0700 (PDT)
\r
22 Received: from zancas.localnet
\r
23 (fctnnbsc36w-156034073093.pppoe-dynamic.High-Speed.nb.bellaliant.net
\r
24 [156.34.73.93]) (authenticated bits=0)
\r
25 by tempo.its.unb.ca (8.13.8/8.13.8) with ESMTP id p8D2g69W028277
\r
26 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO);
\r
27 Mon, 12 Sep 2011 23:42:09 -0300
\r
28 Received: from bremner by zancas.localnet with local (Exim 4.76)
\r
29 (envelope-from <bremner@tethera.net>)
\r
30 id 1R3Iwn-0006Bk-TK; Mon, 12 Sep 2011 23:42:05 -0300
\r
31 From: david@tethera.net
\r
32 To: notmuch@notmuchmail.org
\r
33 Subject: [PATCH] test: reset test_subtest_known_broken_ after each
\r
35 Date: Mon, 12 Sep 2011 23:41:54 -0300
\r
36 Message-Id: <1315881714-23759-1-git-send-email-david@tethera.net>
\r
37 X-Mailer: git-send-email 1.7.5.4
\r
38 In-Reply-To: <87obyqvc4s.fsf@gmail.com>
\r
39 References: <87obyqvc4s.fsf@gmail.com>
\r
40 Cc: David Bremner <bremner@debian.org>
\r
41 X-BeenThere: notmuch@notmuchmail.org
\r
42 X-Mailman-Version: 2.1.13
\r
44 List-Id: "Use and development of the notmuch mail system."
\r
45 <notmuch.notmuchmail.org>
\r
46 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
47 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
48 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
49 List-Post: <mailto:notmuch@notmuchmail.org>
\r
50 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
51 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
52 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
53 X-List-Received-Date: Tue, 13 Sep 2011 02:42:59 -0000
\r
55 From: David Bremner <bremner@debian.org>
\r
57 This means that test_subtest_known_broken needs to be called before
\r
58 every known broken subtest, which is no different than what is
\r
59 documented for the test_begin_subtest case.
\r
61 The assumption is that every test ends up calling either skipping,
\r
62 calling test_ok_ or test_failure_ and and the latter in turn delegate
\r
63 to the known_broken versions in the case where
\r
64 test_subtest_known_broken_ is set.
\r
66 test/test-lib.sh | 3 +++
\r
67 1 files changed, 3 insertions(+), 0 deletions(-)
\r
69 diff --git a/test/test-lib.sh b/test/test-lib.sh
\r
70 index 196ef49..966b2dc 100755
\r
71 --- a/test/test-lib.sh
\r
72 +++ b/test/test-lib.sh
\r
73 @@ -574,12 +574,14 @@ test_failure_message_ () {
\r
76 test_known_broken_ok_ () {
\r
77 + test_subtest_known_broken_=
\r
78 test_fixed=$(($test_fixed+1))
\r
79 say_color pass "%-6s" "FIXED"
\r
83 test_known_broken_failure_ () {
\r
84 + test_subtest_known_broken_=
\r
85 test_broken=$(($test_broken+1))
\r
86 test_failure_message_ "BROKEN" "$@"
\r
88 @@ -614,6 +616,7 @@ test_skip () {
\r
92 + test_subtest_known_broken_=
\r
93 say_color skip >&3 "skipping test: $@"
\r
94 say_color skip "%-6s" "SKIP"
\r