1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 3B2A3431FBD
\r
6 for <notmuch@notmuchmail.org>; Sat, 27 Apr 2013 02:39:19 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id X9c7nBN3Ylz3 for <notmuch@notmuchmail.org>;
\r
16 Sat, 27 Apr 2013 02:39:18 -0700 (PDT)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 9668D431FAF
\r
19 for <notmuch@notmuchmail.org>; Sat, 27 Apr 2013 02:39:18 -0700 (PDT)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id 929FA1001F0;
\r
22 Sat, 27 Apr 2013 12:39:17 +0300 (EEST)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: David Bremner <david@tethera.net>,
\r
25 Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
\r
26 Subject: Re: [PATCH 1/1] emacs: fixed (declare-function ...) definitions
\r
27 In-Reply-To: <87mwt2ve95.fsf@zancas.localnet>
\r
28 References: <1365630175-1048-1-git-send-email-tomi.ollila@iki.fi>
\r
29 <87eheekjgp.fsf@qmul.ac.uk> <87mwt2ve95.fsf@zancas.localnet>
\r
30 User-Agent: Notmuch/0.15.2+75~gd7fa7c4 (http://notmuchmail.org) Emacs/24.3.1
\r
31 (x86_64-unknown-linux-gnu)
\r
32 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
33 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
34 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
35 Date: Sat, 27 Apr 2013 12:39:17 +0300
\r
36 Message-ID: <m2ehdwz516.fsf@guru.guru-group.fi>
\r
38 Content-Type: text/plain
\r
39 X-BeenThere: notmuch@notmuchmail.org
\r
40 X-Mailman-Version: 2.1.13
\r
42 List-Id: "Use and development of the notmuch mail system."
\r
43 <notmuch.notmuchmail.org>
\r
44 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
45 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
46 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
47 List-Post: <mailto:notmuch@notmuchmail.org>
\r
48 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
49 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
50 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
51 X-List-Received-Date: Sat, 27 Apr 2013 09:39:19 -0000
\r
53 On Sat, Apr 13 2013, David Bremner <david@tethera.net> wrote:
\r
55 > Mark Walters <markwalters1009@gmail.com> writes:
\r
57 >> On Wed, 10 Apr 2013, Tomi Ollila <tomi.ollila@iki.fi> wrote:
\r
58 >>> Some (declare-function ...) definitions were drifted away from the
\r
59 >>> actual (defun ...)'s. To find the drifts and to verify changes
\r
60 >>> the following command line was used:
\r
62 >>> $ emacs --batch -L emacs --eval '(check-declare-directory "emacs")'
\r
64 >> This patch looks good to me +1.
\r
66 >> Is it worth making the above command into a test?
\r
68 I attempted to do a test -- failed miserably with test_emacs ()
\r
70 > Maybe a release check?
\r
72 You want to delegate the work developers should do to yourself
\r
73 (if not fixing the things, moan about those ;)
\r
75 For the time being I drop needs-review tag.
\r