1 Return-Path: <pieter@praet.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id C0F77431FAF
\r
6 for <notmuch@notmuchmail.org>; Thu, 19 Jan 2012 14:46:28 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id HV7C4+STu+ww for <notmuch@notmuchmail.org>;
\r
16 Thu, 19 Jan 2012 14:46:28 -0800 (PST)
\r
17 Received: from mail-ww0-f45.google.com (mail-ww0-f45.google.com
\r
18 [74.125.82.45]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client
\r
19 certificate requested) by olra.theworths.org (Postfix) with ESMTPS id
\r
20 3DAC9431FAE for <notmuch@notmuchmail.org>; Thu, 19 Jan 2012 14:46:28 -0800
\r
22 Received: by wgbdt12 with SMTP id dt12so460240wgb.2
\r
23 for <notmuch@notmuchmail.org>; Thu, 19 Jan 2012 14:46:27 -0800 (PST)
\r
24 Received: by 10.180.91.201 with SMTP id cg9mr47689862wib.15.1327013187149;
\r
25 Thu, 19 Jan 2012 14:46:27 -0800 (PST)
\r
26 Received: from localhost ([109.131.97.13])
\r
27 by mx.google.com with ESMTPS id eb2sm30514269wib.0.2012.01.19.14.46.26
\r
28 (version=TLSv1/SSLv3 cipher=OTHER);
\r
29 Thu, 19 Jan 2012 14:46:26 -0800 (PST)
\r
30 From: Pieter Praet <pieter@praet.org>
\r
31 To: Mark Walters <markwalters1009@gmail.com>,
\r
32 Austin Clements <amdragon@MIT.EDU>
\r
33 Subject: Re: [PATCH v3 2/2] search: Support automatic tag exclusions
\r
34 In-Reply-To: <874nvric7c.fsf@qmul.ac.uk>
\r
35 References: <1326586654-16840-3-git-send-email-amdragon@mit.edu>
\r
36 <1327000744-25463-1-git-send-email-pieter@praet.org>
\r
37 <20120119193647.GN16740@mit.edu> <87pqef4fuk.fsf@qmul.ac.uk>
\r
38 <m24nvr4fdc.fsf@wal122.wireless-pennnet.upenn.edu>
\r
39 <87zkdjmofb.fsf@qmul.ac.uk> <20120119202839.GQ16740@mit.edu>
\r
40 <874nvric7c.fsf@qmul.ac.uk>
\r
41 User-Agent: Notmuch/0.11+99~gab86e73 (http://notmuchmail.org) Emacs/23.3.1
\r
42 (x86_64-unknown-linux-gnu)
\r
43 Date: Thu, 19 Jan 2012 23:44:36 +0100
\r
44 Message-ID: <87ty3ruxbf.fsf@praet.org>
\r
46 Content-Type: text/plain; charset=us-ascii
\r
47 Cc: Notmuch Mail <notmuch@notmuchmail.org>, Aaron Ecay <ecay@sas.upenn.edu>
\r
48 X-BeenThere: notmuch@notmuchmail.org
\r
49 X-Mailman-Version: 2.1.13
\r
51 List-Id: "Use and development of the notmuch mail system."
\r
52 <notmuch.notmuchmail.org>
\r
53 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
54 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
55 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
56 List-Post: <mailto:notmuch@notmuchmail.org>
\r
57 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
58 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
59 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
60 X-List-Received-Date: Thu, 19 Jan 2012 22:46:28 -0000
\r
62 On Thu, 19 Jan 2012 22:01:27 +0000, Mark Walters <markwalters1009@gmail.com> wrote:
\r
64 > > > I am happy with them appearing as a non matching message, but currently
\r
65 > > > they appear as a full open message. (The patch to achieve this is
\r
66 > > > trivial: essentially transpose part of Austin's patch of
\r
67 > > > notmuch-search.c into notmuch-show.c)
\r
69 > > This definitely sounds like the right thing to do. We can argue about
\r
70 > > more sophisticated UIs, but it should do this at a minimum.
\r
72 > I will post the trivial patch in a moment (trivial but I could easily
\r
73 > have done something stupid).
\r
75 > I haven't written a test yet: should it have one, [...]
\r
77 That would be preferrable, yes.
\r
79 > [...] and if so, could
\r
80 > someone point me to the appropriate place to put it?
\r
83 In "test/emacs", right after "Hiding message with visible citation in
\r
84 notmuch-show view" would be perfect IMO.
\r
86 As you can see, that test uses `test-visible-output', which should
\r
87 provide the functionality you need.
\r
projects / notmuch-archives.git / blob