90/dbe8b961d3635cbc62aa5690cf2967c6395c76

   1 Return-Path: <amdragon@mit.edu>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id B5B97429E25\r
   6         for <notmuch@notmuchmail.org>; Sun,  4 Dec 2011 11:24:55 -0800 (PST)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.7\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
  12         tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
  13 Received: from olra.theworths.org ([127.0.0.1])\r
  14         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  15         with ESMTP id vOiWpk6eLIQL for <notmuch@notmuchmail.org>;\r
  16         Sun,  4 Dec 2011 11:24:55 -0800 (PST)\r
  17 Received: from dmz-mailsec-scanner-6.mit.edu (DMZ-MAILSEC-SCANNER-6.MIT.EDU\r
  18         [18.7.68.35])\r
  19         by olra.theworths.org (Postfix) with ESMTP id 2A8F5429E21\r
  20         for <notmuch@notmuchmail.org>; Sun,  4 Dec 2011 11:24:55 -0800 (PST)\r
  21 X-AuditID: 12074423-b7f266d0000008b8-13-4edbc904ca2d\r
  22 Received: from mailhub-auth-4.mit.edu ( [18.7.62.39])\r
  23         by dmz-mailsec-scanner-6.mit.edu (Symantec Messaging Gateway) with SMTP\r
  24         id 1E.5F.02232.409CBDE4; Sun,  4 Dec 2011 14:24:52 -0500 (EST)\r
  25 Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
  26         by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id pB4JOpgL022770; \r
  27         Sun, 4 Dec 2011 14:24:51 -0500\r
  28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
  29         (authenticated bits=0)\r
  30         (User authenticated as amdragon@ATHENA.MIT.EDU)\r
  31         by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id pB4JOo5L028783\r
  32         (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
  33         Sun, 4 Dec 2011 14:24:50 -0500 (EST)\r
  34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
  35         (envelope-from <amdragon@mit.edu>)\r
  36         id 1RXHhs-00066v-CA; Sun, 04 Dec 2011 14:26:36 -0500\r
  37 Date: Sun, 4 Dec 2011 14:26:36 -0500\r
  38 From: Austin Clements <amdragon@MIT.EDU>\r
  39 To: Jani Nikula <jani@nikula.org>\r
  40 Subject: Re: [PATCH 2/4] Introduce a generic tree-like abstraction for MIME\r
  41         traversal.\r
  42 Message-ID: <20111204192635.GV16194@mit.edu>\r
  43 References: <1322446871-14986-1-git-send-email-amdragon@mit.edu>\r
  44         <1322446871-14986-3-git-send-email-amdragon@mit.edu>\r
  45         <8739d6u4ju.fsf@nikula.org>\r
  46 MIME-Version: 1.0\r
  47 Content-Type: text/plain; charset=us-ascii\r
  48 Content-Disposition: inline\r
  49 In-Reply-To: <8739d6u4ju.fsf@nikula.org>\r
  50 User-Agent: Mutt/1.5.21 (2010-09-15)\r
  51 X-Brightmail-Tracker:\r
  52  H4sIAAAAAAAAA+NgFprOKsWRmVeSWpSXmKPExsUixG6nrsty8rafweQF7Bat3Z+ZLJqmO1tc\r
  53         vzmT2YHZ42x3O6vHrfuv2T2erbrFHMAcxWWTkpqTWZZapG+XwJVxZftWxoJF7BVX7lY2MD5n\r
  54         7WLk5JAQMJE4cWwlC4QtJnHh3nq2LkYuDiGBfYwSWyZ+Y4Rw1jNKvLi0gxnCOcEksWTSN1YI\r
  55         ZwmjxJG3c5lB+lkEVCTefn/HDmKzCWhIbNu/nBHEFhFQlNh8cj+QzcHBLGAkseq7HogpLBAh\r
  56         8XRHHUgFr4COxJqXM6FGTmWUmPBtIjNEQlDi5MwnYOcxC2hJ3Pj3kglijLTE8n8cIGFOoE3P\r
  57         PreCbRIFumDKyW1sExiFZiHpnoWkexZC9wJG5lWMsim5Vbq5iZk5xanJusXJiXl5qUW6Znq5\r
  58         mSV6qSmlmxjBYe6ivIPxz0GlQ4wCHIxKPLyZJ275CbEmlhVX5h5ilORgUhLlZT1x20+ILyk/\r
  59         pTIjsTgjvqg0J7X4EKMEB7OSCG/GYqAcb0piZVVqUT5MSpqDRUmcV2ang5+QQHpiSWp2ampB\r
  60         ahFMVoaDQ0mCtxZkqGBRanpqRVpmTglCmomDE2Q4D9DwXSA1vMUFibnFmekQ+VOMuhwn7/af\r
  61         YRRiycvPS5US550MUiQAUpRRmgc3B5aeXjGKA70lzFsJUsUDTG1wk14BLWECWqLYeANkSUki\r
  62         QkqqgTFIIc5l5eQ7nAGNzf7lh46UC9cd/Gwbtun5BHbPDwml7NzLdIN/Lo5zKeb4ZR93bctf\r
  63         p5PcB3Nvu571vvm29fRr/znbPSq81PvnM2qvORXQV7HG2tB9w86dWh1z89ak3bon5+jVuj/r\r
  64         c4DB/QuptYxvUuyazGTnPbnueozxXkPAxf1H9odNOaHEUpyRaKjFXFScCABw4uZAKgMAAA==\r
  65 Cc: notmuch@notmuchmail.org, dkg@fifthhorseman.net\r
  66 X-BeenThere: notmuch@notmuchmail.org\r
  67 X-Mailman-Version: 2.1.13\r
  68 Precedence: list\r
  69 List-Id: "Use and development of the notmuch mail system."\r
  70         <notmuch.notmuchmail.org>\r
  71 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  72         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  73 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  74 List-Post: <mailto:notmuch@notmuchmail.org>\r
  75 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  76 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  77         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  78 X-List-Received-Date: Sun, 04 Dec 2011 19:24:55 -0000\r
  79 \r
  80 Thanks for the review.  A new version is on its way...\r
  81 \r
  82 Quoth Jani Nikula on Nov 29 at  9:11 pm:\r
  83 > > +    mctx->stream = g_mime_stream_file_new (mctx->file);\r
  84 > \r
  85 > AFAICT the GMimeStreamFile object owns the FILE * pointer now, and\r
  86 > closes it later. Calling fclose() on it in _mime_node_context_free()\r
  87 > would be undefined behaviour. But please don't just take my word for it.\r
  88 \r
  89 The next line tells GMime not to close the stream on its own.\r
  90 \r
  91 Though, while I believe the code is correct, I'm not sure why we can't\r
  92 just let GMime close the stream and remove our fclose.  The original\r
  93 code for this was introduced in 357aba3e (along with most of the code\r
  94 in show-message.c) with the cryptic comment that otherwise GMime would\r
  95 close stdout.  Since I'd rather not regress some bug I don't\r
  96 understand, I'll leave the code the way it is.\r
  97 \r
  98 > > +    g_mime_stream_file_set_owner (GMIME_STREAM_FILE (mctx->stream), FALSE);\r