1 Return-Path: <bgamari.foss@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id EAD83431FAF
\r
6 for <notmuch@notmuchmail.org>; Tue, 21 Aug 2012 07:49:49 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id 6rHkW5d8C4V3 for <notmuch@notmuchmail.org>;
\r
17 Tue, 21 Aug 2012 07:49:49 -0700 (PDT)
\r
18 Received: from mail-vc0-f181.google.com (mail-vc0-f181.google.com
\r
19 [209.85.220.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 41355431FAE
\r
22 for <notmuch@notmuchmail.org>; Tue, 21 Aug 2012 07:49:49 -0700 (PDT)
\r
23 Received: by vcbfl17 with SMTP id fl17so6836798vcb.26
\r
24 for <notmuch@notmuchmail.org>; Tue, 21 Aug 2012 07:49:48 -0700 (PDT)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
\r
26 h=from:to:subject:in-reply-to:references:user-agent:date:message-id
\r
27 :mime-version:content-type;
\r
28 bh=6CKf4619w2jvc/UZ2Fw9HGcbkRAtZQ/PDG36Fj2qz+k=;
\r
29 b=0ia0z0GDaf0nac5rdujX/6xZd7Rbzz3Br05wr3OxleVFMZgWd5I9WeU94c0j6oJVbm
\r
30 KjXmLSi56uCGOcXHckDgwbuX950aD5oc+IVCOZJHlLirZYsYt+co8xIQvi3ElT96y0lp
\r
31 5ClMw9NgdSfpP0dFv3tpDVmCg/ogU5S/byLhFs1PZ3xed9IrigxGmpOfh+Q6Wfz0fk/3
\r
32 tPF3gBovRrj2F2m6WHjFLgqb0djB7ypDMgRvr963F/yB0FlNy8WzFiube76b+zQsDCK5
\r
33 MR+vxotAgHWb/ALOYN+baVws39xdLmiHf6PmtjfP28CjiZMcmo8V4oxq4keYuGWnVrOd
\r
35 Received: by 10.220.148.210 with SMTP id q18mr13684647vcv.6.1345560588715;
\r
36 Tue, 21 Aug 2012 07:49:48 -0700 (PDT)
\r
37 Received: from localhost (pool-108-8-230-85.spfdma.east.verizon.net.
\r
39 by mx.google.com with ESMTPS id br15sm763977vdb.13.2012.08.21.07.49.47
\r
40 (version=TLSv1/SSLv3 cipher=OTHER);
\r
41 Tue, 21 Aug 2012 07:49:48 -0700 (PDT)
\r
42 From: Ben Gamari <bgamari.foss@gmail.com>
\r
43 To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch <notmuch@notmuchmail.org>
\r
44 Subject: Re: [PATCH 1/3] Add notmuch_database_close_compact
\r
45 In-Reply-To: <m27gssitot.fsf@guru.guru-group.fi>
\r
46 References: <1345476704-17091-1-git-send-email-bgamari.foss@gmail.com>
\r
47 <1345476704-17091-2-git-send-email-bgamari.foss@gmail.com>
\r
48 <m27gssitot.fsf@guru.guru-group.fi>
\r
49 User-Agent: Notmuch/0.13.2+137~g3dc1094 (http://notmuchmail.org) Emacs/23.3.1
\r
50 (x86_64-pc-linux-gnu)
\r
51 Date: Tue, 21 Aug 2012 10:49:47 -0400
\r
52 Message-ID: <87y5l8z4dw.fsf@gmail.com>
\r
54 Content-Type: text/plain; charset=us-ascii
\r
55 X-BeenThere: notmuch@notmuchmail.org
\r
56 X-Mailman-Version: 2.1.13
\r
58 List-Id: "Use and development of the notmuch mail system."
\r
59 <notmuch.notmuchmail.org>
\r
60 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
61 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
62 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
63 List-Post: <mailto:notmuch@notmuchmail.org>
\r
64 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
65 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
66 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
67 X-List-Received-Date: Tue, 21 Aug 2012 14:49:50 -0000
\r
69 Tomi Ollila <tomi.ollila@iki.fi> writes:
\r
71 > On Mon, Aug 20 2012, Ben Gamari <bgamari.foss@gmail.com> wrote:
\r
74 >> configure | 25 ++++++++++++++++++++++++-
\r
75 >> lib/database.cc | 54 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
\r
76 >> lib/notmuch.h | 14 ++++++++++++++
\r
77 >> 3 files changed, 92 insertions(+), 1 deletion(-)
\r
79 >> diff --git a/configure b/configure
\r
80 >> index dc0dba4..370fedd 100755
\r
83 >> @@ -270,7 +270,8 @@ printf "Checking for Xapian development files... "
\r
85 >> for xapian_config in ${XAPIAN_CONFIG}; do
\r
86 >> if ${xapian_config} --version > /dev/null 2>&1; then
\r
87 >> - printf "Yes (%s).\n" $(${xapian_config} --version | sed -e 's/.* //')
\r
88 >> + xapian_version=$(${xapian_config} --version | sed -e 's/.* //')
\r
89 >> + printf "Yes (%s).\n" ${xapian_version}
\r
91 >> xapian_cxxflags=$(${xapian_config} --cxxflags)
\r
92 >> xapian_ldflags=$(${xapian_config} --libs)
\r
93 >> @@ -282,6 +283,24 @@ if [ ${have_xapian} = "0" ]; then
\r
94 >> errors=$((errors + 1))
\r
97 >> +have_xapian_compact=0
\r
98 >> +if [ ${have_xapian} = "1" ]; then
\r
99 >> + printf "Checking for Xapian compact support... "
\r
102 >> + set -- ${xapian_version}
\r
103 >> + xapian_major_version=$1
\r
104 >> + xapian_minor_version=$2
\r
105 >> + xapian_subminor_version=$3
\r
106 >> + set -- ${old_args}
\r
108 > The part above breaks the argument vector in case there are spaces in
\r
109 > args (I though $IFS chars, but try the script), execute:
\r
111 Hmmm, I suppose so.
\r
113 > $ echo '#!/bin/bash
\r
115 > for x in "$@"; do echo $x; done; echo
\r
117 > for x in $foo; do echo $x; done; echo
\r
119 > for x in "$@"; do echo $x; done; echo
\r
122 > $ bash foo.bash a "b c" d
\r
124 > Also, after processing, IFS is not restored (to $DEFAULT_IFS)
\r
126 I assumed this would be alright since IFS is set in the next
\r
128 > an alternative is to put the code in function like the following
\r
133 > Hmm, I guess the check above is to determine whether xapian version is
\r
134 > 1.2.6 or newer, but is there xapian version 1.1.6 or 1.0.6 or 0.3.0 or so ?
\r
136 Eh? 1.2.6 is the first Xapian release to have Compactor exposed in the
\r
139 > I am not qualified to comment about compaction itself :)
\r
141 Nor am I really. I just noticed that this functionality was blocking on
\r
142 library support which is now in place. It seemed that a pretty
\r
143 straightforward thing to implement and it hasn't broken my index yet.
\r
145 > In the last patch you give copyright to Carl (which is OK). However I'd
\r
146 > debate whether it is good practise to declare Carl as author; I'd say that
\r
147 > is OK if he agrees to claim authorship to your potentially shi^H^H^Hperfect
\r
150 Yikes. That certainly wasn't intentional. I'll fix this in the next
\r
153 > There are at least a few style issues below: e.g. no space between function
\r
154 > name and opening parenthesis.
\r