1 Return-Path: <m.walters@qmul.ac.uk>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 32F98431FCB
\r
6 for <notmuch@notmuchmail.org>; Sun, 1 Sep 2013 00:02:01 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5
\r
12 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,
\r
13 NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id RtHckUTqDuci for <notmuch@notmuchmail.org>;
\r
17 Sun, 1 Sep 2013 00:01:55 -0700 (PDT)
\r
18 Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])
\r
19 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 382D640BC3E
\r
22 for <notmuch@notmuchmail.org>; Fri, 30 Aug 2013 09:49:46 -0700 (PDT)
\r
23 Received: from smtp.qmul.ac.uk ([138.37.6.40])
\r
24 by mail2.qmul.ac.uk with esmtp (Exim 4.71)
\r
25 (envelope-from <m.walters@qmul.ac.uk>)
\r
26 id 1VFRt9-0002MK-Vi; Fri, 30 Aug 2013 17:49:38 +0100
\r
27 Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)
\r
28 by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)
\r
29 (envelope-from <m.walters@qmul.ac.uk>)
\r
30 id 1VFRt9-0006Wt-KL; Fri, 30 Aug 2013 17:49:35 +0100
\r
31 From: Mark Walters <markwalters1009@gmail.com>
\r
32 To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
\r
33 Subject: Re: [PATCH v2] emacs: insert quotable parts in reply as they are
\r
34 displayed in show view
\r
35 In-Reply-To: <1377791611-29506-1-git-send-email-jani@nikula.org>
\r
36 References: <1377633044-22044-1-git-send-email-jani@nikula.org>
\r
37 <1377791611-29506-1-git-send-email-jani@nikula.org>
\r
38 User-Agent: Notmuch/0.15.2+269~g01f5508 (http://notmuchmail.org) Emacs/23.4.1
\r
39 (x86_64-pc-linux-gnu)
\r
40 Date: Fri, 30 Aug 2013 17:49:34 +0100
\r
41 Message-ID: <87ppsvp1i9.fsf@qmul.ac.uk>
\r
43 Content-Type: text/plain; charset=us-ascii
\r
44 X-Sender-Host-Address: 93.97.24.31
\r
45 X-QM-SPAM-Info: Sender has good ham record. :)
\r
46 X-QM-Body-MD5: bfa65e51f0c806a7c9e4d46826c4f6a0 (of first 20000 bytes)
\r
47 X-SpamAssassin-Score: 0.0
\r
48 X-SpamAssassin-SpamBar: /
\r
49 X-SpamAssassin-Report: The QM spam filters have analysed this message to
\r
51 spam. We require at least 5.0 points to mark a message as spam.
\r
52 This message scored 0.0 points. Summary of the scoring:
\r
53 * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
\r
54 provider * (markwalters1009[at]gmail.com)
\r
55 * 0.0 AWL AWL: From: address is in the auto white-list
\r
56 X-QM-Scan-Virus: ClamAV says the message is clean
\r
57 Cc: Tomi Ollila <tomi.ollila@iki.fi>
\r
58 X-BeenThere: notmuch@notmuchmail.org
\r
59 X-Mailman-Version: 2.1.13
\r
61 List-Id: "Use and development of the notmuch mail system."
\r
62 <notmuch.notmuchmail.org>
\r
63 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
64 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
65 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
66 List-Post: <mailto:notmuch@notmuchmail.org>
\r
67 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
68 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
69 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
70 X-List-Received-Date: Sun, 01 Sep 2013 07:02:01 -0000
\r
73 > In reply, insert quotable parts using notmuch-show-insert-bodypart
\r
74 > instead of calling notmuch-mm-display-part-inline directly to render
\r
75 > the quoted parts as they are rendered in show view.
\r
77 > The notable change is that replies to text/calendar parts quote the
\r
78 > pretty printed output of icalendar-import-buffer rather than the ugly
\r
81 I slightly worry that some text-properties or similar from notmuch-show
\r
82 could make their way into the reply buffer: in particular it would be
\r
83 very bad if any invisible character made it into the buffer. I don't
\r
84 think this is actually a problem currently but just in case (and to
\r
85 avoid future problems) how about the following on top of the parent
\r
93 emacs/notmuch-mua.el | 8 +++++---
\r
94 1 files changed, 5 insertions(+), 3 deletions(-)
\r
96 diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
\r
97 index e7cc94e..9e4a232 100644
\r
98 --- a/emacs/notmuch-mua.el
\r
99 +++ b/emacs/notmuch-mua.el
\r
100 @@ -134,9 +134,11 @@ list."
\r
101 (narrow-to-region (point-min) (point))
\r
102 ;; We don't want hooks, such as notmuch-wash-*, to be run on the
\r
104 - (let ((notmuch-show-insert-text/plain-hook nil))
\r
105 - ;; Show the part but do not add buttons.
\r
106 - (notmuch-show-insert-bodypart message part 0 'no-buttons))
\r
107 + (insert (with-temp-buffer
\r
108 + (let ((notmuch-show-insert-text/plain-hook nil))
\r
109 + ;; Show the part but do not add buttons.
\r
110 + (notmuch-show-insert-bodypart message part 0 'no-buttons))
\r
111 + (buffer-substring-no-properties (point-min) (point-max))))
\r
112 (goto-char (point-max))))
\r
114 ;; There is a bug in emacs 23's message.el that results in a newline
\r