90/23a51cc506b0f68a7235cfe7e1787e579787ec

   1 Return-Path: <bgamari.foss@gmail.com>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id DE2064196F4\r
   6         for <notmuch@notmuchmail.org>; Thu, 22 Apr 2010 15:20:39 -0700 (PDT)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -1.999\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-1.999 tagged_above=-999 required=5\r
  12         tests=[BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1,\r
  13         DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001] autolearn=ham\r
  14 Received: from olra.theworths.org ([127.0.0.1])\r
  15         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  16         with ESMTP id Dln5+rk4J6t7 for <notmuch@notmuchmail.org>;\r
  17         Thu, 22 Apr 2010 15:20:39 -0700 (PDT)\r
  18 Received: from mail-pv0-f181.google.com (mail-pv0-f181.google.com\r
  19         [74.125.83.181])\r
  20         by olra.theworths.org (Postfix) with ESMTP id 1BC5A4196F2\r
  21         for <notmuch@notmuchmail.org>; Thu, 22 Apr 2010 15:20:39 -0700 (PDT)\r
  22 Received: by pvg3 with SMTP id 3so1488936pvg.26\r
  23         for <notmuch@notmuchmail.org>; Thu, 22 Apr 2010 15:20:38 -0700 (PDT)\r
  24 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;\r
  25         h=domainkey-signature:received:received:from:to:cc:subject:date\r
  26         :message-id:x-mailer:in-reply-to:references;\r
  27         bh=31btXKdpal0D3bhBnoterT6SR+qvDZK5f/Np1JDJADY=;\r
  28         b=Jd4FaELBZ3wNCyhXrrL2PHtaoSUEzam3WPq9yFGBtY4Jvg8/mYgHduk1w2Yl0MzyHz\r
  29         Qv+uY3XhSSgU+VOfpiO9YJsnB2HuzU42lFSyL3vEKbNcao0FCciOllyY7JdDhcpA7lo/\r
  30         yJv7xgRtIvkkqJ0hvAKIXKOMOSd4QqLjpQqj0=\r
  31 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;\r
  32         h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references;\r
  33         b=MnCIdFQbRMfQvepmt6i3niWhAtKM7D0rQnr3hW578/FF5I9L++0fxrZhxUTe4Zec93\r
  34         cKOGjgONzL4UHwKqwQW0XSQACY5lxvqHtnuSpTevh6BeOk0BL0V0ic5Sf+MRiJgoZPmC\r
  35         WC3INHeLlspDKsfzfU8bngE+yq28UYTeIWVlA=\r
  36 Received: by 10.142.149.39 with SMTP id w39mr332424wfd.61.1271974838231;\r
  37         Thu, 22 Apr 2010 15:20:38 -0700 (PDT)\r
  38 Received: from localhost.localdomain (physnat56.physics.umass.edu\r
  39         [128.119.50.56])\r
  40         by mx.google.com with ESMTPS id v41sm182194wfh.21.2010.04.22.15.20.36\r
  41         (version=SSLv3 cipher=RC4-MD5); Thu, 22 Apr 2010 15:20:37 -0700 (PDT)\r
  42 From: Ben Gamari <bgamari.foss@gmail.com>\r
  43 To: notmuch <notmuch@notmuchmail.org>\r
  44 Subject: [PATCH] Fix linker error from insufficient LDFLAGS\r
  45 Date: Thu, 22 Apr 2010 18:20:27 -0400\r
  46 Message-Id: <1271974827-10978-2-git-send-email-bgamari.foss@gmail.com>\r
  47 X-Mailer: git-send-email 1.7.0.5\r
  48 In-Reply-To: <1271974827-10978-1-git-send-email-bgamari.foss@gmail.com>\r
  49 References: <1271974827-10978-1-git-send-email-bgamari.foss@gmail.com>\r
  50 X-BeenThere: notmuch@notmuchmail.org\r
  51 X-Mailman-Version: 2.1.13\r
  52 Precedence: list\r
  53 List-Id: "Use and development of the notmuch mail system."\r
  54         <notmuch.notmuchmail.org>\r
  55 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  56         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  57 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  58 List-Post: <mailto:notmuch@notmuchmail.org>\r
  59 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  60 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  61         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  62 X-List-Received-Date: Thu, 22 Apr 2010 22:20:40 -0000\r
  63 \r
  64 It seems that LDFLAGS have recently been reorganized, along with the\r
  65 introduction of a notmuch-shared rule. Unfortunately, the LDFLAGS used\r
  66 in notmuch-shared don't include CONFIGURE_LDFLAGS. This caused linking\r
  67 to fail with the following,\r
  68 \r
  69 $ make V=1\r
  70 gcc debugger.o gmime-filter-reply.o gmime-filter-headers.o notmuch.o notmuch-config.o notmuch-count.o notmuch-dump.o notmuch-new.o notmuch-reply.o notmuch-restore.o notmuch-search.o notmuch-search-tags.o notmuch-setup.o notmuch-show.o notmuch-tag.o notmuch-time.o query-string.o show-message.o json.o  -Llib -lnotmuch -o notmuch-shared\r
  71 /usr/bin/ld: gmime-filter-reply.o: undefined reference to symbol 'g_mime_filter_set_size'\r
  72 /usr/bin/ld: note: 'g_mime_filter_set_size' is defined in DSO //usr/lib64/libgmime-2.4.so.2 so try adding it to the linker command line\r
  73 //usr/lib64/libgmime-2.4.so.2: could not read symbols: Invalid operation\r
  74 collect2: ld returned 1 exit status\r
  75 make: *** [notmuch-shared] Error 1\r
  76 ---\r
  77  Makefile.local |    2 +-\r
  78  1 files changed, 1 insertions(+), 1 deletions(-)\r
  79 \r
  80 diff --git a/Makefile.local b/Makefile.local\r
  81 index 5bb570b..33b8213 100644\r
  82 --- a/Makefile.local\r
  83 +++ b/Makefile.local\r
  84 @@ -31,7 +31,7 @@ GPG_FILE=$(SHA1_FILE).asc\r
  85  # Smash together user's values with our extra values\r
  86  FINAL_CFLAGS = -DNOTMUCH_VERSION=$(VERSION) $(CFLAGS) $(WARN_CFLAGS) $(CONFIGURE_CFLAGS) $(extra_cflags)\r
  87  FINAL_CXXFLAGS = $(CXXFLAGS) $(WARN_CXXFLAGS) $(CONFIGURE_CXXFLAGS) $(extra_cflags) $(extra_cxxflags)\r
  88 -FINAL_NOTMUCH_LDFLAGS = $(LDFLAGS) -Llib -lnotmuch\r
  89 +FINAL_NOTMUCH_LDFLAGS = $(LDFLAGS) -Llib -lnotmuch $(CONFIGURE_LDFLAGS)\r
  90  FINAL_NOTMUCH_LINKER = CC\r
  91  ifneq ($(LINKER_RESOLVES_LIBRARY_DEPENDENCIES),1)\r
  92  FINAL_NOTMUCH_LDFLAGS += $(CONFIGURE_LDFLAGS)\r
  93 -- \r
  94 1.7.0.5\r
  95 \r