8f/e30d2865c8f9219218e1936a00ed1ea4d0b1cd

   1 Return-Path: <amdragon@mit.edu>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id B4E93431FCB\r
   6         for <notmuch@notmuchmail.org>; Thu, 12 Jul 2012 13:35:04 -0700 (PDT)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.7\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
  12         tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
  13 Received: from olra.theworths.org ([127.0.0.1])\r
  14         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  15         with ESMTP id eRvd6v59h+Ez for <notmuch@notmuchmail.org>;\r
  16         Thu, 12 Jul 2012 13:35:03 -0700 (PDT)\r
  17 Received: from dmz-mailsec-scanner-6.mit.edu (DMZ-MAILSEC-SCANNER-6.MIT.EDU\r
  18         [18.7.68.35])\r
  19         by olra.theworths.org (Postfix) with ESMTP id CF6EE431FAF\r
  20         for <notmuch@notmuchmail.org>; Thu, 12 Jul 2012 13:35:02 -0700 (PDT)\r
  21 X-AuditID: 12074423-b7f396d0000008f4-7a-4fff34f6eea3\r
  22 Received: from mailhub-auth-3.mit.edu ( [18.9.21.43])\r
  23         by dmz-mailsec-scanner-6.mit.edu (Symantec Messaging Gateway) with SMTP\r
  24         id EF.F6.02292.6F43FFF4; Thu, 12 Jul 2012 16:35:02 -0400 (EDT)\r
  25 Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
  26         by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id q6CKZ1eY012353; \r
  27         Thu, 12 Jul 2012 16:35:01 -0400\r
  28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
  29         (authenticated bits=0)\r
  30         (User authenticated as amdragon@ATHENA.MIT.EDU)\r
  31         by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q6CKYxvm003237\r
  32         (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
  33         Thu, 12 Jul 2012 16:35:00 -0400 (EDT)\r
  34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
  35         (envelope-from <amdragon@mit.edu>)\r
  36         id 1SpQ6F-0004gZ-2F; Thu, 12 Jul 2012 16:34:59 -0400\r
  37 Date: Thu, 12 Jul 2012 16:34:59 -0400\r
  38 From: Austin Clements <amdragon@MIT.EDU>\r
  39 To: Tomi Ollila <tomi.ollila@iki.fi>\r
  40 Subject: Re: [PATCH v4 2/3] Add structured output formatter for JSON.\r
  41 Message-ID: <20120712203459.GH7332@mit.edu>\r
  42 References: <87d34hsdx8.fsf@awakening.csail.mit.edu>\r
  43         <1342079004-5300-1-git-send-email-craven@gmx.net>\r
  44         <1342079004-5300-3-git-send-email-craven@gmx.net>\r
  45         <m2vchtthm4.fsf@guru.guru-group.fi>\r
  46 MIME-Version: 1.0\r
  47 Content-Type: text/plain; charset=us-ascii\r
  48 Content-Disposition: inline\r
  49 In-Reply-To: <m2vchtthm4.fsf@guru.guru-group.fi>\r
  50 User-Agent: Mutt/1.5.21 (2010-09-15)\r
  51 X-Brightmail-Tracker:\r
  52  H4sIAAAAAAAAA+NgFuphleLIzCtJLcpLzFFi42IR4hTV1v1m8t/fYMYEIYu9De2MFtdvzmS2\r
  53         eLNyHqsDs8fiTfvZPA5/Xcji8WzVLeYA5igum5TUnMyy1CJ9uwSujL8zXrEVtPFV3Ft6h6WB\r
  54         sZO7i5GTQ0LAROLFwbOsELaYxIV769m6GLk4hAT2MUrMmf+YCcLZwCjx/nU/M0iVkMBJJolz\r
  55         L0sgEksYJT60d4ElWARUJSY9X8IGYrMJaEhs27+cEcQWEVCReNC2HmwFs4C2xJSVd5lAbGEB\r
  56         V4nWp2/AbF6g+N7TW1ghFhxilJi/3B4iLihxcuYTFoheLYkb/14C1XMA2dISy/9xgJicAgYS\r
  57         W67qgVSIAm2acnIb2wRGoVlImmchaZ6F0LyAkXkVo2xKbpVubmJmTnFqsm5xcmJeXmqRrple\r
  58         bmaJXmpK6SZGUKCzuyjvYPxzUOkQowAHoxIPr/DGv/5CrIllxZW5hxglOZiURHk1jP/7C/El\r
  59         5adUZiQWZ8QXleakFgN9wcGsJMKbJQGU401JrKxKLcqHSUlzsCiJ815LuekvJJCeWJKanZpa\r
  60         kFoEk5Xh4FCS4JUBRrSQYFFqempFWmZOCUKaiYMTZDgP0HAOkBre4oLE3OLMdIj8KUZFKXHe\r
  61         8yAXCYAkMkrz4HphiegVozjQK8K8PCDtPMAkBtf9CmgwE9DgWT//gQwuSURISTUwqvsVRWxu\r
  62         ++DuKn6Zp0ucccW092ari2aGvDnE9DD5B++dreX1a383XAq4e/IQb+aZrM5p9pP5T9+XCY43\r
  63         PaUQmdE2W237pcv/PgqwlDMElkcyXzsfonk176Ihl9buaW9vc6+tYxZjNkvr+beQ4cCx1lbb\r
  64         WdNNa74saPNLivcXqdgYvXf6mbtHlViKMxINtZiLihMBAAWa/B8DAAA=\r
  65 Cc: notmuch@notmuchmail.org\r
  66 X-BeenThere: notmuch@notmuchmail.org\r
  67 X-Mailman-Version: 2.1.13\r
  68 Precedence: list\r
  69 List-Id: "Use and development of the notmuch mail system."\r
  70         <notmuch.notmuchmail.org>\r
  71 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  72         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  73 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  74 List-Post: <mailto:notmuch@notmuchmail.org>\r
  75 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  76 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  77         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  78 X-List-Received-Date: Thu, 12 Jul 2012 20:35:04 -0000\r
  79 \r
  80 Quoth Tomi Ollila on Jul 12 at  1:10 pm:\r
  81 > On Thu, Jul 12 2012, craven@gmx.net wrote:\r
  82 > \r
  83 > > Using the new structured printer support in sprinter.h, implement\r
  84 > > sprinter_json_new, which returns a new JSON structured output\r
  85 > > formatter.\r
  86 > >\r
  87 > > The formatter prints output similar to the existing JSON, but with\r
  88 > > differences in whitespace (mostly newlines).\r
  89 > > ---\r
  90 > >  Makefile.local |   1 +\r
  91 > >  sprinter.c     | 172 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++\r
  92 > >  2 files changed, 173 insertions(+)\r
  93 > >  create mode 100644 sprinter.c\r
  94 > >\r
  95 > > diff --git a/Makefile.local b/Makefile.local\r
  96 > > index a890df2..8baf0c2 100644\r
  97 > > --- a/Makefile.local\r
  98 > > +++ b/Makefile.local\r
  99 > > @@ -290,6 +290,7 @@ notmuch_client_srcs =           \\r
 100 > >     notmuch-show.c          \\r
 101 > >     notmuch-tag.c           \\r
 102 > >     notmuch-time.c          \\r
 103 > > +   sprinter.c              \\r
 104 > >     query-string.c          \\r
 105 > >     mime-node.c             \\r
 106 > >     crypto.c                \\r
 107 > > diff --git a/sprinter.c b/sprinter.c\r
 108 > > new file mode 100644\r
 109 > > index 0000000..649f79a\r
 110 > > --- /dev/null\r
 111 > > +++ b/sprinter.c\r
 112 > > @@ -0,0 +1,172 @@\r
 113 > > +#include <stdbool.h>\r
 114 > > +#include <stdio.h>\r
 115 > > +#include <talloc.h>\r
 116 > > +#include "sprinter.h"\r
 117 > > +\r
 118 > > +#define ARRAY_SIZE(arr) (sizeof (arr) / sizeof (arr[0]))\r
 119 > \r
 120 > You're including sprinter.h which includes notmuch-client.h which\r
 121 > defines ARRAY_SIZE (Interesting that you did not get error(/warning?)\r
 122 > about this)\r
 123 > \r
 124 > Rest looks good -- except the whitespace -- as I looked through Austin's\r
 125 > code yesterday you're just replicated the same lines :D. Easiest\r
 126 > to fix is probably just running \r
 127 > uncrustify -c devel/uncrustify.cfg --replace sprinter.c \r
 128 \r
 129 Oops.  Shame on me.  Is anything wrong besides the missing space\r
 130 before the argument list of all of the function declarations?\r