1 Return-Path: <tomi.ollila@nixu.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 2AA6D429E25
\r
6 for <notmuch@notmuchmail.org>; Fri, 16 Dec 2011 03:06:29 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id QZQBmktJhdtY for <notmuch@notmuchmail.org>;
\r
16 Fri, 16 Dec 2011 03:06:28 -0800 (PST)
\r
17 Received: from mail-gw3.nixu.fi (mail-gw3.nixu.fi [193.209.237.7])
\r
18 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id F2EFB431FD0
\r
21 for <notmuch@notmuchmail.org>; Fri, 16 Dec 2011 03:06:27 -0800 (PST)
\r
22 Received: from pps.filterd (mail-gw3 [127.0.0.1])
\r
23 by mail-gw3.nixu.fi (8.14.4/8.14.4) with SMTP id pBGB6Cl5026548;
\r
24 Fri, 16 Dec 2011 13:06:22 +0200
\r
25 Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31])
\r
26 by mail-gw3.nixu.fi with ESMTP id 114cs0tprx-1
\r
27 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);
\r
28 Fri, 16 Dec 2011 13:06:22 +0200
\r
29 Received: from taco2.nixu.fi (taco2.nixu.fi [194.197.118.31])
\r
30 by taco2.nixu.fi (8.14.3/8.14.3/Debian-5+lenny1) with ESMTP id
\r
31 pBGB6LdN031644; Fri, 16 Dec 2011 13:06:21 +0200
\r
32 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
33 To: Aaron Ecay <aaronecay@gmail.com>, notmuch@notmuchmail.org
\r
34 Subject: Re: [PATCH] [emacs] Add an argument to notmuch-mua-mail
\r
35 In-Reply-To: <1324031439-72313-1-git-send-email-aaronecay@gmail.com>
\r
36 References: <1324031439-72313-1-git-send-email-aaronecay@gmail.com>
\r
37 User-Agent: Notmuch/0.10.2+93~g631d290 (http://notmuchmail.org) Emacs/23.3.1
\r
39 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
40 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
41 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
42 Date: Fri, 16 Dec 2011 13:06:21 +0200
\r
43 Message-ID: <yf6pqfog4ia.fsf@taco2.nixu.fi>
\r
45 Content-Type: text/plain; charset=us-ascii
\r
46 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.5.7110,
\r
47 1.0.211, 0.0.0000 definitions=2011-12-16_04:2011-12-16, 2011-12-16,
\r
48 1970-01-01 signatures=0
\r
49 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0
\r
50 ipscore=0 suspectscore=0
\r
51 phishscore=0 bulkscore=0 adultscore=0 classifier=spam adjust=0
\r
53 scancount=1 engine=6.0.2-1012030000 definitions=main-1112160046
\r
54 X-BeenThere: notmuch@notmuchmail.org
\r
55 X-Mailman-Version: 2.1.13
\r
57 List-Id: "Use and development of the notmuch mail system."
\r
58 <notmuch.notmuchmail.org>
\r
59 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
60 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
61 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
62 List-Post: <mailto:notmuch@notmuchmail.org>
\r
63 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
64 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
65 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
66 X-List-Received-Date: Fri, 16 Dec 2011 11:06:29 -0000
\r
68 On Fri, 16 Dec 2011 05:30:39 -0500, Aaron Ecay <aaronecay@gmail.com> wrote:
\r
69 > >From the emacs changelog:
\r
71 > ** `compose-mail' now accepts an optional 8th arg, RETURN-ACTION, and
\r
72 > passes it to the mail user agent function. This argument specifies an
\r
73 > action for returning to the caller after finishing with the mail.
\r
74 > This is currently used by Rmail to delete a mail window.
\r
76 > Under Emacs 24, notmuch breaks when this argument is passed to it by a
\r
77 > function in another part of Emacs. One example of a functon that does
\r
78 > this is report-emacs-bug -- so notmuch users cannot file emacs bug
\r
81 > This patch also adds a &rest argument to the arg-list of this function,
\r
82 > to future-proof against such changes. This is adapted from the approach
\r
83 > taken by message-mail, a similar function built into emacs.
\r
85 > This patch was originally submitted by richardmurri@gmail.com on Aug. 1:
\r
86 > id:"877h6x6oor.fsf@veracitynetworks.com"
\r
87 > Signed-off-by: Aaron Ecay <aaronecay@gmail.com>
\r
90 Emacs 23.3 message-mail is defined as follows:
\r
92 --8<----8<----8<----8<----8<----8<----8<----8<----8<----8<----8<--
\r
93 (defun message-mail (&optional to subject
\r
94 other-headers continue switch-function
\r
95 yank-action send-actions)
\r
97 --8<----8<----8<----8<----8<----8<----8<----8<----8<----8<----8<--
\r
99 If I'd apply your patch would that break it on Emacs 23 ?
\r
104 > emacs/notmuch-mua.el | 6 ++++--
\r
105 > 1 files changed, 4 insertions(+), 2 deletions(-)
\r
107 > diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
\r
108 > index 8824b08..23552ad 100644
\r
109 > --- a/emacs/notmuch-mua.el
\r
110 > +++ b/emacs/notmuch-mua.el
\r
111 > @@ -125,7 +125,8 @@ list."
\r
112 > (message-goto-to))
\r
114 > (defun notmuch-mua-mail (&optional to subject other-headers continue
\r
115 > - switch-function yank-action send-actions)
\r
116 > + switch-function yank-action send-actions
\r
117 > + return-action &rest ignored)
\r
118 > "Invoke the notmuch mail composition window."
\r
121 > @@ -139,7 +140,8 @@ list."
\r
122 > (notmuch-user-name) " <" (notmuch-user-primary-email) ">")) other-headers))
\r
124 > (message-mail to subject other-headers continue
\r
125 > - switch-function yank-action send-actions)
\r
126 > + switch-function yank-action send-actions
\r
128 > (message-sort-headers)
\r
129 > (message-hide-headers)
\r
130 > (set-buffer-modified-p nil)
\r