1 Return-Path: <cworth@cworth.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 4E260431FD0
\r
6 for <notmuch@notmuchmail.org>; Fri, 3 Jun 2011 12:24:36 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0.01 tagged_above=-999 required=5
\r
12 tests=[T_MIME_NO_TEXT=0.01] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id 6KmkHRVIojxm for <notmuch@notmuchmail.org>;
\r
16 Fri, 3 Jun 2011 12:24:35 -0700 (PDT)
\r
17 Received: from arlo.cworth.org (arlo.cworth.org [50.43.72.2])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 8CCEA431FB6
\r
19 for <notmuch@notmuchmail.org>; Fri, 3 Jun 2011 12:24:35 -0700 (PDT)
\r
20 Received: from yoom.home.cworth.org (localhost [127.0.0.1])
\r
21 by arlo.cworth.org (Postfix) with ESMTP id 401D829A5CC;
\r
22 Fri, 3 Jun 2011 12:24:34 -0700 (PDT)
\r
23 Received: by yoom.home.cworth.org (Postfix, from userid 1000)
\r
24 id 2F62225417E; Fri, 3 Jun 2011 12:24:34 -0700 (PDT)
\r
25 From: Carl Worth <cworth@cworth.org>
\r
26 To: Jameson Graef Rollins <jrollins@finestructure.net>,
\r
27 Notmuch Mail <notmuch@notmuchmail.org>
\r
28 Subject: Re: [PATCH 17/25] avoid segfault when calling sanitize_string() on
\r
30 In-Reply-To: <1306619520-25730-18-git-send-email-jrollins@finestructure.net>
\r
31 References: <1306619520-25730-1-git-send-email-jrollins@finestructure.net>
\r
32 <1306619520-25730-2-git-send-email-jrollins@finestructure.net>
\r
33 <1306619520-25730-3-git-send-email-jrollins@finestructure.net>
\r
34 <1306619520-25730-4-git-send-email-jrollins@finestructure.net>
\r
35 <1306619520-25730-5-git-send-email-jrollins@finestructure.net>
\r
36 <1306619520-25730-6-git-send-email-jrollins@finestructure.net>
\r
37 <1306619520-25730-7-git-send-email-jrollins@finestructure.net>
\r
38 <1306619520-25730-8-git-send-email-jrollins@finestructure.net>
\r
39 <1306619520-25730-9-git-send-email-jrollins@finestructure.net>
\r
40 <1306619520-25730-10-git-send-email-jrollins@finestructure.net>
\r
41 <1306619520-25730-11-git-send-email-jrollins@finestructure.net>
\r
42 <1306619520-25730-12-git-send-email-jrollins@finestructure.net>
\r
43 <1306619520-25730-13-git-send-email-jrollins@finestructure.net>
\r
44 <1306619520-25730-14-git-send-email-jrollins@finestructure.net>
\r
45 <1306619520-25730-15-git-send-email-jrollins@finestructure.net>
\r
46 <1306619520-25730-16-git-se nd-email-jrollins@finestructure.net>
\r
47 <1306619520-25730-17-git-send-email-jrollins@finestructure.net>
\r
48 <1306619520-25730-18-git-send-email-jrollins@finestructure.net>
\r
49 User-Agent: Notmuch/0.5 (http://notmuchmail.org) Emacs/23.3.1
\r
51 Date: Fri, 03 Jun 2011 12:24:23 -0700
\r
52 Message-ID: <87vcwmlnvc.fsf@yoom.home.cworth.org>
\r
54 Content-Type: multipart/signed; boundary="=-=-=";
\r
55 micalg=pgp-sha1; protocol="application/pgp-signature"
\r
56 Cc: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
\r
57 X-BeenThere: notmuch@notmuchmail.org
\r
58 X-Mailman-Version: 2.1.13
\r
60 List-Id: "Use and development of the notmuch mail system."
\r
61 <notmuch.notmuchmail.org>
\r
62 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
63 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
64 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
65 List-Post: <mailto:notmuch@notmuchmail.org>
\r
66 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
67 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
68 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
69 X-List-Received-Date: Fri, 03 Jun 2011 19:24:36 -0000
\r
73 On Sat, 28 May 2011 14:51:52 -0700, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
\r
74 > + if (NULL == str)
\r
77 I haven't been blocking patches because of this, but can I please ask
\r
78 everyone to not use the above style?
\r
80 I understand that the above style is intended to generate a compiler
\r
81 error in the case of the programmer mistyping '=' where '==' was
\r
84 But I just can't stand this style.
\r
86 It looks so unnatural to me to read "if some_value is some_variable"
\r
87 instead of the natural "if some_variable is some_value".
\r
89 Also, gcc is kind enough to warn ("suggest parentheses around assignment
\r
90 used as truth value") in the case of "if (str = NULL)" anyway, so
\r
91 there's no actual benefit to the unnatural style.
\r
93 I really do want our code to be readable, and I think that little things
\r
94 do make a difference.
\r
96 Thanks for your attention, (and thanks for your patience if I seem off
\r
102 Content-Type: application/pgp-signature
\r
104 -----BEGIN PGP SIGNATURE-----
\r
105 Version: GnuPG v1.4.11 (GNU/Linux)
\r
107 iEYEARECAAYFAk3pNOcACgkQ6JDdNq8qSWhinACaA5eII2UPeFmC3inHcHtqgvfd
\r
108 ynYAmwbQGgZP67LjDt7JKrYUjEbJWEaQ
\r
110 -----END PGP SIGNATURE-----
\r