1 Return-Path: <aclements@csail.mit.edu>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 0B30C431FB6
\r
6 for <notmuch@notmuchmail.org>; Tue, 2 Sep 2014 12:27:32 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id 6-c+m+xBE2ic for <notmuch@notmuchmail.org>;
\r
16 Tue, 2 Sep 2014 12:27:28 -0700 (PDT)
\r
17 Received: from dmz-mailsec-scanner-3.mit.edu (dmz-mailsec-scanner-3.mit.edu
\r
19 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 70A4A431FAF
\r
22 for <notmuch@notmuchmail.org>; Tue, 2 Sep 2014 12:27:28 -0700 (PDT)
\r
23 X-AuditID: 1209190e-f79d46d000003643-d0-54061a1e6189
\r
24 Received: from mailhub-auth-1.mit.edu ( [18.9.21.35])
\r
25 (using TLS with cipher AES256-SHA (256/256 bits))
\r
26 (Client did not present a certificate)
\r
27 by dmz-mailsec-scanner-3.mit.edu (Symantec Messaging Gateway) with SMTP
\r
28 id 4B.9D.13891.E1A16045; Tue, 2 Sep 2014 15:27:26 -0400 (EDT)
\r
29 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11])
\r
30 by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id s82JRPSD014262;
\r
31 Tue, 2 Sep 2014 15:27:26 -0400
\r
32 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])
\r
33 (authenticated bits=0)
\r
34 (User authenticated as amdragon@ATHENA.MIT.EDU)
\r
35 by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id s82JRNl4014444
\r
36 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT);
\r
37 Tue, 2 Sep 2014 15:27:24 -0400
\r
38 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80)
\r
39 (envelope-from <aclements@csail.mit.edu>)
\r
40 id 1XOtje-0003ck-Ve; Tue, 02 Sep 2014 15:27:23 -0400
\r
41 Date: Tue, 2 Sep 2014 15:27:22 -0400
\r
42 From: Austin Clements <aclements@csail.mit.edu>
\r
43 To: Mark Walters <markwalters1009@gmail.com>
\r
44 Subject: Re: [PATCH v2] emacs: jump: sort-order bugfix
\r
45 Message-ID: <20140902192722.GC4977@csail.mit.edu>
\r
46 References: <1409661049-23417-1-git-send-email-markwalters1009@gmail.com>
\r
47 <1409684164-28407-1-git-send-email-markwalters1009@gmail.com>
\r
49 Content-Type: text/plain; charset=us-ascii
\r
50 Content-Disposition: inline
\r
51 In-Reply-To: <1409684164-28407-1-git-send-email-markwalters1009@gmail.com>
\r
52 User-Agent: Mutt/1.5.21 (2010-09-15)
\r
53 X-Brightmail-Tracker:
\r
54 H4sIAAAAAAAAA+NgFupjleLIzCtJLcpLzFFi42IR4hRV1pWTYgsxmPNDzGL1XB6L6zdnMjsw
\r
55 eeycdZfd49mqW8wBTFFcNimpOZllqUX6dglcGaunHGIu2MJbMe3bHsYGxg1cXYwcHBICJhLL
\r
56 5yh2MXICmWISF+6tZ+ti5OIQEpjNJHFu7wEoZwOjxJwjr6CcU0wSG/Z8ZIVwVjNK3O38xwTS
\r
57 zyKgItH8dR2YzSagL7Fi7SRWEFtEQEfi9qEF7CA2s4C0xLffzWA1wgJmEieeP2MBsXkFDCU+
\r
58 TzjKCDG0k1Hi5ddOdoiEoMTJmU9YIJq1JG78e8kEcjfIoOX/OEBMTgEviXdrykAqRIFOmHJy
\r
59 G9sERqFZSJpnIWmehdC8gJF5FaNsSm6Vbm5iZk5xarJucXJiXl5qka6xXm5miV5qSukmRnBQ
\r
60 S/LtYPx6UOkQowAHoxIPr8QPlhAh1sSy4srcQ4ySHExKorw8ImwhQnxJ+SmVGYnFGfFFpTmp
\r
61 xYcYJTiYlUR4nb+yhgjxpiRWVqUW5cOkpDlYlMR531pbBQsJpCeWpGanphakFsFkZTg4lCR4
\r
62 gyWBhgoWpaanVqRl5pQgpJk4OEGG8wANbwGp4S0uSMwtzkyHyJ9i1OVY1/mtn0mIJS8/L1VK
\r
63 nLcWpEgApCijNA9uDiwZvWIUB3pLmLcbpIoHmMjgJr0CWsIEtMQtB+SD4pJEhJRUA6N7gPN0
\r
64 zricmNvbwxQmfLJm3fFj5818m7PX1lkpf1km1FbK1CO9mnfl6qu2FxdvUd+c9OVz7aa91bG9
\r
65 P3a0llxwEBLmct5k8GH9rMh3Us1TVWYL567jFd66doW1l6CgxdPby0rPWF00kf7T8sxal3H3
\r
66 JeGDThMdOkq632yv/MrwjnFLqO6VskNKLMUZiYZazEXFiQCX0DWFIQMAAA==
\r
67 Cc: notmuch@notmuchmail.org
\r
68 X-BeenThere: notmuch@notmuchmail.org
\r
69 X-Mailman-Version: 2.1.13
\r
71 List-Id: "Use and development of the notmuch mail system."
\r
72 <notmuch.notmuchmail.org>
\r
73 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
74 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
75 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
76 List-Post: <mailto:notmuch@notmuchmail.org>
\r
77 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
78 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
79 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
80 X-List-Received-Date: Tue, 02 Sep 2014 19:27:32 -0000
\r
84 Quoth Mark Walters on Sep 02 at 7:56 pm:
\r
85 > default-value needs its argument to be quoted.
\r
87 > Slightly strangely default-value of 't or nil is 't or nil
\r
88 > respectively so the code
\r
90 > (default-value notmuch-search-oldest-first)
\r
92 > just gives the current value of notmuch-search-oldest-first rather
\r
93 > than intended default-value of this variable.
\r
95 > The symptom is that if you are in a search buffer and use notmuch jump
\r
96 > to run a saved search which does not have an explicitly set sort order
\r
97 > then the sort order of the saved-search is inherited from the current
\r
98 > search buffer rather than being the default search order.
\r
100 > Thanks to Jani for finding the bug.
\r
103 > This time with a fuller commit message.
\r
105 > (Part of the reason I did not send more before is I had not checked
\r
106 > what the exact outcome of the buggy code was: it was obvious what the
\r
107 > code was intended to do, and that with the extra quote it
\r
108 > would do what it was intended to do.)
\r
120 > emacs/notmuch-jump.el | 2 +-
\r
121 > 1 file changed, 1 insertion(+), 1 deletion(-)
\r
123 > diff --git a/emacs/notmuch-jump.el b/emacs/notmuch-jump.el
\r
124 > index 5eb0949..0193f8c 100644
\r
125 > --- a/emacs/notmuch-jump.el
\r
126 > +++ b/emacs/notmuch-jump.el
\r
127 > @@ -51,7 +51,7 @@ (defun notmuch-jump-search ()
\r
128 > (case (plist-get saved-search :sort-order)
\r
129 > (newest-first nil)
\r
131 > - (otherwise (default-value notmuch-search-oldest-first)))))
\r
132 > + (otherwise (default-value 'notmuch-search-oldest-first)))))
\r
133 > (push (list key name
\r
134 > `(lambda () (notmuch-search ',query ',oldest-first)))
\r