85/787ca8603fa5b0fa63e6b748ed269985ce485d

   1 Return-Path: <Sebastian@SSpaeth.de>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id E7AFB431FD0\r
   6         for <notmuch@notmuchmail.org>; Tue,  9 Aug 2011 08:02:53 -0700 (PDT)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.09\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.09 tagged_above=-999 required=5\r
  12         tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
  13         RCVD_IN_DNSWL_NONE=-0.0001, T_MIME_NO_TEXT=0.01] autolearn=disabled\r
  14 Received: from olra.theworths.org ([127.0.0.1])\r
  15         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  16         with ESMTP id bcSwcrMgJkil for <notmuch@notmuchmail.org>;\r
  17         Tue,  9 Aug 2011 08:02:53 -0700 (PDT)\r
  18 Received: from homiemail-a23.g.dreamhost.com (mailbigip.dreamhost.com\r
  19         [208.97.132.5])\r
  20         by olra.theworths.org (Postfix) with ESMTP id 4CE4E431FB6\r
  21         for <notmuch@notmuchmail.org>; Tue,  9 Aug 2011 08:02:53 -0700 (PDT)\r
  22 Received: from homiemail-a23.g.dreamhost.com (localhost [127.0.0.1])\r
  23         by homiemail-a23.g.dreamhost.com (Postfix) with ESMTP id A460F4B008F;\r
  24         Tue,  9 Aug 2011 08:01:02 -0700 (PDT)\r
  25 DomainKey-Signature: a=rsa-sha1; c=nofws; d=SSpaeth.de; h=from:to:cc:subject\r
  26         :in-reply-to:references:date:message-id:mime-version:\r
  27         content-type; q=dns; s=sspaeth.de; b=hfW058z5q/LWCdxRl6suRWtnQsb\r
  28         ha8MamNCTFOk1ZscagoX4S9wxr499647X8t8Nxzv+WRM1n619M5H+HGI7uDKt2Id\r
  29         ulSFSRvdVdHSl+86PMwvcR1Cfbn+8BaqH4WZklhei5e1XLRX6twSxXYwZotk5l4L\r
  30         2fRkHjH1/5b1wDc0=\r
  31 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=SSpaeth.de; h=from:to:cc\r
  32         :subject:in-reply-to:references:date:message-id:mime-version:\r
  33         content-type; s=sspaeth.de; bh=WOoVlWP9xyJkg4+qgPxK6lwsDKM=; b=T\r
  34         OBW1xZo1z14R2YAbEpPZ3UPxCDTvyxmWKrwA5VyM0rpKlRanjNrC/PE64O14OajV\r
  35         jVFlP46um/RH2dk00fd9W58SxsaIXzp2U7Tb/WwlbWn+AlQEvJ4x0WC3AJe4o4h5\r
  36         2xx5RYpeswHBL7VXtbiPjHps6azVyhDUbw0MGwvUcM=\r
  37 Received: from spaetzbook.sspaeth.de (mtec-hg-docking-1-dhcp-21.ethz.ch\r
  38         [129.132.133.21])\r
  39         (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
  40         (No client certificate requested)\r
  41         (Authenticated sender: fax@sspaeth.de)\r
  42         by homiemail-a23.g.dreamhost.com (Postfix) with ESMTPSA id 6CF4A4B0086; \r
  43         Tue,  9 Aug 2011 08:01:00 -0700 (PDT)\r
  44 Received: by spaetzbook.sspaeth.de (sSMTP sendmail emulation);\r
  45         Tue, 09 Aug 2011 17:00:58 +0200\r
  46 From: Sebastian Spaeth <Sebastian@SSpaeth.de>\r
  47 To: Patrick Totzke <patricktotzke@googlemail.com>,\r
  48         David Bremner <david@tethera.net>\r
  49 Subject: Re: xapian exceptions not caught in python bindings?\r
  50 In-Reply-To: <20110723133602.GA30241@brick.lan>\r
  51 References: <20110626202733.GA26837@brick> <20110717193538.GA16615@brick.lan>\r
  52         <87r55o65yq.fsf@zancas.localnet> <20110723133602.GA30241@brick.lan>\r
  53 User-Agent: Notmuch/0.5-233-gb404931 (http://notmuchmail.org) Emacs/23.2.1\r
  54         (x86_64-pc-linux-gnu)\r
  55 Date: Tue, 09 Aug 2011 17:00:58 +0200\r
  56 Message-ID: <87mxfipr2t.fsf@SSpaeth.de>\r
  57 MIME-Version: 1.0\r
  58 Content-Type: multipart/signed; boundary="=-=-=";\r
  59         micalg=pgp-sha1; protocol="application/pgp-signature"\r
  60 Cc: Patrick Totzke <patricktotzke@googlemail.com>, notmuch@notmuchmail.org\r
  61 X-BeenThere: notmuch@notmuchmail.org\r
  62 X-Mailman-Version: 2.1.13\r
  63 Precedence: list\r
  64 List-Id: "Use and development of the notmuch mail system."\r
  65         <notmuch.notmuchmail.org>\r
  66 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  67         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  68 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  69 List-Post: <mailto:notmuch@notmuchmail.org>\r
  70 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  71 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  72         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  73 X-List-Received-Date: Tue, 09 Aug 2011 15:02:54 -0000\r
  74 \r
  75 --=-=-=\r
  76 \r
  77 On Sat, 23 Jul 2011 14:36:02 +0100, Patrick Totzke wrote:\r
  78 > I hope the patch I send is correctly formated, I'm still fumbling with\r
  79 > git send-email and the --in-reply-to option.\r
  80 > Anyhow, forgive my language, of course I didn't mean to be condescending in any\r
  81 > way by calling these prints garbage! It's just that it's highly unusual and very\r
  82 > 'non-pythonic' that a module directly prints to stderr instead of raising exceptions\r
  83 > and if you work directly with a curseslike interface on a terminal these\r
  84 > errormessages litter my screen.\r
  85 \r
  86 Hi,\r
  87 1) I fixed the lack of throwing a NotmuchError when search_threads()\r
  88 failed. This was a bug.\r
  89 \r
  90 2) Taking over stderr and capturing it in a temporary file whenever we\r
  91 create a query sounds incredibly hackish to me. It also potentially has\r
  92 side-effects that I cannot even judge (we might be using stderr for\r
  93 something completely different).\r
  94 \r
  95 IMHO, libnotmuch should be modified to not directly print to stderr\r
  96 but to provide a string with a detailed error message together with it's\r
  97 status value. This would be the proper way to deal with it, even if it\r
  98 means a bit more complexity in the notmuch binary.\r
  99 \r
 100 Sebastian\r
 101 \r
 102 --=-=-=\r
 103 Content-Type: application/pgp-signature\r
 104 \r
 105 -----BEGIN PGP SIGNATURE-----\r
 106 Version: GnuPG v1.4.11 (GNU/Linux)\r
 107 \r
 108 iEYEARECAAYFAk5BS6oACgkQVYX1jMgnoGJSQgCfbZ4qjevLpwl79Ev4Lde1VHu+\r
 109 kK8An3dmUJ1vLBUcVo8Dj5+BudHoaddP\r
 110 =bEiy\r
 111 -----END PGP SIGNATURE-----\r
 112 --=-=-=--\r