1 Return-Path: <novalazy@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 96B58431FAF
\r
6 for <notmuch@notmuchmail.org>; Tue, 10 Apr 2012 01:31:04 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id GxfpTsV5B4sn for <notmuch@notmuchmail.org>;
\r
17 Tue, 10 Apr 2012 01:31:04 -0700 (PDT)
\r
18 Received: from mail-pz0-f45.google.com (mail-pz0-f45.google.com
\r
19 [209.85.210.45]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 00859431FAE
\r
22 for <notmuch@notmuchmail.org>; Tue, 10 Apr 2012 01:31:03 -0700 (PDT)
\r
23 Received: by dacx6 with SMTP id x6so6483837dac.18
\r
24 for <notmuch@notmuchmail.org>; Tue, 10 Apr 2012 01:31:03 -0700 (PDT)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
\r
26 h=date:message-id:from:to:cc:subject:in-reply-to:references
\r
27 :mime-version:content-type:content-disposition
\r
28 :content-transfer-encoding;
\r
29 bh=HOSbZa6VqfnX8Bcegk9WGqgfCD8BgV3jKj+jDT/piuQ=;
\r
30 b=PmTrwE33WLDuUL1XVstK1KxAyF8WMQXxjXOSJU2z9+uOIHF+35EmrdUMP8hureeNXF
\r
31 LRwbt2n/Ya4EHBqNYAeB93stNkOE7hytolm3qIdaMT+xf4eiylqfrsvDEtwTNHN41GWv
\r
32 HvDkX/MqDVYRzkokJRO752b58C5DZ1bI9oqKLZ6d7BzV+3nfST8EH9DWgxF/3Z4tYG0f
\r
33 ShROAsOJIgNl31S57CQ5jxRBi7/BD8eY4naTeiT3eAwRzr4c/2FSEBAurnJodaoIrQNp
\r
34 XDVNFjhob44YFIoqzmM9wlIh7Kf3tEuddQQqpL3jFgOs12u3AB7jG4httFmYyMm2+vhi
\r
36 Received: by 10.68.213.104 with SMTP id nr8mr11786726pbc.91.1334046663095;
\r
37 Tue, 10 Apr 2012 01:31:03 -0700 (PDT)
\r
38 Received: from localhost (215.42.233.220.static.exetel.com.au.
\r
40 by mx.google.com with ESMTPS id r9sm17317748pbi.53.2012.04.10.01.31.00
\r
41 (version=TLSv1/SSLv3 cipher=OTHER);
\r
42 Tue, 10 Apr 2012 01:31:02 -0700 (PDT)
\r
43 Date: Tue, 10 Apr 2012 18:31:00 +1000
\r
44 Message-ID: <20120410183100.GJ8657@hili.localdomain>
\r
45 From: Peter Wang <novalazy@gmail.com>
\r
46 To: Jameson Graef Rollins <jrollins@finestructure.net>
\r
47 Subject: Re: [PATCH v3 4/5] config: Add 'config list' command
\r
48 In-Reply-To: <87r4vwhx0m.fsf@servo.finestructure.net>
\r
49 References: <1332282698-7951-1-git-send-email-novalazy@gmail.com>
\r
50 <1333676886-9835-1-git-send-email-novalazy@gmail.com>
\r
51 <1333676886-9835-5-git-send-email-novalazy@gmail.com>
\r
52 <87r4vwhx0m.fsf@servo.finestructure.net>
\r
54 Content-Type: text/plain; charset=utf-8
\r
55 Content-Disposition: inline
\r
56 Content-Transfer-Encoding: 8bit
\r
57 Cc: notmuch@notmuchmail.org
\r
58 X-BeenThere: notmuch@notmuchmail.org
\r
59 X-Mailman-Version: 2.1.13
\r
61 List-Id: "Use and development of the notmuch mail system."
\r
62 <notmuch.notmuchmail.org>
\r
63 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
64 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
65 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
66 List-Post: <mailto:notmuch@notmuchmail.org>
\r
67 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
68 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
69 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
70 X-List-Received-Date: Tue, 10 Apr 2012 08:31:04 -0000
\r
72 On Tue, 10 Apr 2012 00:22:01 -0700, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
\r
73 > On Thu, Apr 05 2012, Peter Wang <novalazy@gmail.com> wrote:
\r
75 > > - if (strcmp (argv[0], "get") == 0)
\r
76 > > + if (strcmp (argv[0], "get") == 0) {
\r
77 > > + if (argc < 2) {
\r
78 > > + fprintf (stderr, "Error: notmuch config get requires at least "
\r
79 > > + "two arguments.\n");
\r
82 > > return notmuch_config_command_get (ctx, argv[1]);
\r
83 > > - else if (strcmp (argv[0], "set") == 0)
\r
84 > > + } else if (strcmp (argv[0], "set") == 0) {
\r
85 > > + if (argc < 2) {
\r
86 > > + fprintf (stderr, "Error: notmuch config set requires at least "
\r
87 > > + "two arguments.\n");
\r
90 > > return notmuch_config_command_set (ctx, argv[1], argc - 2, argv + 2);
\r
92 > But then these changes look unrelated to me. They do look good
\r
93 > intentioned, though. It's probably best to submit these changes in a
\r
94 > separate unrelated patch.
\r
96 Well, the only reason to duplicate the arity check is due to the
\r
97 introduction of the 'list' subcommand. But I see that the error
\r
98 messages are wrong anyway, so I will separate out the changes in another
\r