1 Return-Path: <thomas@schwinge.name>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id A492F429E26
\r
6 for <notmuch@notmuchmail.org>; Sun, 16 Oct 2011 13:34:55 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_NONE=-0.0001] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id pLleFA8W8YOK for <notmuch@notmuchmail.org>;
\r
16 Sun, 16 Oct 2011 13:34:55 -0700 (PDT)
\r
17 Received: from smtprelay05.ispgateway.de (smtprelay05.ispgateway.de
\r
19 by olra.theworths.org (Postfix) with ESMTP id CECE6429E25
\r
20 for <notmuch@notmuchmail.org>; Sun, 16 Oct 2011 13:34:54 -0700 (PDT)
\r
21 Received: from [87.180.87.168] (helo=stokes.schwinge.homeip.net)
\r
22 by smtprelay05.ispgateway.de with esmtpa (Exim 4.68)
\r
23 (envelope-from <thomas@schwinge.name>) id 1RFXQ5-000417-IL
\r
24 for notmuch@notmuchmail.org; Sun, 16 Oct 2011 22:34:53 +0200
\r
25 Received: (qmail 29086 invoked from network); 16 Oct 2011 20:34:30 -0000
\r
26 Received: from kepler.schwinge.homeip.net (192.168.111.7)
\r
27 by stokes.schwinge.homeip.net with QMQP; 16 Oct 2011 20:34:30 -0000
\r
28 Received: (nullmailer pid 20800 invoked by uid 1000);
\r
29 Sun, 16 Oct 2011 20:34:30 -0000
\r
30 From: Thomas Schwinge <thomas@schwinge.name>
\r
31 To: david@tethera.net
\r
33 In-Reply-To: <1318254561-25386-1-git-send-email-david@tethera.net>
\r
34 References: <8739f2qhla.fsf@zancas.localnet>
\r
35 <1318254561-25386-1-git-send-email-david@tethera.net>
\r
36 User-Agent: Notmuch/0.9-101-g81dad07 (http://notmuchmail.org) Emacs/23.3.1
\r
38 Date: Sun, 16 Oct 2011 22:34:29 +0200
\r
39 Message-ID: <87ipno1xre.fsf@kepler.schwinge.homeip.net>
\r
41 Content-Type: multipart/signed; boundary="=-=-=";
\r
42 micalg=pgp-sha1; protocol="application/pgp-signature"
\r
43 X-Df-Sender: dGhvbWFzQHNjaHdpbmdlLm5hbWU=
\r
44 Cc: notmuch@notmuchmail.org
\r
45 X-BeenThere: notmuch@notmuchmail.org
\r
46 X-Mailman-Version: 2.1.13
\r
48 List-Id: "Use and development of the notmuch mail system."
\r
49 <notmuch.notmuchmail.org>
\r
50 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
51 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
52 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
53 List-Post: <mailto:notmuch@notmuchmail.org>
\r
54 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
55 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
56 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
57 X-List-Received-Date: Sun, 16 Oct 2011 20:34:55 -0000
\r
60 Content-Type: text/plain; charset=utf-8
\r
61 Content-Transfer-Encoding: quoted-printable
\r
65 On Mon, 10 Oct 2011 10:49:15 -0300, david@tethera.net wrote:
\r
66 > OK, here is my proposal to add search terms to notmuch dump.
\r
68 Having worked in the same area ;-), I felt competent to review this. And
\r
69 I definitely do like David's approach. The patches look good, with the
\r
72 What's missing is adding (roughly) the same text to the notmuch manpage,
\r
73 ``notmuch help dump'', NEWS file. These should be added to the
\r
74 respective patches, for enhance functionality and deprecation of output
\r
77 > 2b7781d test: all dump-restore tests should be working now
\r
78 > 7a203d6 notmuch-dump: treat any remaining arguments after the filename as=
\r
81 I would suggest to combine these two into one patch: enhance
\r
82 implementation (7a203d6) and update the tests (2b7781d) is one unit.
\r
84 > d6715d7 test: add tests for command line arguments to notmuch-dump
\r
88 On Mon, 10 Oct 2011 10:49:17 -0300, david@tethera.net wrote:
\r
89 > The plan is to add the possibility of search terms after the file name,
\r
90 > and the use of -- to stop looking for an output file name.
\r
92 > test/dump-restore | 28 ++++++++++++++++++++++++++++
\r
93 > 1 files changed, 28 insertions(+), 0 deletions(-)
\r
95 > diff --git a/test/dump-restore b/test/dump-restore
\r
96 > index 96c4f19..699337c 100755
\r
97 > --- a/test/dump-restore
\r
98 > +++ b/test/dump-restore
\r
99 > @@ -8,6 +8,34 @@ test_expect_success "Dumping all tags" "generate_message=
\r
102 > notmuch dump > dump.expected"
\r
104 > +test_begin_subtest "dump outfile"
\r
105 > +notmuch dump dump-outfile.actual
\r
106 > +test_expect_equal_file dump.expected dump-outfile.actual
\r
108 > +test_begin_subtest "dump outfile --"
\r
109 > +notmuch dump dump-1-arg-dash.actual
\r
110 > +test_expect_equal_file dump.expected dump-1-arg-dash.actual
\r
114 I don't understand the purpose of the second test above. Was this meant
\r
115 to be ``notmuch dump dump-1-arg-dash.actual --'' (as suggested by the
\r
116 description), or ``notmuch dump -- > dump-1-arg-dash.actual''?
\r
123 Content-Type: application/pgp-signature
\r
125 -----BEGIN PGP SIGNATURE-----
\r
126 Version: GnuPG v1.4.11 (GNU/Linux)
\r
128 iQEcBAEBAgAGBQJOmz/VAAoJEGe3hdm9kOiiOEMH/19KlTnLdgsxsn7vSU5MoE5W
\r
129 C9nsQzKgKhst3ChkVAdmLyssURmVcENqHaYtBH8NPIA7qTHUKdGSPo4aY+sCzdnJ
\r
130 Zaf9UqIqn16bEQZARmataMcFtPeDJBl2qp7h6oe7Ej0o6tIWvpOCU8ESg4qN7Ndn
\r
131 89Q65Uue7DyrBzk4sqOM4Q88t+gGy/jPMcOxpnTj5NsxW3feEFlZ1AarDVh3DRrt
\r
132 wbkO9B+y+EAwCnx0GzakZxdK3oPZX9LaqcNjvIOLrefJvVHIu0IHXDx41k3kxJxm
\r
133 LXuGmk5b5UXy+x50/PgOjNhXYZrKVwHu2yel8YAw+Erfh5fOiSTiO810XVm4ydU=
\r
135 -----END PGP SIGNATURE-----
\r