1 Return-Path: <schnouki@schnouki.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 7BB6D429E35
\r
6 for <notmuch@notmuchmail.org>; Tue, 17 Jan 2012 05:23:12 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.1 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1]
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id rxtQLnfCEmX2 for <notmuch@notmuchmail.org>;
\r
17 Tue, 17 Jan 2012 05:23:11 -0800 (PST)
\r
18 Received: from ks3536.kimsufi.com (schnouki.net [87.98.217.222])
\r
19 by olra.theworths.org (Postfix) with ESMTP id 82361429E2F
\r
20 for <notmuch@notmuchmail.org>; Tue, 17 Jan 2012 05:23:11 -0800 (PST)
\r
21 Received: from thor.loria.fr (thor.loria.fr [152.81.12.250])
\r
22 by ks3536.kimsufi.com (Postfix) with ESMTPSA id AB2956A002A;
\r
23 Tue, 17 Jan 2012 14:23:10 +0100 (CET)
\r
24 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=schnouki.net;
\r
25 s=key-schnouki; t=1326806590;
\r
26 bh=RisWfQ3HLVin2az+UXLmHmfyUKI1Y/Nu/WP/wppA6qo=;
\r
27 h=From:To:Subject:In-Reply-To:References:Date:Message-ID:
\r
28 MIME-Version:Content-Type;
\r
29 b=hEdQdEMpvXJXUjEtGqH4dpR+74Z6WAXCAjEUbbfZxBCpbnd5PLiYrZIDWPVZn1JmJ
\r
30 NaaWXGEG2DGCn9YuQ2RuFPBXmaqIlu5XTPXO7IuxhKztHJwVRuJEUIpSoUJjuvHgBi
\r
31 tf/jTQ+572/tl9J83ffcEF0LkeOUtmpD8ABQdvwA=
\r
32 From: Thomas Jost <schnouki@schnouki.net>
\r
33 To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
\r
34 Subject: Re: [PATCH v2 2/2] Add pseudo-compatibility with gmime 2.6
\r
35 In-Reply-To: <yf6lip65wbh.fsf@taco2.nixu.fi>
\r
36 References: <8739bea9lc.fsf@thor.loria.fr>
\r
37 <1326797453-9405-1-git-send-email-schnouki@schnouki.net>
\r
38 <1326797453-9405-2-git-send-email-schnouki@schnouki.net>
\r
39 <yf6lip65wbh.fsf@taco2.nixu.fi>
\r
40 User-Agent: Notmuch/0.11+81~g9729eac (http://notmuchmail.org) Emacs/24.0.92.1
\r
41 (x86_64-unknown-linux-gnu)
\r
42 Date: Tue, 17 Jan 2012 14:23:07 +0100
\r
43 Message-ID: <87y5t68nus.fsf@thor.loria.fr>
\r
45 Content-Type: multipart/signed; boundary="=-=-=";
\r
46 micalg=pgp-sha1; protocol="application/pgp-signature"
\r
47 X-BeenThere: notmuch@notmuchmail.org
\r
48 X-Mailman-Version: 2.1.13
\r
50 List-Id: "Use and development of the notmuch mail system."
\r
51 <notmuch.notmuchmail.org>
\r
52 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
53 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
54 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
55 List-Post: <mailto:notmuch@notmuchmail.org>
\r
56 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
57 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
58 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
59 X-List-Received-Date: Tue, 17 Jan 2012 13:23:12 -0000
\r
62 Content-Type: text/plain
\r
63 Content-Transfer-Encoding: quoted-printable
\r
65 On Tue, 17 Jan 2012 14:48:34 +0200, Tomi Ollila <tomi.ollila@iki.fi> wrote:
\r
66 > On Tue, 17 Jan 2012 11:50:53 +0100, Thomas Jost <schnouki@schnouki.net> w=
\r
68 > > There are lots of API changes in gmime 2.6 crypto handling. By adding
\r
69 > > preprocessor directives, it is however possible to add gmime 2.6 compat=
\r
71 > > while preserving compatibility with gmime 2.4 too.
\r
73 > > This is mostly based on id:"8762i8hrb9.fsf@bookbinder.fernseed.info".
\r
75 > > This was tested against both gmime 2.6.4 and 2.4.31. With gmime 2.4.31,=
\r
77 > > crypto tests all work fine (as expected). With gmime 2.6.4, one crypto =
\r
79 > > fails (signature verification with signer key unavailable) but this wil=
\r
81 > > to fix since the new API does not report the reason why a signature ver=
\r
83 > > fails (other than the human-readable error message).
\r
86 > LGTM. Some whitespace things but most of those were there already;
\r
87 > I'd have one uncrustify round to be applied to the source and after
\r
88 > that be more strict about those...
\r
90 Thanks! I'll fix the whitespace issues in these patches when the source
\r
91 in Git is uncrustified then.
\r
93 > actually gmime 2.4 has GMIME_CHECK_VERSION defined as
\r
94 > g_mime_check_version (major, minor, micro) so the comment about it
\r
95 > is not entirely accurate (it is unusable in our context, though)
\r
97 Oops, yes. What I really meant is that GMIME_MAJOR_VERSION is not
\r
98 available as a preprocessor constant in 2.4, and GMIME_CHECK_VERSION is
\r
99 unusable in our context since it just calls a runtime function.
\r
101 By the way, how do you guys feel about setting GMIME_26 in
\r
102 notmuch-client.h? Is that good enough, or should it be done in configure
\r
103 so that gcc is called with "-DGMIME_26"?
\r
105 I filed a bug about gmime 2.6 incorrect handling of signatures with
\r
106 missing public keys: https://bugzilla.gnome.org/show_bug.cgi?id=3D668085.
\r
107 A patch is attached there, feel free to test and comment.
\r
109 (Arch Linux users: I made a little PKGBUILD that includes this patch if
\r
110 you want to build your own gmime 2.6.4:
\r
111 http://fichiers.schnouki.net/tmp/gmime-2.6.4-1.src.tar.gz)
\r
119 Content-Type: application/pgp-signature
\r
121 -----BEGIN PGP SIGNATURE-----
\r
122 Version: GnuPG v1.4.11 (GNU/Linux)
\r
124 iQEcBAEBAgAGBQJPFXY7AAoJEMPdciX+bh5I2FUH/0eH0QTlJn9ytAXxKBtGu16N
\r
125 SUe9BpM5BbEKe/o7AaCyvECeTIrTo+6EGDYfuTOslamWS9T7M3mO2y75rcdzOMxL
\r
126 Ae5Du9rTfBGLPgl/RQyLVwyfUt3iaw9kMrVXG1Ed3mQ8bEtwk/nrt7RYH/dm4Yfn
\r
127 qw3N2KDAcemJN40c99U6KpGJN4G5huuf6UL+HfA+7lipGm4e2FP76BGHWMKWG2Ty
\r
128 1S8l4AWowpInfrudTx1k1u7SeNVgFjZ+9Md4FR2uiA7tJKAziwWqi5LUZ7On0fXa
\r
129 z7ZbpLoPrSCwxPyZtGIgazbLHMcNAMwTaNIoeHXnIwHwH/cl62uVRVFHLrVZ9hs=
\r
131 -----END PGP SIGNATURE-----
\r