1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 544A0429E59
\r
6 for <notmuch@notmuchmail.org>; Mon, 19 Aug 2013 07:29:34 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id 9b-20F85wvk1 for <notmuch@notmuchmail.org>;
\r
16 Mon, 19 Aug 2013 07:29:28 -0700 (PDT)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by olra.theworths.org (Postfix) with ESMTP id A262C431E62
\r
19 for <notmuch@notmuchmail.org>; Mon, 19 Aug 2013 07:29:28 -0700 (PDT)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id 9C102100086;
\r
22 Mon, 19 Aug 2013 17:29:20 +0300 (EEST)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: Geoffrey Ferrari <geoffrey.ferrari@oriel.oxon.org>,
\r
25 notmuch@notmuchmail.org
\r
26 Subject: Re: [PATCH] emacs: bugfix notmuch-mua-reply when signature is present
\r
27 In-Reply-To: <m238qjqnt5.fsf@guru.guru-group.fi>
\r
29 <1375961732-14327-1-git-send-email-geoffrey.ferrari@oriel.oxon.org>
\r
30 <m238qjqnt5.fsf@guru.guru-group.fi>
\r
31 User-Agent: Notmuch/0.16+3~g340c058 (http://notmuchmail.org) Emacs/24.3.1
\r
32 (x86_64-unknown-linux-gnu)
\r
33 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
34 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
35 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
36 Date: Mon, 19 Aug 2013 17:29:20 +0300
\r
37 Message-ID: <m238q5ycsf.fsf@guru.guru-group.fi>
\r
39 Content-Type: text/plain
\r
40 X-BeenThere: notmuch@notmuchmail.org
\r
41 X-Mailman-Version: 2.1.13
\r
43 List-Id: "Use and development of the notmuch mail system."
\r
44 <notmuch.notmuchmail.org>
\r
45 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
46 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
47 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
48 List-Post: <mailto:notmuch@notmuchmail.org>
\r
49 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
50 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
51 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
52 X-List-Received-Date: Mon, 19 Aug 2013 14:29:34 -0000
\r
54 On Fri, Aug 09 2013, Tomi Ollila <tomi.ollila@iki.fi> wrote:
\r
56 > On Thu, Aug 08 2013, Geoffrey Ferrari <geoffrey.ferrari@oriel.oxon.org> wrote:
\r
58 >> From: "Geoffrey H. Ferrari" <geoffrey.ferrari@oriel.oxon.org>
\r
60 >> When composing a reply, notmuch-mua-reply tries to be smart and cite
\r
61 >> the original message by inserting it before the user signature, if
\r
62 >> one is present. However, the existing method of backward searching
\r
63 >> from the end of the buffer to find the signature separator and then
\r
64 >> moving one line up results in the original message being cited in
\r
65 >> the message headers. That's because at this point the message looks
\r
66 >> like this (with | representing point after searching for the
\r
67 >> signature separator):
\r
72 >> --text follows this line--
\r
74 >> My fancy signature
\r
76 >> With this patch, a newline is opened instead, so that the orignal
\r
77 >> message is cited above the signature but still in the message text.
\r
80 > This probably fixes #1 in id:8762auwgfl.fsf@steelpick.2x.cz
\r
82 > ( http://mid.gmane.org/8762auwgfl.fsf@steelpick.2x.cz )
\r
84 > ... I just noticed I have no clue how to set message signature to test
\r
87 Now I tried something fancy and executed `echo foobar > ~/.signature`
\r
89 Now I get the "--\nfoobar" at the end of all emails I'm, composing -- but
\r
90 I don't see any problems when replying... so I'd be interested to see
\r
91 in what circumstances could I get the problem this patch solves exposed.
\r
102 >> emacs/notmuch-mua.el | 2 +-
\r
103 >> 1 file changed, 1 insertion(+), 1 deletion(-)
\r
105 >> diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
\r
106 >> index 2baae5f..86f164d 100644
\r
107 >> --- a/emacs/notmuch-mua.el
\r
108 >> +++ b/emacs/notmuch-mua.el
\r
109 >> @@ -194,7 +194,7 @@ list."
\r
110 >> ;; if one is present
\r
111 >> (goto-char (point-max))
\r
112 >> (if (re-search-backward message-signature-separator nil t)
\r
113 >> - (forward-line -1)
\r
115 >> (goto-char (point-max)))
\r
117 >> (let ((from (plist-get original-headers :From))
\r
121 >> _______________________________________________
\r
122 >> notmuch mailing list
\r
123 >> notmuch@notmuchmail.org
\r
124 >> http://notmuchmail.org/mailman/listinfo/notmuch
\r