7e/caac987595e784ed766f77ccf3070ef2ac6312

   1 Return-Path: <amdragon@mit.edu>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id AF503429E25\r
   6         for <notmuch@notmuchmail.org>; Sat, 12 Nov 2011 08:32:44 -0800 (PST)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.7\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
  12         tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
  13 Received: from olra.theworths.org ([127.0.0.1])\r
  14         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  15         with ESMTP id 9XacYUKbdlgY for <notmuch@notmuchmail.org>;\r
  16         Sat, 12 Nov 2011 08:32:44 -0800 (PST)\r
  17 Received: from dmz-mailsec-scanner-7.mit.edu (DMZ-MAILSEC-SCANNER-7.MIT.EDU\r
  18         [18.7.68.36])\r
  19         by olra.theworths.org (Postfix) with ESMTP id 0FCE9431FB6\r
  20         for <notmuch@notmuchmail.org>; Sat, 12 Nov 2011 08:32:43 -0800 (PST)\r
  21 X-AuditID: 12074424-b7ef76d0000008dc-58-4ebe9fabcbdc\r
  22 Received: from mailhub-auth-4.mit.edu ( [18.7.62.39])\r
  23         by dmz-mailsec-scanner-7.mit.edu (Symantec Messaging Gateway) with SMTP\r
  24         id C4.37.02268.BAF9EBE4; Sat, 12 Nov 2011 11:32:43 -0500 (EST)\r
  25 Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
  26         by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id pACGWgZA003320; \r
  27         Sat, 12 Nov 2011 11:32:43 -0500\r
  28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
  29         (authenticated bits=0)\r
  30         (User authenticated as amdragon@ATHENA.MIT.EDU)\r
  31         by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id pACGWdQb006989\r
  32         (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
  33         Sat, 12 Nov 2011 11:32:40 -0500 (EST)\r
  34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
  35         (envelope-from <amdragon@mit.edu>)\r
  36         id 1RPGXm-0006w8-OW; Sat, 12 Nov 2011 11:35:02 -0500\r
  37 Date: Sat, 12 Nov 2011 11:35:02 -0500\r
  38 From: Austin Clements <amdragon@MIT.EDU>\r
  39 To: David Bremner <david@tethera.net>\r
  40 Subject: Re: [PATCH 6/6] emacs: make `notmuch-search-operate-all' operate on\r
  41         threads, not messages\r
  42 Message-ID: <20111112163502.GE2658@mit.edu>\r
  43 References: <1310313335-4159-1-git-send-email-pieter@praet.org>\r
  44         <1310313335-4159-7-git-send-email-pieter@praet.org>\r
  45         <87fwht2u9k.fsf@rocinante.cs.unb.ca>\r
  46 MIME-Version: 1.0\r
  47 Content-Type: text/plain; charset=us-ascii\r
  48 Content-Disposition: inline\r
  49 In-Reply-To: <87fwht2u9k.fsf@rocinante.cs.unb.ca>\r
  50 User-Agent: Mutt/1.5.21 (2010-09-15)\r
  51 X-Brightmail-Tracker:\r
  52  H4sIAAAAAAAAA+NgFprFKsWRmVeSWpSXmKPExsUixG6nrrt6/j4/g4avGhY3WrsZLa7fnMls\r
  53         8fv1DWYHZo9nq24xe3Tsu8zqseXQe+YA5igum5TUnMyy1CJ9uwSujKOnNrIVTOequLb8C1MD\r
  54         4wKOLkZODgkBE4ndc24wQ9hiEhfurWfrYuTiEBLYxyhx7c4CFghnA6PEu44eqMxJJon2BYeZ\r
  55         IJwljBJrPmxkAelnEVCVOHz6BzuIzSagIbFt/3JGEFsEKH5122Q2EJtZwFtiyZuvYLawQIrE\r
  56         spebwGxeAW2JPydmg80REpjDKLFlhQREXFDi5MwnLBC9WhI3/r0EWswBZEtLLP8H9gKngKHE\r
  57         0gtfwVaJCqhITDm5jW0Co9AsJN2zkHTPQuhewMi8ilE2JbdKNzcxM6c4NVm3ODkxLy+1SNdc\r
  58         LzezRC81pXQTIzjYXVR2MDYfUjrEKMDBqMTD652w10+INbGsuDL3EKMkB5OSKO+3Ofv8hPiS\r
  59         8lMqMxKLM+KLSnNSiw8xSnAwK4nwrrYDyvGmJFZWpRblw6SkOViUxHltdjr4CQmkJ5akZqem\r
  60         FqQWwWRlODiUJHhVgFEtJFiUmp5akZaZU4KQZuLgBBnOAzT83DyQ4cUFibnFmekQ+VOMuhzr\r
  61         rjSfZhRiycvPS5US59UGGSQAUpRRmgc3B5akXjGKA70lzHsRZBQPMMHBTXoFtIQJaAmLwl6Q\r
  62         JSWJCCmpBkbhxQ9uH73VsTD2bG9Lxdb1ba+TD2bV89SdWHAuLn82U1rxYYV0BqaZN7tevu0N\r
  63         PTDl1MHMzBvOpRPvMXC7X81mqvNdJhLGnrkwgr3A06UuR8Uh6ZZko1mYhUMeQ8IG/TQdngOt\r
  64         SSyOHH9nHyxZuvXzl7BihUXyE7y6a8oXNLuzC7ldeK4eq8RSnJFoqMVcVJwIALYlC2ItAwAA\r
  65 Cc: Notmuch Mail <notmuch@notmuchmail.org>\r
  66 X-BeenThere: notmuch@notmuchmail.org\r
  67 X-Mailman-Version: 2.1.13\r
  68 Precedence: list\r
  69 List-Id: "Use and development of the notmuch mail system."\r
  70         <notmuch.notmuchmail.org>\r
  71 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  72         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  73 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  74 List-Post: <mailto:notmuch@notmuchmail.org>\r
  75 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  76 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  77         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  78 X-List-Received-Date: Sat, 12 Nov 2011 16:32:44 -0000\r
  79 \r
  80 Quoth David Bremner on Nov 12 at 11:13 am:\r
  81 > On Sun, 10 Jul 2011 17:55:35 +0200, Pieter Praet <pieter@praet.org> wrote:\r
  82 > > In order to be consistent with `notmuch-search-{add,remove}-tag' ("+"/"-"),\r
  83 > > `notmuch-search-operate-all' ("*") should operate on matching threads\r
  84 > > instead of matching messages.\r
  85 > > \r
  86 > \r
  87 > As far as I can tell, the follow-up series for the race condition kindof\r
  88 > got stalled.  Am I right in thinking this bug fix should still be\r
  89 > applied? I didn't see any review/feedback on the list.\r
  90 \r
  91 We concluded that fixing the tagging race correctly was actually a lot\r
  92 of work, which should be done but hasn't yet.  We have to add message\r
  93 IDs or docids to the search results, which is difficult to do with the\r
  94 current text format, so rather than further entrenching ourselves, we\r
  95 should first we should migrate Emacs to using the JSON-based search\r
  96 output.\r
  97 \r
  98 However, this series doesn't actually have much to do with the race.\r
  99 I think the question here is whether notmuch-search-operate-all should\r
 100 affect only matched messages or entire threads.  It seems to me it\r
 101 should affect all threads, since that's what you're seeing visually,\r
 102 but other people may disagree.\r
 103 \r
 104 The test patches seem reasonable, though they could use a little\r
 105 review before being pushed.\r