1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id B5826431FAF
\r
6 for <notmuch@notmuchmail.org>; Thu, 6 Sep 2012 01:56:56 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id IOigcepbM0-o for <notmuch@notmuchmail.org>;
\r
16 Thu, 6 Sep 2012 01:56:56 -0700 (PDT)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by olra.theworths.org (Postfix) with ESMTP id DBFCE431FAE
\r
19 for <notmuch@notmuchmail.org>; Thu, 6 Sep 2012 01:56:55 -0700 (PDT)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id BEBDB1000E5;
\r
22 Thu, 6 Sep 2012 11:57:01 +0300 (EEST)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: Michal Sojka <sojkam1@fel.cvut.cz>, notmuch@notmuchmail.org
\r
25 Subject: Re: [PATCH v2] emacs: Add customization group for replying
\r
26 In-Reply-To: <1346919815-20397-1-git-send-email-sojkam1@fel.cvut.cz>
\r
27 References: <1346919815-20397-1-git-send-email-sojkam1@fel.cvut.cz>
\r
28 User-Agent: Notmuch/0.14+11~gd9bf007 (http://notmuchmail.org) Emacs/24.2.1
\r
29 (x86_64-unknown-linux-gnu)
\r
30 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
31 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
32 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
33 Date: Thu, 06 Sep 2012 11:57:01 +0300
\r
34 Message-ID: <m2wr07fs0y.fsf@guru.guru-group.fi>
\r
36 Content-Type: text/plain
\r
37 X-BeenThere: notmuch@notmuchmail.org
\r
38 X-Mailman-Version: 2.1.13
\r
40 List-Id: "Use and development of the notmuch mail system."
\r
41 <notmuch.notmuchmail.org>
\r
42 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
43 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
44 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
45 List-Post: <mailto:notmuch@notmuchmail.org>
\r
46 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
47 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
48 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
49 X-List-Received-Date: Thu, 06 Sep 2012 08:56:56 -0000
\r
51 On Thu, Sep 06 2012, Michal Sojka <sojkam1@fel.cvut.cz> wrote:
\r
53 > When one wants to customize the format of reply message, there is nothing
\r
54 > to tell the user how to do it. Without knowing that construction of
\r
55 > reply buffer is actually implemented in the message package, it seems
\r
56 > that replying cannot be customized.
\r
58 > Because I was getting annoyed by the empty line the between the citation
\r
59 > line and the quoted message, I figured out that changing this is fairly
\r
60 > easy when one knows what to customize.
\r
62 > This patch adds notmuch-reply customization group that contains
\r
63 > references to the relevant customization options. The new group is easy
\r
64 > to find as it is shown as a result of running "M-x customize-group RET
\r
70 You forgot to handle the current group setting for
\r
71 notmuch-message-replied-tags -- currently notmuch-message.el has this:
\r
73 (defcustom notmuch-message-replied-tags '("replied")
\r
74 "Tags to be automatically added to or removed from a message when it is
\r
76 Any tag in the list will be added to a replied message or,
\r
77 if it is prefaced with a \"-\", removed.
\r
79 For example, if you wanted to add a \"replied\" tag and remove
\r
80 the \"inbox\" and \"todo\", you would set
\r
81 (\"replied\" \"-inbox\" \"-todo\"\)"
\r
83 :group 'notmuch-send)
\r
85 If the above was changed to 'normuch-send, (require 'notmuch-lib)
\r
86 was added to the beginning of notmuch-message.el and the defgroup
\r
87 below was written as
\r
89 (defgroup notmuch-reply
\r
90 '((message-insertion custom-group)))
\r
91 "Replying to messages.
\r
94 would that work as expected ?
\r
99 > emacs/notmuch-lib.el | 10 ++++++++++
\r
100 > 1 file changed, 10 insertions(+)
\r
102 > diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el
\r
103 > index 900235b..c045a32 100644
\r
104 > --- a/emacs/notmuch-lib.el
\r
105 > +++ b/emacs/notmuch-lib.el
\r
106 > @@ -45,6 +45,16 @@
\r
107 > "Showing messages and threads."
\r
110 > +(defgroup notmuch-reply
\r
111 > + '((message-insertion custom-group)
\r
112 > + (notmuch-message-replied-tags custom-variable))
\r
113 > + "Replying to messages.
\r
115 > +Most of the reply customization settings can be found in `Message
\r
116 > +insertion' group. Notmuch specific settings is included directly
\r
118 > + :group 'notmuch)
\r
120 > (defgroup notmuch-send nil
\r
121 > "Sending messages from Notmuch."
\r
126 > _______________________________________________
\r
127 > notmuch mailing list
\r
128 > notmuch@notmuchmail.org
\r
129 > http://notmuchmail.org/mailman/listinfo/notmuch
\r