7c/3e3aa44b1889c8163b89f5ed657d8d0c1088de

   1 Return-Path: <amdragon@mit.edu>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id 0A4DE431FAF\r
   6         for <notmuch@notmuchmail.org>; Mon, 24 Dec 2012 12:32:54 -0800 (PST)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.7\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
  12         tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
  13 Received: from olra.theworths.org ([127.0.0.1])\r
  14         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  15         with ESMTP id Tz2Cug1cLpnP for <notmuch@notmuchmail.org>;\r
  16         Mon, 24 Dec 2012 12:32:52 -0800 (PST)\r
  17 Received: from dmz-mailsec-scanner-5.mit.edu (DMZ-MAILSEC-SCANNER-5.MIT.EDU\r
  18         [18.7.68.34])\r
  19         by olra.theworths.org (Postfix) with ESMTP id 92296431FAE\r
  20         for <notmuch@notmuchmail.org>; Mon, 24 Dec 2012 12:32:52 -0800 (PST)\r
  21 X-AuditID: 12074422-b7f616d000000e7c-4d-50d8bbf3b157\r
  22 Received: from mailhub-auth-3.mit.edu ( [18.9.21.43])\r
  23         by dmz-mailsec-scanner-5.mit.edu (Symantec Messaging Gateway) with SMTP\r
  24         id B4.AF.03708.3FBB8D05; Mon, 24 Dec 2012 15:32:51 -0500 (EST)\r
  25 Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
  26         by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id qBOKWojZ012582; \r
  27         Mon, 24 Dec 2012 15:32:50 -0500\r
  28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
  29         (authenticated bits=0)\r
  30         (User authenticated as amdragon@ATHENA.MIT.EDU)\r
  31         by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id qBOKWlIe027329\r
  32         (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT);\r
  33         Mon, 24 Dec 2012 15:32:48 -0500 (EST)\r
  34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80)\r
  35         (envelope-from <amdragon@mit.edu>)\r
  36         id 1TnEhb-0008LK-59; Mon, 24 Dec 2012 15:32:47 -0500\r
  37 From: Austin Clements <aclements@csail.mit.edu>\r
  38 To: david@tethera.net, notmuch@notmuchmail.org\r
  39 Subject: Re: [PATCH] _notmuch_message_index_file: unref (free) address lists\r
  40         from gmime.\r
  41 In-Reply-To: <1355196820-29734-1-git-send-email-david@tethera.net>\r
  42 References: <1355188740-6663-1-git-send-email-david@tethera.net>\r
  43         <1355196820-29734-1-git-send-email-david@tethera.net>\r
  44 User-Agent: Notmuch/0.14+236~gf64406d (http://notmuchmail.org) Emacs/23.4.1\r
  45         (i486-pc-linux-gnu)\r
  46 Date: Mon, 24 Dec 2012 15:32:46 -0500\r
  47 Message-ID: <87txrbkx75.fsf@awakening.csail.mit.edu>\r
  48 MIME-Version: 1.0\r
  49 Content-Type: text/plain; charset=us-ascii\r
  50 X-Brightmail-Tracker:\r
  51  H4sIAAAAAAAAA+NgFvrGIsWRmVeSWpSXmKPExsUixCmqrft5940Ag47XfBYbl/1ktrjR2s1o\r
  52         cf3mTGYHZo9fbXOZPZ6tusXsseXQe+YA5igum5TUnMyy1CJ9uwSujIbLp9gKmngrXt/cwNrA\r
  53         eICri5GTQ0LARGLHjytMELaYxIV769m6GLk4hAT2MUpMmX2VGcLZwCjRf3onVOYik8Snyc+Z\r
  54         IJwljBI9bbdYQfrZBPQlVqydBGRzcIgI6Eks3CoDEmYWUJOYtOYMO4gtLBAhcb1rHpjNKeAk\r
  55         0dF9kxnEFhIok5h1cTqYLSoQL/H83jcWEJtFQFXi1+KpYCN5gU69OgEszCsgKHFy5hMWiPFa\r
  56         Ejf+vWSawCg4C0lqFpLUAkamVYyyKblVurmJmTnFqcm6xcmJeXmpRbqmermZJXqpKaWbGEHB\r
  57         y+6itIPx50GlQ4wCHIxKPLwFk28ECLEmlhVX5h5ilORgUhLl9d0FFOJLyk+pzEgszogvKs1J\r
  58         LT7EKMHBrCTCy70OKMebklhZlVqUD5OS5mBREue9lnLTX0ggPbEkNTs1tSC1CCYrw8GhJMF7\r
  59         EWSoYFFqempFWmZOCUKaiYMTZDgP0PBlIDW8xQWJucWZ6RD5U4yKUuK8LSAJAZBERmkeXC8s\r
  60         ubxiFAd6RZi3HqSKB5iY4LpfAQ1mAhocywc2uCQRISXVwNg584nWnqan9+ZbnDr95+05gfOv\r
  61         vLUuPLCqS/64+OkTuzfO3+bMKpLb4asjIHbgpJaphrZpfsAcjq5/K+xMJHyNkzMD3zzK9Mj6\r
  62         UZTkX152VniVTlLb/KDYy8/uqc1xrulqCU7P3u2Z/+PMrt8dLlo+Zhfuzdpjyyby9+/mljDu\r
  63         lTf+3HpyS1KJpTgj0VCLuag4EQDfwg6GCQMAAA==\r
  64 Cc: David Bremner <bremner@debian.org>\r
  65 X-BeenThere: notmuch@notmuchmail.org\r
  66 X-Mailman-Version: 2.1.13\r
  67 Precedence: list\r
  68 List-Id: "Use and development of the notmuch mail system."\r
  69         <notmuch.notmuchmail.org>\r
  70 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  71         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  72 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  73 List-Post: <mailto:notmuch@notmuchmail.org>\r
  74 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  75 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  76         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  77 X-List-Received-Date: Mon, 24 Dec 2012 20:32:54 -0000\r
  78 \r
  79 This patch LGTM.\r
  80 \r
  81 On Mon, 10 Dec 2012, david@tethera.net wrote:\r
  82 > From: David Bremner <bremner@debian.org>\r
  83 >\r
  84 > Apparently as of GMime 2.4, you don't need to call\r
  85 > internet_address_list_destroy anymore, but you still need to call\r
  86 > g_object_unref (from the GMime Changelog).\r
  87 >\r
  88 > On the medium performance corpus, valgrind shows "possibly lost"\r
  89 > leakage in "notmuch new" dropping from 7M to 300k.\r
  90 > ---\r
  91 >  lib/index.cc |   12 +++++++++---\r
  92 >  1 file changed, 9 insertions(+), 3 deletions(-)\r
  93 >\r
  94 > diff --git a/lib/index.cc b/lib/index.cc\r
  95 > index da0e6ce..a2edd6d 100644\r
  96 > --- a/lib/index.cc\r
  97 > +++ b/lib/index.cc\r
  98 > @@ -484,12 +484,18 @@ mboxes is deprecated and may be removed in the future.\n", filename);\r
  99 >      }\r
 100 >  \r
 101 >      from = g_mime_message_get_sender (mime_message);\r
 102 > -    addresses = internet_address_list_parse_string (from);\r
 103 >  \r
 104 > -    _index_address_list (message, "from", addresses);\r
 105 > +    addresses = internet_address_list_parse_string (from);\r
 106 > +    if (addresses) {\r
 107 > +     _index_address_list (message, "from", addresses);\r
 108 > +     g_object_unref (addresses);\r
 109 > +    }\r
 110 >  \r
 111 >      addresses = g_mime_message_get_all_recipients (mime_message);\r
 112 > -    _index_address_list (message, "to", addresses);\r
 113 > +    if (addresses) {\r
 114 > +     _index_address_list (message, "to", addresses);\r
 115 > +     g_object_unref (addresses);\r
 116 > +    }\r
 117 >  \r
 118 >      subject = g_mime_message_get_subject (mime_message);\r
 119 >      _notmuch_message_gen_terms (message, "subject", subject);\r
 120 > -- \r
 121 > 1.7.10.4\r
 122 >\r
 123 > _______________________________________________\r
 124 > notmuch mailing list\r
 125 > notmuch@notmuchmail.org\r
 126 > http://notmuchmail.org/mailman/listinfo/notmuch\r