1 Return-Path: <amdragon@mit.edu>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 3589F431FAF
\r
6 for <notmuch@notmuchmail.org>; Mon, 6 Feb 2012 06:15:58 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id 5mPj3XL-ZhzY for <notmuch@notmuchmail.org>;
\r
16 Mon, 6 Feb 2012 06:15:57 -0800 (PST)
\r
17 Received: from dmz-mailsec-scanner-5.mit.edu (DMZ-MAILSEC-SCANNER-5.MIT.EDU
\r
19 by olra.theworths.org (Postfix) with ESMTP id 82B8E431FAE
\r
20 for <notmuch@notmuchmail.org>; Mon, 6 Feb 2012 06:15:57 -0800 (PST)
\r
21 X-AuditID: 12074422-b7fd66d0000008f9-4f-4f2fe09adbbb
\r
22 Received: from mailhub-auth-2.mit.edu ( [18.7.62.36])
\r
23 by dmz-mailsec-scanner-5.mit.edu (Symantec Messaging Gateway) with SMTP
\r
24 id 99.88.02297.A90EF2F4; Mon, 6 Feb 2012 09:15:54 -0500 (EST)
\r
25 Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])
\r
26 by mailhub-auth-2.mit.edu (8.13.8/8.9.2) with ESMTP id q16EFrZi010758;
\r
27 Mon, 6 Feb 2012 09:15:54 -0500
\r
28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])
\r
29 (authenticated bits=0)
\r
30 (User authenticated as amdragon@ATHENA.MIT.EDU)
\r
31 by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q16EFonX022585
\r
32 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);
\r
33 Mon, 6 Feb 2012 09:15:53 -0500 (EST)
\r
34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)
\r
35 (envelope-from <amdragon@mit.edu>)
\r
36 id 1RuPL5-0006ur-Q4; Mon, 06 Feb 2012 09:14:39 -0500
\r
37 Date: Mon, 6 Feb 2012 09:14:39 -0500
\r
38 From: Austin Clements <amdragon@MIT.EDU>
\r
39 To: Jani Nikula <jani@nikula.org>
\r
40 Subject: Re: [PATCH 1/2] cli: convert "notmuch show" to use the new argument
\r
42 Message-ID: <20120206141439.GR10898@mit.edu>
\r
44 <df2e9bd7682e9c81e1b205cc1d92a1526cdd1a9b.1328308635.git.jani@nikula.org>
\r
45 <20120206041205.GP10898@mit.edu> <87ty34bdnp.fsf@nikula.org>
\r
47 Content-Type: text/plain; charset=us-ascii
\r
48 Content-Disposition: inline
\r
49 In-Reply-To: <87ty34bdnp.fsf@nikula.org>
\r
50 User-Agent: Mutt/1.5.21 (2010-09-15)
\r
51 X-Brightmail-Tracker:
\r
52 H4sIAAAAAAAAA+NgFvrHIsWRmVeSWpSXmKPExsUixG6nojvrgb6/wcw3uhZN050trt+cyezA
\r
53 5HHr/mt2j2erbjEHMEVx2aSk5mSWpRbp2yVwZey684K94Bh7xekp55kbGF+zdjFyckgImEi8
\r
54 a3/ICGGLSVy4t54NxBYS2Mco0dcnC2GvZ5To7+CEsE8wSXS3+XcxcgHZSxglbvydAzSIg4NF
\r
55 QEVi1QNRkBo2AQ2JbfuXg80UEVCU2HxyP5jNLCAt8e13MxOILSwQKvF31UR2EJtXQEdi9o0G
\r
56 Voj50xglvu6QhIgLSpyc+YQFoldL4sa/l0wgq0DmLP/HAWJyAq26t0kBpEIU6IApJ7exTWAU
\r
57 moWkeRaS5lkIzQsYmVcxyqbkVunmJmbmFKcm6xYnJ+blpRbpmurlZpbopaaUbmIEB7OL0g7G
\r
58 nweVDjEKcDAq8fAqmuj7C7EmlhVX5h5ilORgUhLl5QPGghBfUn5KZUZicUZ8UWlOavEhRgkO
\r
59 ZiURXrVJQDnelMTKqtSifJiUNAeLkjivutY7PyGB9MSS1OzU1ILUIpisDAeHkgSvHMhQwaLU
\r
60 9NSKtMycEoQ0EwcnyHAeoOGSIDW8xQWJucWZ6RD5U4yKUuK83+8DJQRAEhmleXC9sGTzilEc
\r
61 6BVh3o8gVTzARAXX/QpoMBPQ4H1suiCDSxIRUlINjEJuR7+K9ixjKTTY1flwVT5zqKRgheT9
\r
62 CZvvXfP5teaAgbWZ84MVXA9sU703uzR8S7p4RfTsRcMLPYE/TCrSdR8YfXfk5P93clVp4erS
\r
63 d3tPKu1/U1EmeE37vyPXN52kcPm0bedaTZbt+9vkenqPyu7F7z4+fmI+y0N6w+FYo7anq3uf
\r
64 pR6UvarEUpyRaKjFXFScCADwROTxEQMAAA==
\r
65 Cc: notmuch@notmuchmail.org
\r
66 X-BeenThere: notmuch@notmuchmail.org
\r
67 X-Mailman-Version: 2.1.13
\r
69 List-Id: "Use and development of the notmuch mail system."
\r
70 <notmuch.notmuchmail.org>
\r
71 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
72 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
73 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
74 List-Post: <mailto:notmuch@notmuchmail.org>
\r
75 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
76 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
77 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
78 X-List-Received-Date: Mon, 06 Feb 2012 14:15:58 -0000
\r
80 Quoth Jani Nikula on Feb 06 at 7:54 am:
\r
81 > On Sun, 5 Feb 2012 23:12:05 -0500, Austin Clements <amdragon@MIT.EDU> wrote:
\r
82 > > Yikes. I don't envy you this patch. Two minor nits, otherwise this
\r
83 > > and the next patch LGTM.
\r
85 > Thanks for the review. I'll roll another version, I think it will be
\r
86 > better with your suggestions incorporated.
\r
88 > > Quoth Jani Nikula on Feb 04 at 12:41 am:
\r
89 > > > Use the new notmuch argument parser to handle arguments in "notmuch
\r
90 > > > show". There are two corner case functional changes:
\r
92 > > > 1) Also set params.raw = 1 when defaulting to raw format when part is
\r
93 > > > requested but format is not specified.
\r
95 > > Huh. So "notmuch show --part=0 <query>" was broken before.
\r
97 > Hmm, yes, it seems so. Do you think I should make this a separate fix?
\r
99 I wouldn't bother. Since this usage would throw --format=raw into
\r
100 "useless mode", clearly no one cared. No sense throwing good code
\r