Re: [PATCH] test: Make gen-threads work with python3
[notmuch-archives.git] / 7b / 2e3ad2b218af024fc3be9987f42e670125b481
1 Return-Path: <wking@tremily.us>\r
2 X-Original-To: notmuch@notmuchmail.org\r
3 Delivered-To: notmuch@notmuchmail.org\r
4 Received: from localhost (localhost [127.0.0.1])\r
5         by olra.theworths.org (Postfix) with ESMTP id 67FF9431FBC\r
6         for <notmuch@notmuchmail.org>; Fri, 31 Oct 2014 11:18:24 -0700 (PDT)\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
8 X-Spam-Flag: NO\r
9 X-Spam-Score: -0.1\r
10 X-Spam-Level: \r
11 X-Spam-Status: No, score=-0.1 tagged_above=-999 required=5\r
12         tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,\r
13         RCVD_IN_DNSWL_NONE=-0.0001] autolearn=disabled\r
14 Received: from olra.theworths.org ([127.0.0.1])\r
15         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
16         with ESMTP id 9PgrCZlUVBkK for <notmuch@notmuchmail.org>;\r
17         Fri, 31 Oct 2014 11:18:16 -0700 (PDT)\r
18 Received: from resqmta-ch2-02v.sys.comcast.net\r
19         (resqmta-ch2-02v.sys.comcast.net [69.252.207.34])\r
20         (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))\r
21         (No client certificate requested)\r
22         by olra.theworths.org (Postfix) with ESMTPS id C07FE431FAF\r
23         for <notmuch@notmuchmail.org>; Fri, 31 Oct 2014 11:18:16 -0700 (PDT)\r
24 Received: from resomta-ch2-03v.sys.comcast.net ([69.252.207.99])\r
25         by resqmta-ch2-02v.sys.comcast.net with comcast\r
26         id 9uJ81p00729Cfhx01uJFXF; Fri, 31 Oct 2014 18:18:15 +0000\r
27 Received: from odin.tremily.us ([24.18.63.50])\r
28         by resomta-ch2-03v.sys.comcast.net with comcast\r
29         id 9uJD1p00Y152l3L01uJEqz; Fri, 31 Oct 2014 18:18:15 +0000\r
30 Received: by odin.tremily.us (Postfix, from userid 1000)\r
31         id 2C2CE1440C36; Fri, 31 Oct 2014 11:18:13 -0700 (PDT)\r
32 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tremily.us; s=odin;\r
33         t=1414779493; bh=Gpjho2Ci/yDqr/kti83DN0jrgE1l+AdrCNrx75kDB74=;\r
34         h=Date:From:To:Cc:Subject:References:In-Reply-To;\r
35         b=QdvP/arKYzbGxLYnVLWjHN5i+z1eoqyZroliYqqSogyU3XE0z4KMHy5Wi+MSlWFtJ\r
36         Vx70N2kmGoLSvIC78Dvk6FJVyPHSIJEDXBLjQi3nPFVUUhZyRYVnS8unb+/4534Vf7\r
37         Ms9uWcHjYksSkeMbuR8CTNEIcag+DPiQnMVkDGLE=\r
38 Date: Fri, 31 Oct 2014 11:18:13 -0700\r
39 From: "W. Trevor King" <wking@tremily.us>\r
40 To: Jesse Rosenthal <jrosenthal@jhu.edu>\r
41 Subject: Re: [PATCH] test: Make gen-threads work with python3\r
42 Message-ID: <20141031181812.GS15443@odin.tremily.us>\r
43 References: <1414776805-30000-1-git-send-email-jrosenthal@jhu.edu>\r
44         <20141031174153.GQ15443@odin.tremily.us> <87bnosdsjh.fsf@jhu.edu>\r
45 MIME-Version: 1.0\r
46 Content-Type: multipart/signed; micalg=pgp-sha1;\r
47         protocol="application/pgp-signature"; boundary="vdyjigDobekge4RG"\r
48 Content-Disposition: inline\r
49 In-Reply-To: <87bnosdsjh.fsf@jhu.edu>\r
50 OpenPGP: id=39A2F3FA2AB17E5D8764F388FC29BDCDF15F5BE8;\r
51         url=http://tremily.us/pubkey.txt\r
52 User-Agent: Mutt/1.5.23 (2014-03-12)\r
53 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net;\r
54         s=q20140121; t=1414779495;\r
55         bh=A0Ii2kqfM7UR3h0csNuXi2dv2aQjU6l2ly1VayuhkiA=;\r
56         h=Received:Received:Received:Date:From:To:Subject:Message-ID:\r
57         MIME-Version:Content-Type;\r
58         b=aAHmRL+ROdxjA5yKlnR4EpjmJeelqTWMuwsXhEhe5i9ecU1Haa7HSxo8pNLzAye/Z\r
59         fTF9yeBBhDQzQfBEUixIsT3OfsyczzaMrPogwBg3GhXAu99QCTsvCOvy6snXMyrGu9\r
60         QR610B47SyXK+qPBRgvYTyyUBdxsuEJ75vQ2Ub8bmwn8NzkBtIzWguisBhDp96JIHz\r
61         t2QVa4LGTqNcSNEOtTUiBJLZ3zKI60c0/gMx4qXqQGLNwwcqaVGHH21WXy55J0rcG7\r
62         H+Dqb81Y9WXJOzgROCOvr4rKNeYj/6gz/pDLZ6usXYukqcSZmI64YQCiisrwL+ufe0\r
63         byP9m4+oYic/A==\r
64 Cc: notmuch@notmuchmail.org\r
65 X-BeenThere: notmuch@notmuchmail.org\r
66 X-Mailman-Version: 2.1.13\r
67 Precedence: list\r
68 List-Id: "Use and development of the notmuch mail system."\r
69         <notmuch.notmuchmail.org>\r
70 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
71         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
72 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
73 List-Post: <mailto:notmuch@notmuchmail.org>\r
74 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
75 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
76         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
77 X-List-Received-Date: Fri, 31 Oct 2014 18:18:24 -0000\r
78 \r
79 \r
80 --vdyjigDobekge4RG\r
81 Content-Type: text/plain; charset=utf-8\r
82 Content-Disposition: inline\r
83 Content-Transfer-Encoding: quoted-printable\r
84 \r
85 On Fri, Oct 31, 2014 at 02:04:50PM -0400, Jesse Rosenthal wrote:\r
86 > W. Trevor King writes:\r
87 > > On Fri, Oct 31, 2014 at 01:33:25PM -0400, Jesse Rosenthal wrote:\r
88 > >> We instead initalize the dictionary using the dict comprehension\r
89 > >> and then update it with the values from the tree. This will work\r
90 > >> with both python2 and python3.\r
91 > >\r
92 > > Dict comprehensions are new in 2.7 [1,2], so this drops support\r
93 > > for systems where =E2=80=98python=E2=80=99 means =E2=80=98python2.6=E2=\r
94 =80=99.  Personally, I'm\r
95 > > fine with that, but I thought I'd point it out in case 2.6 users\r
96 > > wanted to push back ;).\r
97 >=20\r
98 > The comprehension was already in the previous version, so I figured that\r
99 > people were already cool with 2.7+.\r
100 \r
101 Ah, good point :).  Besides looking good to me, I can confirm that I\r
102 see a TypeError (and a lot of CPU usage ;) from T260-thread-order.sh\r
103 before this patch which is fixed by this patch.\r
104 \r
105 Cheers,\r
106 Trevor\r
107 \r
108 --=20\r
109 This email may be signed or encrypted with GnuPG (http://www.gnupg.org).\r
110 For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy\r
111 \r
112 --vdyjigDobekge4RG\r
113 Content-Type: application/pgp-signature; name="signature.asc"\r
114 Content-Description: OpenPGP digital signature\r
115 \r
116 -----BEGIN PGP SIGNATURE-----\r
117 Version: GnuPG v2\r
118 \r
119 iQIcBAEBAgAGBQJUU9JiAAoJEG8/JgBt8ol88CgP/3eB+Xr4T2KBCWgdCCHV3M/G\r
120 xhcpqPnXZGw8jVQLn4RVbthrg4Z0ZbbMrpMstdqPnh6+SPlqzXUdvverz6ILlcdL\r
121 MCWHDll3wiq6d9Fa2FkdQZMD3UUpYdEP/JzVM77VDQGB0EYytDs1jIHh6K1a00uE\r
122 UvdBlT87ik1yoHWIBbb/n56ZWcRq3wTMcveDBaPo0Z0nrxtT8kZM0RNX6ONuYvFF\r
123 8DZeREVeImjy/vgIltuXTTpZ7QdDrnuxYpv3JE08vOc2hLPtJNXhQJDypmGX7N55\r
124 JfumCL0cOjlQe18tChxnlfPj7X6QqVy0wvwG+8GtJhNPAmiVhATQDpM9AxCslk4a\r
125 d3LFEus1jrIysq5q86gRTmWJeGTz+XmJNqvod35cPKsWOR2WI4nvwVuqarktvFZi\r
126 2kvyCqVJ80gYCyGqhQ1VkpeNf8vk1g/+isrd9Ja928pfYnfSeVRz4t2PnlCuigZA\r
127 5HeKGQVTyEf6xamR9SrB2nfTMLUW9inXofEhpzX4n5uRTyPvf4ifxuqhLGBDtj+h\r
128 R01COJy1Jd7x2CBErqABjk+ygKWzZd5GKoCStzFVJeAQvwm7TSAcNyPZsE/x+sLw\r
129 m0Q9yCP56i4fQDTjbP4Xj0F3pnmamI0TDu31POk0LyxQmA4rK1XlHoOHxu8rNzcv\r
130 sgTX8zho6VJ3NVP6TzQJ\r
131 =WRqI\r
132 -----END PGP SIGNATURE-----\r
133 \r
134 --vdyjigDobekge4RG--\r