1 Return-Path: <teythoon@jade-hamburg.de>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 8D561431FB6
\r
6 for <notmuch@notmuchmail.org>; Sat, 5 May 2012 04:16:50 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id XM8BEVLGEvfZ for <notmuch@notmuchmail.org>;
\r
16 Sat, 5 May 2012 04:16:49 -0700 (PDT)
\r
17 Received: from mail.cryptobitch.de (cryptobitch.de [88.198.7.68])
\r
18 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id BBFC1431FAE
\r
21 for <notmuch@notmuchmail.org>; Sat, 5 May 2012 04:16:49 -0700 (PDT)
\r
22 Received: from mail.jade-hamburg.de (mail.jade-hamburg.de [85.183.11.228])
\r
23 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
\r
24 (No client certificate requested)
\r
25 by mail.cryptobitch.de (Postfix) with ESMTPSA id 33CA6588B05
\r
26 for <notmuch@notmuchmail.org>; Sat, 5 May 2012 13:16:45 +0200 (CEST)
\r
27 Received: by mail.jade-hamburg.de (Postfix, from userid 401)
\r
28 id 92921DF2A3; Sat, 5 May 2012 13:16:44 +0200 (CEST)
\r
29 Received: from thinkbox.jade-hamburg.de (thinkbox.jadE-Hamburg.de
\r
30 [10.1.1.155]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client
\r
31 certificate requested) (Authenticated sender: teythoon) by
\r
32 mail.jade-hamburg.de (Postfix) with ESMTPSA id 6E39CDF2A0; Sat, 5 May 2012
\r
33 13:16:39 +0200 (CEST)
\r
34 Received: from teythoon by thinkbox.jade-hamburg.de with local (Exim 4.77)
\r
35 (envelope-from <teythoon@thinkbox.jade-hamburg.de>)
\r
36 id 1SQcxb-0008Cg-Gx; Sat, 05 May 2012 13:15:35 +0200
\r
37 Content-Type: text/plain; charset="utf-8"
\r
39 Content-Transfer-Encoding: quoted-printable
\r
40 To: Austin Clements <amdragon@MIT.EDU>,
\r
41 From: Justus Winter <4winter@informatik.uni-hamburg.de>
\r
42 In-Reply-To: <20120504184320.GO2704@mit.edu>
\r
43 References: <20120430195420.2528.48612@thinkbox.jade-hamburg.de>
\r
44 <1335815744-15258-1-git-send-email-4winter@informatik.uni-hamburg.de>
\r
45 <20120504183822.GN2704@mit.edu> <20120504184320.GO2704@mit.edu>
\r
46 Message-ID: <20120505111535.3687.9018@thinkbox.jade-hamburg.de>
\r
47 User-Agent: alot/0.3+
\r
48 Subject: Re: [PATCH 1/5] go: reorganize the go bindings
\r
49 Date: Sat, 05 May 2012 13:15:35 +0200
\r
50 Cc: notmuch@notmuchmail.org
\r
51 X-BeenThere: notmuch@notmuchmail.org
\r
52 X-Mailman-Version: 2.1.13
\r
54 List-Id: "Use and development of the notmuch mail system."
\r
55 <notmuch.notmuchmail.org>
\r
56 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
57 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
58 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
59 List-Post: <mailto:notmuch@notmuchmail.org>
\r
60 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
61 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
62 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
63 X-List-Received-Date: Sat, 05 May 2012 11:16:50 -0000
\r
65 Quoting Austin Clements (2012-05-04 20:43:20)
\r
66 > Quoth myself on May 04 at 2:38 pm:
\r
67 > > Quoth Justus Winter on Apr 30 at 9:55 pm:
\r
68 > > > Signed-off-by: Justus Winter <4winter@informatik.uni-hamburg.de>
\r
71 > > Whole series LGTM (and yay gofmt!). I have only two minor comments.
\r
74 > > It would be nice to have a little more log message for some of these.
\r
75 > > Mostly the first one could use some explanation of why you're
\r
76 > > rearranging the source tree and a mention that there are no changes to
\r
77 > > the files (since this is hard to get from the diff).
\r
81 > > It would also be nice if this could optionally be built using the
\r
82 > > libnotmuch and notmuch.h directly from the source tree containing the
\r
83 > > Go bindings, rather than requiring them to be installed system-wide.
\r
84 > > I don't know Go 1's build system well enough to know if there's an
\r
85 > > easy way to do this.
\r
87 Yes, I've been pondering that myself. There are CGO_CFLAGS and
\r
88 CGO_LDFLAGS that could be used to point the c compiler to the right
\r
89 paths. I'll experiment with this and propose a patch.
\r
91 > Oh, also a news patch would be good, though that can obviously be
\r
96 I'll send an updated patch series. Thanks for the review.
\r