1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 23740431FBD
\r
6 for <notmuch@notmuchmail.org>; Sat, 25 Jan 2014 13:27:56 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id oxzFRsY9auLy for <notmuch@notmuchmail.org>;
\r
16 Sat, 25 Jan 2014 13:27:48 -0800 (PST)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 8C61E431FBC
\r
19 for <notmuch@notmuchmail.org>; Sat, 25 Jan 2014 13:27:48 -0800 (PST)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id 109801000B3;
\r
22 Sat, 25 Jan 2014 23:27:39 +0200 (EET)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: David Bremner <david@tethera.net>,
\r
25 Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
\r
26 Subject: Re: [PATCH] emacs: initialize ido mode in notmuch-mua.el
\r
27 In-Reply-To: <87bnyzoqq9.fsf@zancas.localnet>
\r
28 References: <87y5sipcjn.fsf@qmul.ac.uk>
\r
29 <1329900529-16295-1-git-send-email-markwalters1009@gmail.com>
\r
30 <87bnyzoqq9.fsf@zancas.localnet>
\r
31 User-Agent: Notmuch/0.17+41~g8e7fabf (http://notmuchmail.org) Emacs/24.3.1
\r
32 (x86_64-unknown-linux-gnu)
\r
33 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
34 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
35 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
36 Date: Sat, 25 Jan 2014 23:27:38 +0200
\r
37 Message-ID: <m2a9ejkb05.fsf@guru.guru-group.fi>
\r
39 Content-Type: text/plain
\r
40 X-BeenThere: notmuch@notmuchmail.org
\r
41 X-Mailman-Version: 2.1.13
\r
43 List-Id: "Use and development of the notmuch mail system."
\r
44 <notmuch.notmuchmail.org>
\r
45 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
46 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
47 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
48 List-Post: <mailto:notmuch@notmuchmail.org>
\r
49 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
50 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
51 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
52 X-List-Received-Date: Sat, 25 Jan 2014 21:27:56 -0000
\r
54 On Sat, Jan 25 2014, David Bremner <david@tethera.net> wrote:
\r
56 > Mark Walters <markwalters1009@gmail.com> writes:
\r
58 >> ido-completing-read is used in notmuch-mua.el without any
\r
59 >> initialization. This should work but a bug (emacs bug #3247) in some
\r
60 >> emacs 23 versions (including 23.2.1 from Debian stable) causes emacs
\r
61 >> to get stuck in the mini-buffer. This tests to see if ido-mode has
\r
62 >> been initialized and if not calls it. This avoids the bug for these
\r
63 >> older versions of emacs.
\r
65 >> This is the only place that ido-completing-read is used so an alternative
\r
66 >> would be to replace ido-completing-read by completing-read but cworth
\r
67 >> expressed a preference for the ido version in
\r
68 >> id:"87wrhfvk6a.fsf@yoom.home.cworth.
\r
70 > This patch was tagged wip, but then there was no progress ;). It still
\r
71 > applies cleanly, and doesn't seem to do any harm in emacs 23.4 nor
\r
72 > emacs24.3. I don't have 23.2 at hand but I guess Tomi or Mark can
\r
73 > confirm it actually fixes the bug there.
\r
75 > I propose we either apply the patch or ::wontfix the bug.
\r
77 How about doing it with defadvice with something like:
\r
79 (from http://comments.gmane.org/gmane.emacs.bugs/27856 one can notice
\r
80 this happening with emacs 23.3 -- David can check whether 23.4 if
\r
83 (if (and (= emacs-major-version 23) (< emacs-minor-version 4))
\r
84 (defadvice ido-completing-read (before notmuch-ido-mode-init activate)
\r
85 (unless (ido-mode) (ido-mode t))
\r
86 (ad-disable-advice 'ido-completing-read 'before 'notmuch-ido-mode-init)))
\r