1 Return-Path: <jrollins@finestructure.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 7209A429E25
\r
6 for <notmuch@notmuchmail.org>; Sat, 10 Dec 2011 13:17:10 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id UrLM6jk7D+kc for <notmuch@notmuchmail.org>;
\r
16 Sat, 10 Dec 2011 13:17:09 -0800 (PST)
\r
17 Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu
\r
19 by olra.theworths.org (Postfix) with ESMTP id 7D6F9431FB6
\r
20 for <notmuch@notmuchmail.org>; Sat, 10 Dec 2011 13:17:09 -0800 (PST)
\r
21 Received: from fire-doxen.imss.caltech.edu (localhost [127.0.0.1])
\r
22 by fire-doxen-postvirus (Postfix) with ESMTP id EFEAA328055;
\r
23 Sat, 10 Dec 2011 13:17:06 -0800 (PST)
\r
24 X-Spam-Scanned: at Caltech-IMSS on fire-doxen by amavisd-new
\r
25 Received: from finestructure.net (cpe-76-174-137-84.socal.res.rr.com
\r
26 [76.174.137.84]) (Authenticated sender: jrollins)
\r
27 by fire-doxen-submit (Postfix) with ESMTP id 0CE65328022;
\r
28 Sat, 10 Dec 2011 13:17:03 -0800 (PST)
\r
29 Received: by finestructure.net (Postfix, from userid 1000)
\r
30 id ADAF150F; Sat, 10 Dec 2011 16:17:02 -0500 (EST)
\r
31 From: Jameson Graef Rollins <jrollins@finestructure.net>
\r
32 To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>,
\r
33 Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
\r
34 Subject: Re: [PATCH 2/4] Introduce a generic tree-like abstraction for MIME
\r
36 In-Reply-To: <87k46572f7.fsf@gmail.com>
\r
37 References: <1323027100-10307-1-git-send-email-amdragon@mit.edu>
\r
38 <1323460468-4030-1-git-send-email-amdragon@mit.edu>
\r
39 <1323460468-4030-3-git-send-email-amdragon@mit.edu>
\r
40 <87k46572f7.fsf@gmail.com>
\r
41 User-Agent: Notmuch/0.10.2+74~g994a706 (http://notmuchmail.org) Emacs/23.3.1
\r
42 (x86_64-pc-linux-gnu)
\r
43 Date: Sat, 10 Dec 2011 13:17:02 -0800
\r
44 Message-ID: <87mxb05dpt.fsf@servo.finestructure.net>
\r
46 Content-Type: multipart/signed; boundary="=-=-=";
\r
47 micalg=pgp-sha256; protocol="application/pgp-signature"
\r
48 X-BeenThere: notmuch@notmuchmail.org
\r
49 X-Mailman-Version: 2.1.13
\r
51 List-Id: "Use and development of the notmuch mail system."
\r
52 <notmuch.notmuchmail.org>
\r
53 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
54 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
55 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
56 List-Post: <mailto:notmuch@notmuchmail.org>
\r
57 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
58 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
59 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
60 X-List-Received-Date: Sat, 10 Dec 2011 21:17:10 -0000
\r
63 Content-Transfer-Encoding: quoted-printable
\r
65 On Sat, 10 Dec 2011 03:25:48 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmai=
\r
67 > + notmuch_bool_t decrypt_success;
\r
69 > Perhaps s/decrypt_success/is_decrypted/ for consistency with
\r
72 This difference doesn't seem so bad to me, since the is_ variables point
\r
73 to states of the original message, where as decrypt_success reflects the
\r
74 processing of the message only.
\r
76 > + out->is_encrypted =3D TRUE;
\r
77 > + out->is_signed =3D TRUE;
\r
79 > These are set only if we do decryption/verification. But their
\r
80 > names and comments imply that they should reflect properties of
\r
81 > the part and be set independently from whether we are actually
\r
82 > doing decryption or verification.
\r
84 I don't think this directly affects anything at the moment, but this is
\r
85 a good point. I can imagine that it might be good to maintain that
\r
86 distinction down the line so it's probably worth being consistent here.
\r
88 > + /* For some reason the GMimeSignatureValidity returned
\r
89 > + * here is not a const (inconsistent with that
\r
91 > + * g_mime_multipart_encrypted_get_signature_validity,
\r
92 > + * and therefore needs to be properly disposed of.
\r
93 > + * Hopefully the API will become more consistent. */
\r
95 > Ouch. In gmime 2.6 this API has changed, but looks like the
\r
96 > issue is still there. Is there a bug for it? If yes, we should
\r
97 > add a reference to the comment. Otherwise, we should file the
\r
98 > bug and then add a reference to the comment :)
\r
100 Don't blame any of this stuff on Austin. This is left over from the
\r
101 original crypto processing patches. I know dkg was in touch with the
\r
102 gmime maintainers on this issue, but I'm not sure if a bug was filed.
\r
104 > Both decryption and verification use cryptoctx. But decryption
\r
105 > is done iff decrypt is true (without checking if cryptoctx is
\r
106 > set) and verification is done iff cryptoctx is set (without any
\r
107 > special flag). Why is it asymmetric? Do we need to check if
\r
108 > cryptoctx is set for decryption?
\r
110 We probably should. We can probably fix this in followup patches, since
\r
111 Austin is just working off of what dkg and I put in there originally.
\r
116 Content-Type: application/pgp-signature
\r
118 -----BEGIN PGP SIGNATURE-----
\r
119 Version: GnuPG v1.4.11 (GNU/Linux)
\r
121 iQIcBAEBCAAGBQJO48xOAAoJEO00zqvie6q8mhYP/3No5YtwAyqFUw9HZxe6zKJR
\r
122 5KeicO8ZhMMbs/hH91jxmI3xPdN4psA79aLbaVIfNbd+GLJm2domRYUlzF+92E4t
\r
123 XnXX3nNHc5mHW+TGz8t1DAhSqOcZcHbMgypWYbyimuwjQhr3fDKkXVD/iOnZPTAq
\r
124 bDtvnTrat/Nw9nOza5gX9FeZsyNhQQgV9S3GadV6TROHcTBCnmEdx7b3ljaeMwBf
\r
125 s/c7ng0U8OeoyAEVXR+cDjXGpwFmCfywwUEk7mUVlVLLh4hQjhsO4ljdG04MDsCX
\r
126 2hRGLIpL1091rsfHH5qVElDcHmszk2yljedZ942hJP4IxRVUmAooELomBdFQYzlV
\r
127 Kk5ebPKAdWUr9Bu2vw/U2oMdcpVUEDhvdr+0cUYbcTn5fE9jdmUxXBroixB42H5o
\r
128 N9VdDj3IBP5gbr/sWdFhQiyMpOZZvy9/VbG6kGkN8GxTOBjQZnTpzRF7RayWODNv
\r
129 JTyKbkbksJTe7RATElJNmCthEZ5aXY9w4LPWYzuGeHZ9coUlnXJMjl8h3D7QzLur
\r
130 BgHXfRdZ7P4gqDIC0HTOKGhgL34S0WTpRU3Na3mEN9Wu7vnv6hjZVDTDFjZ4jK/a
\r
131 MVjH5LxA3075byUwX4BIhohQR2QZDicQc+axtPu8dR79GNHdlBt/XdplOpHhTuPu
\r
132 wVjUUXfhtBOR0Hcym7uw
\r
134 -----END PGP SIGNATURE-----
\r